Date: Sun, 7 May 2000 20:29:44 +0930 From: Greg Lehey <grog@lemis.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: "Justin T. Gibbs" <gibbs@FreeBSD.ORG>, FreeBSD-arch@FreeBSD.ORG Subject: Re: Support for bootable Vinum file systems: please review Message-ID: <20000507202944.I55316@freebie.lemis.com> In-Reply-To: <12215.957694109@critter.freebsd.dk> References: <20000507174638.E55316@freebie.lemis.com> <12215.957694109@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, 7 May 2000 at 12:08:29 +0200, Poul-Henning Kamp wrote: > In message <20000507174638.E55316@freebie.lemis.com>, Greg Lehey writes: >> On Friday, 5 May 2000 at 12:52:33 +0200, Poul-Henning Kamp wrote: >>> >>>> I've been testing vinum root file systems for a couple of months now, >>>> and I'd like to commit the code. I'm attaching the patches, which you >>>> can also access at http://www.FreeBSD.org/~grog/vinum-root.html. >>> >>> It looks good, but I think using devstat to find possible disks is >>> wrong. >>> >>> The right way to do it is probably to link the "struct disk"s >>> registered by the drivers with disk_creat() into a list which can >>> be searched. >> >> This is pretty much what struct devstat does, except that it's more >> global. Why should we maintain two lists, just because one is >> primarily intended for statistics? >> >> Anyway, I assume this isn't so much a criticism of the fix as of the >> infrastructure around it. Correct? > > No, this is an objection to opening up devstat that way. Can you make an alternative suggestion? Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000507202944.I55316>