From owner-freebsd-current@FreeBSD.ORG Thu Apr 5 17:52:52 2012 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEAE2106566B; Thu, 5 Apr 2012 17:52:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 61B2E8FC1C; Thu, 5 Apr 2012 17:52:52 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q35HqiMr040530; Thu, 5 Apr 2012 20:52:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q35HqiAB027968; Thu, 5 Apr 2012 20:52:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q35Hqi7X027967; Thu, 5 Apr 2012 20:52:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Apr 2012 20:52:44 +0300 From: Konstantin Belousov To: jasone@freebsd.org Message-ID: <20120405175244.GZ2358@deviant.kiev.zoral.com.ua> References: <431CB493-836B-4DF4-AC42-A7C6ABF7DE3E@canonware.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+DdorAa6Vvp/ZpQm" Content-Disposition: inline In-Reply-To: <431CB493-836B-4DF4-AC42-A7C6ABF7DE3E@canonware.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: current@freebsd.org Subject: Re: contrib/jemalloc X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2012 17:52:53 -0000 --+DdorAa6Vvp/ZpQm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 04, 2012 at 09:56:45PM -0700, Jason Evans wrote: > I have the current version of jemalloc integrated into libc as contrib/je= malloc: >=20 > http://people.freebsd.org/~jasone/patches/jemalloc_20120404b.patch > * Are the symbol versioning specifications right, and are the > compatibility symbols for _malloc_options and _malloc_message workable? Why do you manually added __sys_compat() for the symbols ? My reading of the patch shows that you do not change the ABI, and symbols are still at FBSD_1.0 and even in Symbol.map. The 1.3 symbols have different names, without prepended '_' ? Please correct me if I am wrong, but it seems that the __sym_compat() magic is not needed. > * Is the light editing of the jemalloc manual page sufficient? Keeping > the changes minimal will make regular imports less work, but the > result is less tailored to FreeBSD. > Might be, keep existing but somewhat trimmed malloc(3) page as is, but add the unedited man from contrib as jemalloc(3), xreferencing it from malloc(3) ? --+DdorAa6Vvp/ZpQm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk992+wACgkQC3+MBN1Mb4g68QCgwgB3y4OwspigY0IeSWIgZXKo YXUAnAmByJ6qu7e4GxHuCKS5g6xqO3t8 =iu0P -----END PGP SIGNATURE----- --+DdorAa6Vvp/ZpQm--