From owner-svn-src-all@freebsd.org  Tue Dec 12 20:39:40 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0C58E84168;
 Tue, 12 Dec 2017 20:39:40 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 633CC71B7F;
 Tue, 12 Dec 2017 20:39:40 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id vBCKdcqp088347;
 Tue, 12 Dec 2017 12:39:38 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id vBCKdcV8088346;
 Tue, 12 Dec 2017 12:39:38 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201712122039.vBCKdcV8088346@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r326809 - head/sys/dev/cardbus
In-Reply-To: <201712122022.vBCKM9Kd050769@repo.freebsd.org>
To: Warner Losh <imp@freebsd.org>
Date: Tue, 12 Dec 2017 12:39:38 -0800 (PST)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Dec 2017 20:39:40 -0000

> Author: imp
> Date: Tue Dec 12 20:22:09 2017
> New Revision: 326809
> URL: https://svnweb.freebsd.org/changeset/base/326809
> 
> Log:
>   1k objects on the stack are a bad idea. While it's likely safe in this
>   context, it's also safe to allocate the memory and free it instead.
>   
>   Noticed by: Eugene Grosbein's script

YEA!!!  One down, 20 to go and then see how the kstack issue does?

And thank you for quickly fixing this.

> Modified:
>   head/sys/dev/cardbus/cardbus_cis.c
> 
> Modified: head/sys/dev/cardbus/cardbus_cis.c
> ==============================================================================
> --- head/sys/dev/cardbus/cardbus_cis.c	Tue Dec 12 20:15:57 2017	(r326808)
> +++ head/sys/dev/cardbus/cardbus_cis.c	Tue Dec 12 20:22:09 2017	(r326809)
> @@ -583,7 +583,7 @@ int
>  cardbus_parse_cis(device_t cbdev, device_t child,
...

-- 
Rod Grimes                                                 rgrimes@freebsd.org