Date: Wed, 11 May 2016 19:34:17 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Rui Paulo <rpaulo@me.com>, John Baldwin <jhb@freebsd.org>, freebsd-arch@freebsd.org, cem@freebsd.org Subject: Re: KASSERT: always assert; KWARN Message-ID: <fe73ace8-b59c-c43a-3311-dd99de9b3f2b@freebsd.org> In-Reply-To: <1463010600.7806.10.camel@me.com> References: <CAG6CVpWzuK6cZx3QnQhKOu=6GZBJF4cJQdNXgJZeXYhuJJANJg@mail.gmail.com> <ca489ff1-f520-3feb-0525-425eb015af7a@freebsd.org> <CAG6CVpWNzmaqKsOKJtuG1642m0knkupAoK=BoGq5iNHC1TA-Gw@mail.gmail.com> <31200026.OetD7h0dHc@ralph.baldwin.cx> <1463010600.7806.10.camel@me.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/11/16 4:50 PM, Rui Paulo wrote: > On Wed, 2016-05-11 at 09:48 -0700, John Baldwin wrote: >> Eh, if you keep going past many of the assertions the original code >> enabled, you will get _more_ bogus assertions as fallout. > I agree with John. We really shouldn't be fiddling with this. > > There's just one case where this could be useful: you just imported a > bunch of code that you don't understand and you're using the kassert's > as a way to create a mental model of the code. However, this is a very > specific edge case. > I'm not sure what you and John are suggesting here. Are you suggesting to revert the explicit panics in the witness code, or to revert the entire kassert_warn subsystem? -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fe73ace8-b59c-c43a-3311-dd99de9b3f2b>