From owner-freebsd-standards@FreeBSD.ORG Fri Jul 4 16:19:24 2014 Return-Path: Delivered-To: freebsd-standards@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 50787CF1 for ; Fri, 4 Jul 2014 16:19:24 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1D2B32997 for ; Fri, 4 Jul 2014 16:19:24 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s64GJNec077882 for ; Fri, 4 Jul 2014 17:19:23 +0100 (BST) (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-standards@FreeBSD.org Subject: [Bug 191586] FreeBSD doesn't validate negative edgecases in bind(2)/connect(2)/listen(2) like POSIX requires Date: Fri, 04 Jul 2014 16:19:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: standards X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kevlo@FreeBSD.org X-Bugzilla-Status: In Discussion X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-standards@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jul 2014 16:19:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191586 Kevin Lo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Triage |In Discussion CC| |kevlo@FreeBSD.org --- Comment #3 from Kevin Lo --- (In reply to Terry Lambert from comment #2) > Some valid statements, some invalid. You would have to configure the VSX4 > tests correctly to expect the results that you'd get, but some of these are > optional implement, while still being conformant. > > For the interfaces in question, the relevant documents are: > http://pubs.opengroup.org/onlinepubs/009695399/functions/bind.html > http://pubs.opengroup.org/onlinepubs/009695399/functions/connect.html > http://pubs.opengroup.org/onlinepubs/009695399/functions/listen.html > > > Comments are by API: > > bind(2): > > The EAFNOSUPPORT is non-optional; however, the test code is bogus, in that > it has to specify an existing address family, such as AF_INET, rather than a > potentially loaded/pluggable address family. Because this is a negative > assertion test, it needs to hit on something that's actually guaranteed to > be there, such as AF_INET r AF_UNIX. [snip] Here's the diff that enables check family for bind(2), ok? Index: sys/netinet/in_pcb.c =================================================================== --- sys/netinet/in_pcb.c (revision 268261) +++ sys/netinet/in_pcb.c (working copy) @@ -528,14 +528,11 @@ in_pcbbind_setup(struct inpcb *inp, struct sockadd sin = (struct sockaddr_in *)nam; if (nam->sa_len != sizeof (*sin)) return (EINVAL); -#ifdef notdef /* - * We should check the family, but old programs - * incorrectly fail to initialize it. + * Family check. */ if (sin->sin_family != AF_INET) return (EAFNOSUPPORT); -#endif error = prison_local_ip4(cred, &sin->sin_addr); if (error) return (error); -- You are receiving this mail because: You are the assignee for the bug.