Date: Thu, 11 Aug 2005 17:22:07 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: alpha@freebsd.org, current@freebsd.org Subject: Re: Locking fixes for dc(4): please test! Message-ID: <200508111722.09584.jhb@FreeBSD.org> In-Reply-To: <B76A5A98-6A32-4181-AB7D-644A0723A1E9@xcllnt.net> References: <200508041255.05839.jhb@FreeBSD.org> <200508101656.23255.jhb@FreeBSD.org> <B76A5A98-6A32-4181-AB7D-644A0723A1E9@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 11 August 2005 04:27 pm, Marcel Moolenaar wrote: > On Aug 10, 2005, at 1:56 PM, John Baldwin wrote: > > On 2005.08.04 12:55:05 -0400, John Baldwin wrote: > >> I have some fixes for the locking in the dc(4) driver, please test > >> them > >> if you have some dc(4) hardware, thanks! > >> > >> http://www.FreeBSD.org/~jhb/patches/dc_locking.patch > > > > I've updated the patch to use callout_init_mtx() and would > > appreciate it if > > the folks who tested it earlier could retest it. Also, can someone > > with an > > Alpha please test this as I messed around with the SRM_MEDIA code > > some in > > order to make the locking in dc_init_locked() sane and it needs > > testing on an > > Alpha. > > It doesn't build on alpha: > > ds10% cd /sys/alpha/compile/DS10 > ds10% make > cc -c -O -pipe -mcpu=ev6 -mieee -Wall -Wredundant-decls -Wnested- > externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith - > Winline -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- - > I. -I../../.. -I../../../contrib/dev/acpica -I../../../contrib/altq - > I../../../contrib/ipfilter -I../../../contrib/pf -I../../../contrib/ > dev/ath -I../../../contrib/dev/ath/freebsd -I../../../contrib/ngatm - > I../../../dev/twa -D_KERNEL -include opt_global.h -fno-common - > finline-limit=15000 --param inline-unit-growth=100 --param large- > function-growth=1000 -mno-fp-regs -ffixed-8 -Wa,-mev6 -ffreestanding > -Werror ../../../pci/if_dc.c > ../../../pci/if_dc.c: In function `dc_init': > ../../../pci/if_dc.c:3407: error: `ifp' undeclared (first use in this > function) > ../../../pci/if_dc.c:3407: error: (Each undeclared identifier is > reported only once > ../../../pci/if_dc.c:3407: error: for each function it appears in.) > ../../../pci/if_dc.c:3407: error: `mii' undeclared (first use in this > function) > *** Error code 1 > > ...The SRM_MEDIA macro is probably only defined on alpha... Yeah it is, which is why I wanted someone with an Alpha to test it. You should be able to replace 'ifp' with 'sc->dc_ifp' on line 3407. I'll fix the patch and re-upload it as well. Thanks. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200508111722.09584.jhb>