Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 Jun 2018 13:36:49 -0400
From:      Allan Jude <allanjude@freebsd.org>
To:        freebsd-current@freebsd.org
Subject:   Re: Proper way to remove never used ioctls
Message-ID:  <e80e9b2a-4165-feba-a689-e340a1062268@freebsd.org>
In-Reply-To: <CANCZdfoScVOooB%2Bm9Z3CmsVzXyKC6D_wht2CQBbFytVyRfDnMQ@mail.gmail.com>
References:  <3ea085128a4e677a4d4150be18b366bd@kondratyev.su> <CANCZdfoScVOooB%2Bm9Z3CmsVzXyKC6D_wht2CQBbFytVyRfDnMQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--SduJM6ALE2xb4qIQyBnyMJ5byptvH4Enk
Content-Type: multipart/mixed; boundary="X95spYZdoIBGAr6EMZBRnjXOSCVoVHvnt";
 protected-headers="v1"
From: Allan Jude <allanjude@freebsd.org>
To: freebsd-current@freebsd.org
Message-ID: <e80e9b2a-4165-feba-a689-e340a1062268@freebsd.org>
Subject: Re: Proper way to remove never used ioctls
References: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su>
 <CANCZdfoScVOooB+m9Z3CmsVzXyKC6D_wht2CQBbFytVyRfDnMQ@mail.gmail.com>
In-Reply-To: <CANCZdfoScVOooB+m9Z3CmsVzXyKC6D_wht2CQBbFytVyRfDnMQ@mail.gmail.com>

--X95spYZdoIBGAr6EMZBRnjXOSCVoVHvnt
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 2018-06-02 11:03, Warner Losh wrote:
> On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev <vladimir@kondratye=
v.su>
> wrote:
>=20
>> Hi,
>>
>> Our sys/mouse.h header has a definition of MOUSE_GETVARS and MOUSE_SET=
VARS
>> ioctls which are not documented and only stubbed in a few drivers: mse=
(4),
>> psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS
>> implemented in psm(4)
>>
>> Given the fact that they were introduced 20 years ago, implementation =
was
>> never completed and googling on them shows no traces of usage in index=
ed
>> universe, is it acceptable to just drop both defines and implementatio=
n
>> w.o. leaving any COMPAT_FREEBSD shims?
>=20
>=20
> I'd prepare a patch just removing them. I'd then send that patch to the=

> ports mgr team and request a exp-run. Details for that can be found in
> https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/p=
orts.html
>=20
> Once that's done, submit a Phabricator review and send me email. I'll m=
ake
> sure it gets pushed in if there's no objections.
>=20
> Warner
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.o=
rg"
>=20

This indeed seems to be the correct approach. The exp-run will compile
the entire ports tree against the patched base system, and identify any
3rd party software that fails to compile because of the change.

--=20
Allan Jude


--X95spYZdoIBGAr6EMZBRnjXOSCVoVHvnt--

--SduJM6ALE2xb4qIQyBnyMJ5byptvH4Enk
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQIcBAEBAgAGBQJbEtWxAAoJEBmVNT4SmAt+GRMP/RzO/9F87F6incGpd1y1nun1
20HPznyAq1ARJMjPdkQqL7A/CwP07nmo4BqS3p8bw+oTkTA/el/ifArxz2Cjj4LA
Q/4I25uInBpm3sh+IIAcX3nAmwvrE6yoG+WK5aycEqz87TRQDatR7FdJ+jWRj2Ht
oiJhK2I2wY5yYN/YUwERcNBp3qonfzOnGATJ2gecO56kNiVWommi4P6PpVg83OpA
dmc2/e9LWirXK/ZRLHQnkfYl0M+NY7eGdK+etW1WAk50T4+qM1h6PtkqYkVskLz9
zELH1miEfpylvVynVVw94U7IGWwdjNAS8EvGGcD8k0JsXpTXOC4iAfVhYXL859+W
MvZMRpRe1T7v2HxxkRjoBiFjnWy4oKJ6Nxe5UZNjqOzjKhQckK8f20KAQe5P9fjQ
JbeRn0Hwl9BJrFxfQ5KfQ1ow0bJRR/3G5ckqUU8ibrrYeZZM369NQoJ9cMitNon5
KXKL5jnIch5+XaKcC+haofWsBzgefVYSljrysIKvREc5eSsg6KaZTRuJLKz6+/RM
N7gFTSd4yymGfjRiqDR4YbTH65DMHcR8BBM0mgroHLhhrApemt9H/cxdzP+II/ty
N1N79jUUdSjowsNxSN2LJ4JlcDh0R8QMLaMwRIeK6zdi0TDFZD3HjOjq5DLcg30G
mkfTLOoWIhMt1LyillAJ
=WGNY
-----END PGP SIGNATURE-----

--SduJM6ALE2xb4qIQyBnyMJ5byptvH4Enk--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e80e9b2a-4165-feba-a689-e340a1062268>