Date: Mon, 17 Oct 2016 18:28:44 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files Message-ID: <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> In-Reply-To: <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st> References: <201610171515.u9HFF8pG092481@repo.freebsd.org> <1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org> <d8557129-7ede-8ba7-7b8e-8745563930a2@marino.st> <b09dc39e-1656-5f35-cf72-bb4469d350b6@FreeBSD.org> <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--EB2eRjaASc2wr9DIsUEVFGAbMeR2239gK
Content-Type: multipart/mixed; boundary="vrFUkvUNALwWwgXTeJ5Unsi1tU2WvgTJW";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: marino@freebsd.org, ports-committers@freebsd.org,
svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org>
Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk
spice-gtk/files
References: <201610171515.u9HFF8pG092481@repo.freebsd.org>
<1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org>
<d8557129-7ede-8ba7-7b8e-8745563930a2@marino.st>
<b09dc39e-1656-5f35-cf72-bb4469d350b6@FreeBSD.org>
<53c293a4-cc69-53dc-5311-54393b2f9249@marino.st>
In-Reply-To: <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st>
--vrFUkvUNALwWwgXTeJ5Unsi1tU2WvgTJW
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Le 17/10/2016 =C3=A0 18:26, John Marino a =C3=A9crit :
> On 10/17/2016 11:20, Mathieu Arnold wrote:
>> Le 17/10/2016 =C3=A0 17:55, John Marino a =C3=A9crit :
>>> On 10/17/2016 10:52, Mathieu Arnold wrote:
>>>> Le 17/10/2016 =C3=A0 17:15, John Marino a =C3=A9crit :
>>>>> Apparently USES=3Dpathfix and USES=3Dautoreconf can't be used
>>>>> together, so
>>>>> the pkgconfig directory is now passed via MAKE_ARGS
>>>>
>>>> That is mostly not true. What usage makes it so that they do not wor=
k
>>>> together ?
>>>
>>> The results suggest that "${WRKSRC}/configure" was modified, then
>>> autoreconf regenerated ${WRKSRC}/configure afterwards so that the
>>> pkgconfig path change was reverted.
>>>
>>> That's why I had to replace pathfix with MAKE_ARGS.
>>
>> No, USES=3Dpathfix changes the content of PATHFIX_MAKEFILEIN, which by=
>> default, is Makefile.in. It won't change configure unless you set
>> PATHFIX_MAKEFILEIN=3Dconfigure.
>>
>
> Well, I didn't add MAKE_ARGS for fun.
> After adding USES+=3Dautoreconf, the build broke. pathfix was still in=
> place. You can reproduce by adding pathfix back before "python" and
> commenting out the new MAKE_ARGS line I added and check with
> "check-plist" It's easy to confirm.
I never said your fix did not work or was not right, I said USES=3Dpathfi=
x
won't touch configure.
--=20
Mathieu Arnold
--vrFUkvUNALwWwgXTeJ5Unsi1tU2WvgTJW--
--EB2eRjaASc2wr9DIsUEVFGAbMeR2239gK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJYBPw8XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IvqcQAKLM8aMP53cQIagohYMmCKDr
ViEX+tYReiDQgq+lvxOdT0F8DxIicNSkPBu9rNp/d4W1Vyj/NEH6ebwJU5WJmR0i
oSMdRQvBsbUix7hNJfg3XfpJa3Zr6oMfQ8lMafLO9Bc+R4YSqJKkASSVRypcKM+i
s8UeLrVnHfYFcsuQfKFfNppafPGHnB21IBhgVtNh5V7z07WD+H09ITxtj/5TMsYq
ZEK2by5B0Lw3E5vWmvIcoYLJcUQcSEKQAuoSr0zcWSlC50iB5MYc0We/I+jEzcbm
LCMcDlJVhiXgkph3DqCvH211OWYpr9CHvgkgtDb3JxtjClFXBHjL6yf07qt4c8vY
TvV70onOVEsVt6e7bIgcKgMHiicQPI4pLhQx+b+TGQquirDTu6NM9PlqOPvFWymK
unS/137KdhYWIvVkPouBRDF5h8GEVh5+xPDTuvSuAPC/PA2pUsHLDDJ1OWyrrtSb
7M8ceozKOnxyryc2EhGm4Q/C4i/wWHnQkgw3HP2hdrgXssjNF865vtu88f/dhWfv
+l7w4PJsZF/nhy9uR06XB+MSo05kHwlh7Jd5aLEdbymMcuwSWEEYnE1oyvUQ3Cs6
Qh/v9o//CayhLCzUOfuT6uzTJelM4iWwfwGewaHt6KW0N6iHbKiodVa918bEBuJg
O5SrahnWHMzAD+app9Up
=3xVH
-----END PGP SIGNATURE-----
--EB2eRjaASc2wr9DIsUEVFGAbMeR2239gK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?704f4b45-1b73-4bcf-9ca2-cf25eaf605b7>