From owner-freebsd-hackers@freebsd.org Fri Apr 3 02:42:05 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B4582270FBA for ; Fri, 3 Apr 2020 02:42:05 +0000 (UTC) (envelope-from gonzo@bluezbox.com) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48tkjD2DRRz3QVn for ; Fri, 3 Apr 2020 02:41:50 +0000 (UTC) (envelope-from gonzo@bluezbox.com) Received: from localhost ([127.0.0.1] helo=id.bluezbox.com) by id.bluezbox.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92 (FreeBSD)) (envelope-from ) id 1jKCH7-000Dqj-Um; Thu, 02 Apr 2020 19:41:42 -0700 Received: (from gonzo@localhost) by id.bluezbox.com (8.15.2/8.15.2/Submit) id 0332fexV053240; Thu, 2 Apr 2020 19:41:40 -0700 (PDT) (envelope-from gonzo@bluezbox.com) X-Authentication-Warning: id.bluezbox.com: gonzo set sender to gonzo@bluezbox.com using -f Date: Thu, 2 Apr 2020 19:41:40 -0700 From: Oleksandr Tymoshenko To: Greg Balfour Cc: freebsd-hackers@freebsd.org Subject: Re: Patch for calendar(1) Message-ID: <20200403024140.GA53180@bluezbox.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD/11.2-RELEASE-p10 (amd64) User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: Greg Balfour (greg.bal4@gmail.com) wrote: > Can a committer look at the patch that's attached to this > bug report and possibly get it committed? > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=20 [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Rspamd-Queue-Id: 48tkjD2DRRz3QVn X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gonzo@bluezbox.com designates 45.55.20.155 as permitted sender) smtp.mailfrom=gonzo@bluezbox.com X-Spamd-Result: default: False [-4.69 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; HAS_XAW(0.00)[]; DMARC_NA(0.00)[bluezbox.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-2.39)[ip: (-8.87), ipnet: 45.55.0.0/19(-4.36), asn: 14061(1.33), country: US(-0.05)]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:14061, ipnet:45.55.0.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 02:42:05 -0000 Greg Balfour (greg.bal4@gmail.com) wrote: > Can a committer look at the patch that's attached to this > bug report and possibly get it committed? > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201062 > > I finally got around to debugging an issue I've had for > years with calendar(1) and independently came up with the > same solution as in the above bug report. Didn't notice > someone else had long ago suggested this fix until checking > to see if it applied to other bug reports. The patch will > also resolve the problems reported in > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240427 > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234663 > > And while looking at calendar(1) bug reports... > > Looks like this was committed but is still open. > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=162211 > > This one can be closed OBE since the file it patches was > removed in 10.2-RELEASE. > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=186294 > > To address > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=173389 > the line > 11/05* Election Day in USA (1st Tuesday after 1st Monday for even years) > should be removed from /usr/share/calendar/calendar.usholiday > The 1st Tuesday after 1st Monday for even years isn't always > the 5th. Thanks for making the list. I committed fixes and closed duplicate/OBE PRs. -- gonzo