From owner-freebsd-current@FreeBSD.ORG Mon Dec 31 05:25:34 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 109CDFDB for ; Mon, 31 Dec 2012 05:25:34 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-gg0-f175.google.com (mail-gg0-f175.google.com [209.85.161.175]) by mx1.freebsd.org (Postfix) with ESMTP id B49E68FC0A for ; Mon, 31 Dec 2012 05:25:32 +0000 (UTC) Received: by mail-gg0-f175.google.com with SMTP id y1so1944919ggc.20 for ; Sun, 30 Dec 2012 21:25:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=OiJKmgKBKLpgO5FlpDMiSdvA2liUNIRnjMqMfF8d4Ek=; b=bMMS3oYiJkT5YO4xxAcV91cbilQTtQQOT7SVIjLnmAZ7wv5jwjH0xLHQq1Qja3Zi/T U5dFDgMXZRFQVmiX3mCcTo+ygDvcBtwI/icCssSBDM1WWNFaKVfEtlFuFAypE6lDUpyx pT+FgZbimpemWfOlJ0P12dr0B/GSV5ep1kL1gcdF7W6m9bHHBsTi7YLbbkkI1FSpV7ko 9uSq1ewIOVXrzEgxQBALfyluZPLyzwuNAgFrd97GHXtIOPu8lcyGcTsuoKPMglgn0hGg ZWnWLeG9q9YwwM9GWVGNFEOul8kSj6De5eHqWw5nkzdteBmQ0657eBdCy/dnGaiZptnM FHEQ== Received: by 10.236.154.165 with SMTP id h25mr36924331yhk.38.1356931150979; Sun, 30 Dec 2012 21:19:10 -0800 (PST) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.147.119.38 with HTTP; Sun, 30 Dec 2012 21:18:50 -0800 (PST) In-Reply-To: References: <201212301628.qBUGS6tE037193@svn.freebsd.org> From: Juli Mallett Date: Sun, 30 Dec 2012 21:18:50 -0800 X-Google-Sender-Auth: FCOkDL9foF8aXTLlXB-Xy2s3WP0 Message-ID: Subject: Re: svn commit: r244865 - in head: . lib lib/libdisk share/mk To: Adrian Chadd Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmjsuJU4xJrKuRm2EQD1hejcxep+EPt5AmS2Hwk32/kTUcTDXolqYZ4wQvuEPXGHDmBi5S+ Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, freebsd-current , src-committers@freebsd.org, Nathan Whitehorn X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2012 05:25:34 -0000 On Sun, Dec 30, 2012 at 6:54 PM, Adrian Chadd wrote: > .. not that I mind old things being retired, but we really should > announce things like this. > > Also - you disconnected libftpio too; is that intentional? I would assume so, given that this only removed the static library name, which nothing else could be using still, seeing as how the library was disconnected and removed in r225952. > Just because libdisk/libftpio isn't used by anything in the base -HEAD > doesn't mean that: > > * it's not used by third party programs in ports; > * it's not used by any external, non open source utilities that people > have read. > > So I'd suggest creating a port for them both and begin the process of > deprecating the kernel side interfaces that are unique to this API. Pretty sure the addition of and widespread use of GEOM things initiated the deprecation of the really lousy and properly-disliked kernel interfaces involved. > On 30 December 2012 08:28, Nathan Whitehorn wrote: >> Author: nwhitehorn >> Date: Sun Dec 30 16:28:06 2012 >> New Revision: 244865 >> URL: http://svnweb.freebsd.org/changeset/base/244865 >> >> Log: >> With the old sade removed, libdisk is no longer used by anything in HEAD >> and uses a number of problematic pre-gpart interfaces. Since it has been >> entirely obsoleted by interfaces in geom, remove it. >> >> Deleted: >> head/lib/libdisk/ >> Modified: >> head/ObsoleteFiles.inc >> head/lib/Makefile >> head/share/mk/bsd.libnames.mk >> >> Modified: head/ObsoleteFiles.inc >> ============================================================================== >> --- head/ObsoleteFiles.inc Sun Dec 30 15:38:06 2012 (r244864) >> +++ head/ObsoleteFiles.inc Sun Dec 30 16:28:06 2012 (r244865) >> @@ -38,6 +38,9 @@ >> # xargs -n1 | sort | uniq -d; >> # done >> >> +# 20121230: libdisk removed >> +OLD_FILES+=usr/share/man/man3/libdisk.3.gz usr/include/libdisk.h >> +OLD_FILES+=usr/lib/libdisk.a usr/lib32/libdisk.a >> # 20121230: remove wrongly created directories for auditdistd >> OLD_DIRS+=var/dist >> OLD_DIRS+=var/remote >> >> Modified: head/lib/Makefile >> ============================================================================== >> --- head/lib/Makefile Sun Dec 30 15:38:06 2012 (r244864) >> +++ head/lib/Makefile Sun Dec 30 16:28:06 2012 (r244865) >> @@ -69,7 +69,6 @@ SUBDIR= ${SUBDIR_ORDERED} \ >> libcompat \ >> libdevinfo \ >> libdevstat \ >> - libdisk \ >> libdwarf \ >> libedit \ >> ${_libefi} \ >> >> Modified: head/share/mk/bsd.libnames.mk >> ============================================================================== >> --- head/share/mk/bsd.libnames.mk Sun Dec 30 15:38:06 2012 (r244864) >> +++ head/share/mk/bsd.libnames.mk Sun Dec 30 16:28:06 2012 (r244865) >> @@ -45,7 +45,6 @@ LIBCURSES?= ${DESTDIR}${LIBDIR}/libcurse >> LIBDEVINFO?= ${DESTDIR}${LIBDIR}/libdevinfo.a >> LIBDEVSTAT?= ${DESTDIR}${LIBDIR}/libdevstat.a >> LIBDIALOG?= ${DESTDIR}${LIBDIR}/libdialog.a >> -LIBDISK?= ${DESTDIR}${LIBDIR}/libdisk.a >> LIBDNS?= ${DESTDIR}${LIBDIR}/libdns.a >> LIBDTRACE?= ${DESTDIR}${LIBDIR}/libdtrace.a >> LIBDWARF?= ${DESTDIR}${LIBDIR}/libdwarf.a >> @@ -54,7 +53,6 @@ LIBELF?= ${DESTDIR}${LIBDIR}/libelf.a >> LIBFETCH?= ${DESTDIR}${LIBDIR}/libfetch.a >> LIBFL?= "don't use LIBFL, use LIBL" >> LIBFORM?= ${DESTDIR}${LIBDIR}/libform.a >> -LIBFTPIO?= ${DESTDIR}${LIBDIR}/libftpio.a >> LIBG2C?= ${DESTDIR}${LIBDIR}/libg2c.a >> LIBGCC?= ${DESTDIR}${LIBDIR}/libgcc.a >> LIBGCC_PIC?= ${DESTDIR}${LIBDIR}/libgcc_pic.a