From owner-freebsd-current@freebsd.org Wed Jun 1 18:49:59 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2B93B61591 for ; Wed, 1 Jun 2016 18:49:59 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id B1A911D7B for ; Wed, 1 Jun 2016 18:49:59 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mailman.ysv.freebsd.org (Postfix) id AD294B61590; Wed, 1 Jun 2016 18:49:59 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACC85B6158F for ; Wed, 1 Jun 2016 18:49:59 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 461F91D7A for ; Wed, 1 Jun 2016 18:49:59 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f52.google.com with SMTP id k98so19068823lfi.1 for ; Wed, 01 Jun 2016 11:49:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=Hjqf4uFfO6cRx+KsdcAb4v9UIXXY3LNYPbM/EZMjWdc=; b=ULx9DKZdEcX1YQG6OgkuUE+37uGec+C8wxPYOejTOsC9p4tUljx2GfMuyAIoB1RqWj N6ucejiB1sYA6IrTZHVU4o16vob61I9yAWLN3xxW2OX+NjcSX0k7yCXKTbxWjE3063/b 7axjU9hv1ja8XH7RfjzaM67Zi77i8Bq/E0wPkOiRZPUDQQbRTj2X7Ez0UL6liXwvWCyJ rqxibsm4rBQZtypL/gBxi/hFCyeGkoq4TDzfsKYQzJ7rLhmmk4bX2sgL7DgO3mFsNeD7 PpoGJGI0L9Qabj54NnkAvE2BmV3j9tay5rss75nmk0SUHa6y9DNet7DWFnxOmiyk8g7z +Mzw== X-Gm-Message-State: ALyK8tKJUPu0W5sV7m/dVdJTjCOJkdC2MWF5GuxuK+oU+FeoJYiUGm/amw2IrtxZMTyjVw== X-Received: by 10.25.216.223 with SMTP id r92mr2589691lfi.122.1464806990836; Wed, 01 Jun 2016 11:49:50 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id j81sm3173431lfg.1.2016.06.01.11.49.49 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 01 Jun 2016 11:49:50 -0700 (PDT) Subject: Re: 'make depend' or 'make' bug on recent --current To: Bryan Drewery , current@freebsd.org References: <092f5e98-dae8-dbc9-2a6e-7068b972278f@freebsd.org> <311f3a82-b702-d375-170f-82ae39236ab0@FreeBSD.org> From: Andrey Chernov Message-ID: Date: Wed, 1 Jun 2016 21:49:49 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <311f3a82-b702-d375-170f-82ae39236ab0@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8jNqIFH4PwimuQaBNpLe7tjQdW5s70omS" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 18:49:59 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8jNqIFH4PwimuQaBNpLe7tjQdW5s70omS Content-Type: multipart/mixed; boundary="nUMjutJv2e59cDmvHJ5GRn46pgaFPrVw6" From: Andrey Chernov To: Bryan Drewery , current@freebsd.org Message-ID: Subject: Re: 'make depend' or 'make' bug on recent --current References: <092f5e98-dae8-dbc9-2a6e-7068b972278f@freebsd.org> <311f3a82-b702-d375-170f-82ae39236ab0@FreeBSD.org> In-Reply-To: <311f3a82-b702-d375-170f-82ae39236ab0@FreeBSD.org> --nUMjutJv2e59cDmvHJ5GRn46pgaFPrVw6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01.06.2016 21:18, Bryan Drewery wrote: > On 6/1/2016 6:11 AM, Andrey Chernov wrote: >> Steps to reproduce: >> >> cd /usr/src/lib/libc/stdlib >> touch *div*.c >> cd .. >> make depend >> make >> >> And see how imaxdiv.o only is recompiled. >> No div.o ldiv.o lldiv.o are recompiled. >=20 > My dev system is busy at the moment. I'll test it and get back to you. I need to add that I do 'make cleandepend/cleandir/cleanobj' + 'make obj' again and full rebuild with no old files, but the bug repeated again= =2E >> P.S. new make depend is simple disgusting. It tends to recompile >> everything in the system if some minor header file is touched, but >=20 > If the header is used by all source files then that is expected. >=20 > However if you do not have a .depend.obj.o file then it is quite > aggressive with building. If you touch any header it will rebuild > everything. But you shouldn't get into that situation unless you rm -f= > .depend* first. >=20 >> completely forget to recompile source code changes. I suggest to back >> out all AI in that area. >> 'make depend' is not time-consuming task and good old way never made >> mistakes. >=20 > The graph in the original commit for WITH_FAST_DEPEND disagrees. > https://svnweb.freebsd.org/base?view=3Drevision&revision=3D290433 >=20 > We run the preprocessor once now, not twice. It sounds good, just implemented bad. You measure some spherical chicken in vacuum, not what really happens. In the old times I almost never have clang libs rebuild (few files from there max when FreeBSD_version is increased), but now I got them fully rebuilt with any header change. That is the biggest slowdown and not what you try to measure. Don't ever use 'make world'. Try to rebuild the system incrementally and you'll see. --nUMjutJv2e59cDmvHJ5GRn46pgaFPrVw6-- --8jNqIFH4PwimuQaBNpLe7tjQdW5s70omS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJXTy5NAAoJEKUckv0MjfbKNOcH/0kLuYNN+dkXiURb9E9fRZ+9 qfeyHOBIUxggqd20f01wpKZZtbjethI5FJgYpcus6gSMbz1kf1qmCi2Rd7byGaql 540am8ktwZ+lx/FlZ1uE88BbquB5dbyAs3ASFDCQavLOk+wgku4bAc47IhUBlrbm nbU8OHZ1gPXUO3Ctic1tibKPbBj9R33aNRbXpe3Jg9G7qaQNBQ/ZNi5KDRSgeS6C x2u5Ummu2UlR47ubeSHrDpTkdmeuoKGbjJIczzjr+EtRXsN1Ti9KPoj/3Fyzo4cx swNKS14BRRTubQqqomrXXBBhK8ivt7uog4/jonWGKGewPMqqtixtVqjdtlIB/6o= =gWVT -----END PGP SIGNATURE----- --8jNqIFH4PwimuQaBNpLe7tjQdW5s70omS--