Date: Mon, 8 Sep 2014 01:42:59 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, koobs@FreeBSD.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, clutton@zoho.com, Carlo Strub <cs@FreeBSD.org> Subject: Re: svn commit: r367404 - in head/security: . webshag webshag/files Message-ID: <20140907234259.GC6096@ivaldir.etoilebsd.net> In-Reply-To: <540AD92E.5030602@marino.st> References: <201409060746.s867kwJ4038485@svn.freebsd.org> <540AD4A8.4050705@FreeBSD.org> <540AD92E.5030602@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
--KDt/GgjP6HVcx58l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Sep 06, 2014 at 11:51:42AM +0200, John Marino wrote:
> On 9/6/2014 11:32, Kubilay Kocak wrote:
> > On 6/09/2014 5:46 PM, Carlo Strub wrote:
> >> +LICENSE=3D GPLv3
> >=20
> > LICENSE_FILE
>=20
> I know mat's position, but this decree was definitely controversial.
> Many people don't agree that LICENSE_FILE is needed when the provided
> license is identical to the one offered in ports Templates directory.
> And since the licensing framework is still an unsupported and mostly
> undocumented red-headed stepchild of ports, I don't think I agree with
> saying this was an error.
>=20
> >> +bin/webshag_cli
> >> +%%WXGTK%%bin/webshag_gui
> >> +%%ETCDIR%%.conf
> >=20
> > Does this need a filename?
>=20
>=20
> This is probably a wonderful side effect of make makeplist which
> aggressively creates SUB replacements, often incorrectly.
> This was probably /etc/${PORTNAME}.conf and it got transformed and
> submitter didn't check closely enough.
>=20
> I agree, DO NOT TRUST MAKEPLIST FURTHER THAN YOU CAN THROW IT!
>=20
This is why the first line of make makeplist if wrong so one has to review!
regards,
Bapt
--KDt/GgjP6HVcx58l
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlQM7YMACgkQ8kTtMUmk6ExK0ACfY3EJK+oIZuCC75Ch6kN4OxVq
V48AoLFJ0DAZR/HkxSjDGylLQzNEei3w
=smGv
-----END PGP SIGNATURE-----
--KDt/GgjP6HVcx58l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140907234259.GC6096>