From owner-svn-ports-head@freebsd.org Sun Jun 28 21:28:04 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D73C098F0B8; Sun, 28 Jun 2015 21:28:04 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-x22e.google.com (mail-wg0-x22e.google.com [IPv6:2a00:1450:400c:c00::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 669E61141; Sun, 28 Jun 2015 21:28:04 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wguu7 with SMTP id u7so126343303wgu.3; Sun, 28 Jun 2015 14:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=xo6AZivRQ6rb9bV1EYn03+ivWTlurx0roDhSy/lFtcY=; b=YSPNmTfoTLWLcy5oH4yc95YelsE0dIPNHKhtdGxjYS4wmt4d+//kRv9Ez4I24Uzv6e sDhSJNGb8FvQxCpySMeDm6w8nByi5wuN1Hsm1Kd5IOD0uQKu1nSeV/HMRm42KHqtriRG czmXVRpTrltRhg7rJCE0jUew6qEFLpXulseGoCEXZ+t3hBybVcHC11IUySnLSCMq1ZaN 1VKXR5BZcCS5HdNACHjGliptuEuf+6U+/A+XXMW+fLenoi/PWDehyWN87wbLlrCcyxXL a58ZlBcuFKGZKg18M6uGWOkBET4Q8ECZyfdFbE4DFDTnLGbp/bct9lr3fvrwteTdKhed w/5A== X-Received: by 10.180.20.12 with SMTP id j12mr16377748wie.4.1435526882493; Sun, 28 Jun 2015 14:28:02 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id b5sm9027857wic.3.2015.06.28.14.28.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jun 2015 14:28:01 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 28 Jun 2015 23:27:59 +0200 From: Baptiste Daroussin To: olli hauer Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r390865 - in head/Mk: . Scripts Message-ID: <20150628212759.GJ68142@ivaldir.etoilebsd.net> References: <201506281850.t5SIocPn077890@svn.freebsd.org> <55906609.2080905@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QxN5xOWGsmh5a4wb" Content-Disposition: inline In-Reply-To: <55906609.2080905@gmx.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2015 21:28:04 -0000 --QxN5xOWGsmh5a4wb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 28, 2015 at 11:24:25PM +0200, olli hauer wrote: > On 2015-06-28 20:50, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sun Jun 28 18:50:37 2015 > > New Revision: 390865 > > URL: https://svnweb.freebsd.org/changeset/ports/390865 > >=20 > > Added: > > head/Mk/Scripts/do-depends.sh (contents, props changed) > > Modified: > > head/Mk/bsd.port.mk > >=20 > > Added: head/Mk/Scripts/do-depends.sh > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/Mk/Scripts/do-depends.sh Sun Jun 28 18:50:37 2015 (r390865) >=20 > ... >=20 > > +find_file_path() > > +{ > > + if which -s $1 ; then > > + echo "=3D=3D=3D> ${dp_PKGNAME} depends on executable: $1 - found" > > + return 0 > > + fi >=20 > Shouldn't this be 's|which|${WHICH}|' or 's|which|/usr/bin/which|' as in = the old version? >=20 > E.g which in csh don't have parameter [a|s] well actually the script is always and only used via /bin/sh so we can use = the sh(1) builtin version of which :) Best regards, Bapt --QxN5xOWGsmh5a4wb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlWQZt8ACgkQ8kTtMUmk6Ex/6gCbBaRvJVKj4thhhOD15EKb7s0w jngAoJFg7fjM+f5g/9b1+2MgSBTDGeVs =lbdl -----END PGP SIGNATURE----- --QxN5xOWGsmh5a4wb--