Date: Mon, 19 Oct 1998 20:40:01 -0700 (PDT) From: Greg Shaffer <gshaffer@leaky.com> To: freebsd-ports@FreeBSD.ORG Subject: Re: ports/8354: fwtk port does not compile Message-ID: <199810200340.UAA20908@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/8354; it has been noted by GNATS. From: Greg Shaffer <gshaffer@leaky.com> To: Bill Fumerola <billf@chc-chimes.com> Cc: freebsd-gnats-submit@FreeBSD.ORG, gshaffer@leaky.com Subject: Re: ports/8354: fwtk port does not compile Date: Mon, 19 Oct 1998 20:34:50 -0700 At 03:16 PM 10/18/98 -0400, Bill wrote: >On Sat, 17 Oct 1998 gshaffer@leaky.com wrote: > >> *** 11,17 **** >> * added sleep on bind failure. >> */ >> >> ! #include <signal.h> >> #include <syslog.h> >> #include <errno.h> >> #include <sys/types.h> >> --- 11,17 ---- >> * added sleep on bind failure. >> */ >> >> ! #include <sys/signal.h> >> #include <syslog.h> >> #include <errno.h> >> #include <sys/types.h> > >I'm not sure how in depth your C knowledge is, but, you should probaly >make sure no functions from signal.h are being used before you just delete >them. > I'll be the first to admit that my knowledge of C is not fantastic, but if you would have looked at the files involved (e.g. signal.h and sys/signal.h) you would have noticed that signal.h includes sys/signal.h. I did not delete out the line. According to my C language reference "!" is not a legal comment token. Its a by product of the context diff (diff -c) I submitted with the PR. >Also, a more appropriate patch could be to merely comment out those lines >as opposed to deleteing them completly. > Commenting lines in an include file like this that is used by the system is very dangerous. Since other files depend on this include file and fwtk was the only one that had problem, the problem probably lies with the fwtk code, not sys/signal.h! Greg >- bill fumerola [root/billf]@chc-chimes.com - computer horizons corp - >- ph:(800)252.2421 x128 / bfumerol@computerhorizons.com - BF1560 - > > "Logic, like whiskey, loses its beneficial effect > when taken in too large quantities" -Lord Dunsany > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199810200340.UAA20908>