Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Sep 2004 08:02:38 -0600 (MDT)
From:      "M. Warner Losh" <imp@bsdimp.com>
To:        phk@phk.freebsd.dk
Cc:        jb@cimlogic.com.au
Subject:   Re: cvs commit: src/sys/dev/fdc fdc_isa.c 
Message-ID:  <20040929.080238.02184004.imp@bsdimp.com>
In-Reply-To: <19681.1096444779@critter.freebsd.dk>
References:  <20040929074552.GA909@freebsd3.cimlogic.com.au> <19681.1096444779@critter.freebsd.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <19681.1096444779@critter.freebsd.dk>
            "Poul-Henning Kamp" <phk@phk.freebsd.dk> writes:
: (BTW, Warner:  Shouldn't this:
: 
: 	static u_int8_t
: 	fdsts_rd(struct fdc_data *fdc)
: 	{
: 		
: 		return bus_space_read_1(fdc->portt, fdc->porth, FDSTS+fdc->port_off);
: 	}
: 
: be changed to:
: 
: 	static u_int8_t
: 	fdsts_rd(struct fdc_data *fdc)
: 	{
: 		
: 		return bus_space_read_1(fdc->stst, fdc->stsh, FDSTS+fdc->sts_off);
: 	}
: 
: )

Yes.  I think it should.  I think that it won't matter at all in
actual fact, but is pedantically incorrect.

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040929.080238.02184004.imp>