Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Apr 2010 04:23:00 GMT
From:      Robert Jenssen <robertjenssen@ozemail.com.au>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/145798: tkdiff Makefile does not use default tcl/tk version by USE_TK=yes
Message-ID:  <201004180423.o3I4N0Y7033125@www.freebsd.org>
Resent-Message-ID: <201004180430.o3I4U2AE081876@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         145798
>Category:       ports
>Synopsis:       tkdiff Makefile does not use default tcl/tk version by USE_TK=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 18 04:30:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Robert Jenssen
>Release:        8-STABLE
>Organization:
>Environment:
FreeBSD kraken 8.0-STABLE FreeBSD 8.0-STABLE #0: Tue Apr 13 21:49:45 EST 2010     root@kraken:/usr/obj/usr/src/sys/KRAKEN  i386
>Description:
The devel/ports Makefile is hardwired to tcl/tk version 8.4 rather than using the default tcl/tk version defined in bsd.tcl.mk. 
>How-To-Repeat:
cd /usr/ports/textproc/tkdiff && make
>Fix:
Apply attached patch:
--- textproc/tkdiff/Makefile.old	2010-04-18 12:53:30.000000000 +1000
+++ textproc/tkdiff/Makefile	2010-04-18 12:54:01.000000000 +1000
@@ -14,14 +14,14 @@
 MAINTAINER=	kevlo@FreeBSD.org
 COMMENT=	A Tk frontend for diff(1)
 
-RUN_DEPENDS=	wish8.4:${PORTSDIR}/x11-toolkits/tk84
+USE_TK=		yes
 
 NO_BUILD=	yes
 
 PLIST_FILES=	bin/tkdiff
 
 post-patch:
-	@${REINPLACE_CMD} -e 's|wish|wish8.4|' ${WRKSRC}/tkdiff
+	@${REINPLACE_CMD} -e 's|wish|${WISH}|' ${WRKSRC}/tkdiff
 
 do-install:
 	@${INSTALL_SCRIPT} ${WRKSRC}/tkdiff ${PREFIX}/bin


Patch attached with submission follows:

--- textproc/tkdiff/Makefile.old	2010-04-18 12:53:30.000000000 +1000
+++ textproc/tkdiff/Makefile	2010-04-18 12:54:01.000000000 +1000
@@ -14,14 +14,14 @@
 MAINTAINER=	kevlo@FreeBSD.org
 COMMENT=	A Tk frontend for diff(1)
 
-RUN_DEPENDS=	wish8.4:${PORTSDIR}/x11-toolkits/tk84
+USE_TK=		yes
 
 NO_BUILD=	yes
 
 PLIST_FILES=	bin/tkdiff
 
 post-patch:
-	@${REINPLACE_CMD} -e 's|wish|wish8.4|' ${WRKSRC}/tkdiff
+	@${REINPLACE_CMD} -e 's|wish|${WISH}|' ${WRKSRC}/tkdiff
 
 do-install:
 	@${INSTALL_SCRIPT} ${WRKSRC}/tkdiff ${PREFIX}/bin


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004180423.o3I4N0Y7033125>