Date: Mon, 27 Mar 2017 01:16:59 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Diane Bruce <db@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r436980 - in head/comms/fldigi: . files Message-ID: <efxj-d3x0-wny@FreeBSD.org> In-Reply-To: <201703261859.v2QIxxF5027036@repo.freebsd.org> (Diane Bruce's message of "Sun, 26 Mar 2017 18:59:59 %2B0000 (UTC)") References: <201703261859.v2QIxxF5027036@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Diane Bruce <db@FreeBSD.org> writes: > +- if ((ptr2) > 0 && (unsigned)(ptr2 - ptr) <= p) > ++ if ((unsigned long)(ptr2) > 0 && (unsigned long)(ptr2 - ptr) <= p) Why not compare pointer against NULL? Some architectures may have pointer type larger than "unsigned long". Also see the patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216199 which fixes some Clang warnings.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?efxj-d3x0-wny>