Date: Mon, 9 Apr 2012 18:45:11 +0300 From: Jaakko Heinonen <jh@FreeBSD.org> To: "Justin T. Gibbs" <gibbs@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233961 - head/sys/x86/x86 Message-ID: <20120409154510.GA2253@a91-153-116-96.elisa-laajakaista.fi> In-Reply-To: <201204062119.q36LJTKR026564@svn.freebsd.org> References: <201204062119.q36LJTKR026564@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On 2012-04-06, Justin T. Gibbs wrote:
> Fix interrupt load balancing regression, introduced in revision
> 222813, that left all un-pinned interrupts assigned to CPU 0.
>
> sys/x86/x86/intr_machdep.c:
> In intr_shuffle_irqs(), remove CPU_SETOF() call that initialized
> the "intr_cpus" cpuset to only contain CPU0.
>
> This initialization is too late and nullifies the results of calls
> the intr_add_cpu() that occur much earlier in the boot process.
> Since "intr_cpus" is statically initialized to the empty set, and
> all processors, including the BSP, already add themselves to
> "intr_cpus" no special initialization for the BSP is necessary.
My Pentium 4 system hangs on boot after this commit. These are the last
lines from a verbose boot:
SMP: AP CPU #1 Launched!
cpu1 AP:
ID: 0x01000000 VER: 0x00050014 LDR: 0x00000000 DFR: 0xffffffff
lint0: 0x00010700 lint1: 0x00000400 TPR: 0x00000000 SVR: 0x000001ff
timer: 0x000100ef therm: 0x00010000 err: 0x000000f0 pmc: 0x00010400
The system boots with r233960.
Some information:
CPU: Intel(R) Pentium(R) 4 CPU 2.60GHz (2605.96-MHz 686-class CPU)
Origin = "GenuineIntel" Id = 0xf29 Family = f Model = 2 Stepping =
9
Features=0xbfebfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE>
Features2=0x4400<CNXT-ID,xTPR>
real memory = 2147483648 (2048 MB)
avail memory = 2085228544 (1988 MB)
Event timer "LAPIC" quality 400
ACPI APIC Table: <A M I OEMAPIC >
FreeBSD/SMP: Multiprocessor System Detected: 2 CPUs
FreeBSD/SMP: 1 package(s) x 1 core(s) x 2 HTT threads
cpu0 (BSP): APIC ID: 0
cpu1 (AP/HT): APIC ID: 1
--
Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120409154510.GA2253>