From owner-freebsd-ports Sun Sep 6 10:49:01 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA07867 for freebsd-ports-outgoing; Sun, 6 Sep 1998 10:49:01 -0700 (PDT) (envelope-from owner-freebsd-ports@FreeBSD.ORG) Received: from localhost.my.domain (ppp7260.on.bellglobal.com [206.172.249.228]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA07859; Sun, 6 Sep 1998 10:48:52 -0700 (PDT) (envelope-from hoek@FreeBSD.ORG) Received: from localhost (tim@localhost) by localhost.my.domain (8.8.8/8.8.8) with SMTP id NAA00427; Sun, 6 Sep 1998 13:48:51 -0400 (EDT) (envelope-from ac199@hwcn.org) X-Authentication-Warning: localhost.my.domain: tim owned process doing -bs Date: Sun, 6 Sep 1998 13:48:50 -0400 (EDT) From: Tim Vanderhoek X-Sender: tim@localhost Reply-To: ac199@hwcn.org To: Jun-ichiro Itoh cc: ports@FreeBSD.ORG Subject: Re: cvs commit: ports/misc/magicpoint Makefile ports/misc/magicpoint/files md5 ports/misc/magicpoint/pkg PLIST ports/japanese/magicpoint Makefile In-Reply-To: <199809061348.GAA23926@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org [-committers -=> -ports] On Sun, 6 Sep 1998, Jun-ichiro Itoh wrote: > NOTE: there's one twist in post-install (manpage gzipping). > could anybody improve this? That's not just a little twist... :-) $ make install "Makefile", line 48: Malformed conditional (${MANCOMPRESSED} == yes) "Makefile", line 48: Need an operator "Makefile", line 51: if-less endif "Makefile", line 51: Need an operator USE_IMAKE implies MANCOMPRESSED=yes. Compress the manpage unconditionally. If the port was broken into two ("xmindpath" and "magicpoint"), this wouldn't be necessary. That would also save you constantly piggy-backing the build of xmindpath on post-*:. I don't know the port well-enough to make a suggestion, but if I did know it well enough... ;-) The port doesn't appear to respect PREFIX, either. Not so bad in itself, but I suspect rather wierd things will start happening if someone, as root, tries to install it with a non-standard PREFIX... :-( [Incidentally, those '+=' and '?=' in magicpoint/Makefile wouldn't be necessary if ja-magicpoint/Makefile .included it earlier]. -- This .sig is not innovative, witty, or profund. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message