Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Jun 2000 13:15:23 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
To:        Doug@gorean.org (Doug Barton)
Cc:        mjacob@feral.com (Matthew Jacob), imp@village.org (Warner Losh), cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/isp isp.c
Message-ID:  <200006272015.NAA93048@gndrsh.dnsmgr.net>
In-Reply-To: <Pine.BSF.4.21.0006271307560.26405-100000@dt052n3e.san.rr.com> from Doug Barton at "Jun 27, 2000 01:10:27 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
> On Tue, 27 Jun 2000, Matthew Jacob wrote:
> 
> > 
> > Thanks!
> > 
> > I hope it wasn't *too* big- I wanted to store all the info somewhere.
> 
> 	Heck no. If anything, it would be nice if more people included
> more detail. Someone (I think it was Peter) recommended that commit
> messages should go into detail about _why_ something was done, and touch
> lightly on what was done since that info is available in the diff. I'm all
> in favor of anything that keeps me from having to go look the diff up,
> personally.

Which means things like ``Brucify'', ``Sheldonize'', and a handfull of
other short one liner messages that tell nothing about what was done or why
it was done should be grounds for hand slapping committers.

A well written commit message is like a good picture, worth a 1000 words :-)


-- 
Rod Grimes - KD7CAX @ CN85sl - (RWG25)               rgrimes@gndrsh.dnsmgr.net


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200006272015.NAA93048>