From owner-cvs-all Fri Oct 29 11:21:38 1999 Delivered-To: cvs-all@freebsd.org Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (Postfix) with ESMTP id A037A15491; Fri, 29 Oct 1999 11:21:24 -0700 (PDT) (envelope-from julian@whistle.com) Received: from home.elischer.org (home.elischer.org [207.76.204.203]) by alpo.whistle.com (8.9.1a/8.9.1) with ESMTP id LAA76086; Fri, 29 Oct 1999 11:21:21 -0700 (PDT) Date: Fri, 29 Oct 1999 11:21:20 -0700 (PDT) From: Julian Elischer X-Sender: julian@home.elischer.org To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/gcore elfcore.c ... In-Reply-To: <199910291809.LAA89728@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk before you do this next commit, maybe it might be worth having it reviewd by someone. This one should have been too. I suggest that you extract out this diff and place it on your page some where to allow people to easily perform a 'post review'! You may be doing good work but it doesn't help if you ignore the rules. The particular hint here is the letters "vm_" Julian On Fri, 29 Oct 1999, Poul-Henning Kamp wrote: > phk 1999/10/29 11:09:37 PDT > > Modified files: > usr.bin/gcore elfcore.c > sys/alpha/alpha busdma_machdep.c fp_emulate.c machdep.c > mem.c pmap.c prom.c prom_disp.s > promcons.c sgmap.c trap.c vm_machdep.c > sys/alpha/include prom.h > sys/alpha/pci apecs.c cia.c lca.c tsunami.c > sys/cam/scsi scsi_da.c > sys/ddb db_watch.c > sys/dev/ata ata-disk.c > sys/dev/vn vn.c > sys/i386/i386 busdma_machdep.c machdep.c mem.c pmap.c > trap.c vm86.c vm_machdep.c > sys/i386/ibcs2 imgact_coff.c > sys/i386/isa wd.c > sys/i386/linux imgact_linux.c linux_misc.c > linux_sysvec.c > sys/i386/svr4 svr4_machdep.c > sys/kern imgact_aout.c imgact_elf.c imgact_gzip.c > init_main.c kern_exec.c kern_resource.c > kern_subr.c link_elf.c subr_blist.c > sys_pipe.c sys_process.c sysv_shm.c > uipc_syscalls.c vfs_bio.c vfs_cluster.c > vfs_subr.c > sys/miscfs/devfs devfs_vnops.c > sys/miscfs/procfs procfs_map.c procfs_mem.c > sys/miscfs/specfs spec_vnops.c > sys/miscfs/union union_vnops.c > sys/nfs nfs_bio.c > sys/ntfs ntfs_vfsops.c ntfs_vnops.c > sys/nwfs nwfs_io.c nwfs_node.c > sys/pc98/i386 machdep.c > sys/pc98/pc98 wd.c > sys/svr4 imgact_svr4.c svr4_misc.c > sys/ufs/ffs ffs_vfsops.c ffs_vnops.c > sys/vm default_pager.c device_pager.c > swap_pager.c vm.h vm_fault.c vm_glue.c > vm_init.c vm_kern.c vm_map.c vm_meter.c > vm_mmap.c vm_object.c vm_page.c > vm_pageout.c vm_pager.c vm_unix.c > vm_zone.c vnode_pager.c > Removed files: > sys/vm vm_inherit.h vm_prot.h > Log: > useracc() the prequel: > > Merge the contents (less some trivial bordering the silly comments) > of and into . This puts > the #defines for the vm_inherit_t and vm_prot_t types next to their > typedefs. > > This paves the road for the commit to follow shortly: change > useracc() to use VM_PROT_{READ|WRITE} rather than B_{READ|WRITE} > as argument. > > Revision Changes Path > 1.5 +1 -2 src/usr.bin/gcore/elfcore.c > 1.7 +1 -2 src/sys/alpha/alpha/busdma_machdep.c > 1.7 +1 -2 src/sys/alpha/alpha/fp_emulate.c > 1.59 +1 -2 src/sys/alpha/alpha/machdep.c > 1.17 +1 -2 src/sys/alpha/alpha/mem.c > 1.32 +1 -2 src/sys/alpha/alpha/pmap.c > 1.9 +2 -1 src/sys/alpha/alpha/prom.c > 1.2 +2 -0 src/sys/alpha/alpha/prom_disp.s > 1.13 +1 -2 src/sys/alpha/alpha/promcons.c > 1.3 +1 -2 src/sys/alpha/alpha/sgmap.c > 1.19 +1 -2 src/sys/alpha/alpha/trap.c > 1.23 +1 -2 src/sys/alpha/alpha/vm_machdep.c > 1.3 +2 -0 src/sys/alpha/include/prom.h > 1.11 +1 -2 src/sys/alpha/pci/apecs.c > 1.24 +1 -2 src/sys/alpha/pci/cia.c > 1.12 +1 -2 src/sys/alpha/pci/lca.c > 1.7 +1 -2 src/sys/alpha/pci/tsunami.c > 1.40 +1 -2 src/sys/cam/scsi/scsi_da.c > 1.20 +1 -2 src/sys/ddb/db_watch.c > 1.33 +1 -2 src/sys/dev/ata/ata-disk.c > 1.101 +1 -2 src/sys/dev/vn/vn.c > 1.16 +1 -2 src/sys/i386/i386/busdma_machdep.c > 1.372 +1 -2 src/sys/i386/i386/machdep.c > 1.75 +1 -2 src/sys/i386/i386/mem.c > 1.249 +1 -2 src/sys/i386/i386/pmap.c > 1.142 +1 -2 src/sys/i386/i386/trap.c > 1.31 +1 -2 src/sys/i386/i386/vm86.c > 1.129 +1 -2 src/sys/i386/i386/vm_machdep.c > 1.38 +1 -2 src/sys/i386/ibcs2/imgact_coff.c > 1.213 +1 -2 src/sys/i386/isa/wd.c > 1.34 +1 -2 src/sys/i386/linux/imgact_linux.c > 1.75 +1 -2 src/sys/i386/linux/linux_misc.c > 1.52 +1 -2 src/sys/i386/linux/linux_sysvec.c > 1.11 +1 -2 src/sys/i386/svr4/svr4_machdep.c > 1.58 +1 -2 src/sys/kern/imgact_aout.c > 1.66 +1 -2 src/sys/kern/imgact_elf.c > 1.40 +1 -2 src/sys/kern/imgact_gzip.c > 1.129 +1 -2 src/sys/kern/init_main.c > 1.102 +1 -2 src/sys/kern/kern_exec.c > 1.51 +1 -2 src/sys/kern/kern_resource.c > 1.31 +1 -2 src/sys/kern/kern_subr.c > 1.21 +1 -2 src/sys/kern/link_elf.c > 1.4 +1 -2 src/sys/kern/subr_blist.c > 1.57 +1 -2 src/sys/kern/sys_pipe.c > 1.50 +1 -2 src/sys/kern/sys_process.c > 1.44 +1 -3 src/sys/kern/sysv_shm.c > 1.62 +1 -2 src/sys/kern/uipc_syscalls.c > 1.233 +1 -2 src/sys/kern/vfs_bio.c > 1.92 +1 -2 src/sys/kern/vfs_cluster.c > 1.232 +1 -2 src/sys/kern/vfs_subr.c > 1.82 +1 -2 src/sys/miscfs/devfs/devfs_vnops.c > 1.24 +1 -2 src/sys/miscfs/procfs/procfs_map.c > 1.39 +1 -2 src/sys/miscfs/procfs/procfs_mem.c > 1.122 +1 -2 src/sys/miscfs/specfs/spec_vnops.c > 1.66 +1 -2 src/sys/miscfs/union/union_vnops.c > 1.80 +1 -2 src/sys/nfs/nfs_bio.c > 1.15 +1 -2 src/sys/ntfs/ntfs_vfsops.c > 1.8 +1 -2 src/sys/ntfs/ntfs_vnops.c > 1.5 +1 -2 src/sys/nwfs/nwfs_io.c > 1.3 +1 -2 src/sys/nwfs/nwfs_node.c > 1.139 +1 -2 src/sys/pc98/i386/machdep.c > 1.96 +1 -2 src/sys/pc98/pc98/wd.c > 1.8 +1 -2 src/sys/svr4/imgact_svr4.c > 1.9 +1 -2 src/sys/svr4/svr4_misc.c > 1.108 +1 -2 src/sys/ufs/ffs/ffs_vfsops.c > 1.61 +1 -2 src/sys/ufs/ffs/ffs_vnops.c > 1.21 +1 -2 src/sys/vm/default_pager.c > 1.45 +1 -2 src/sys/vm/device_pager.c > 1.127 +1 -2 src/sys/vm/swap_pager.c > 1.15 +45 -2 src/sys/vm/vm.h > 1.107 +1 -2 src/sys/vm/vm_fault.c > 1.91 +1 -2 src/sys/vm/vm_glue.c > 1.20 +1 -2 src/sys/vm/vm_init.c > 1.61 +1 -2 src/sys/vm/vm_kern.c > 1.179 +1 -3 src/sys/vm/vm_map.c > 1.34 +1 -2 src/sys/vm/vm_meter.c > 1.104 +1 -3 src/sys/vm/vm_mmap.c > 1.170 +1 -2 src/sys/vm/vm_object.c > 1.144 +1 -2 src/sys/vm/vm_page.c > 1.149 +1 -2 src/sys/vm/vm_pageout.c > 1.54 +1 -2 src/sys/vm/vm_pager.c > 1.23 +1 -2 src/sys/vm/vm_unix.c > 1.29 +1 -2 src/sys/vm/vm_zone.c > 1.116 +1 -2 src/sys/vm/vnode_pager.c > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message