Date: Sun, 26 Mar 2017 20:53:26 -0400 From: Diane Bruce <db@db.net> To: Jan Beich <jbeich@FreeBSD.org> Cc: Diane Bruce <db@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r436980 - in head/comms/fldigi: . files Message-ID: <20170327005326.GA19551@night.db.net> In-Reply-To: <efxj-d3x0-wny@FreeBSD.org> References: <201703261859.v2QIxxF5027036@repo.freebsd.org> <efxj-d3x0-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 27, 2017 at 01:16:59AM +0200, Jan Beich wrote: > Diane Bruce <db@FreeBSD.org> writes: > > > +- if ((ptr2) > 0 && (unsigned)(ptr2 - ptr) <= p) > > ++ if ((unsigned long)(ptr2) > 0 && (unsigned long)(ptr2 - ptr) <= p) > > Why not compare pointer against NULL? Some architectures may have > pointer type larger than "unsigned long". > > Also see the patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216199 > which fixes some Clang warnings. > Because since I know there is a new upcoming release from upstream I was concentrating my efforts on getting your diffs plus some others into the upcoming fldigi 4.0.0 . It would be rather nice to not have all those diffs cluttering up the port now wouldn't it. -- - db@FreeBSD.org db@db.net http://www.db.net/~db
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170327005326.GA19551>