From owner-cvs-all@FreeBSD.ORG  Tue Dec 14 07:27:48 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id B323D1065672; Tue, 14 Dec 2010 07:27:48 +0000 (UTC)
Date: Tue, 14 Dec 2010 07:27:48 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mikhail Teterin <mi@FreeBSD.org>
Message-ID: <20101214072748.GA70334@FreeBSD.org>
References: <201012140611.oBE6B42j028412@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201012140611.oBE6B42j028412@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports GIDs UIDs ports/net Makefile
	ports/net/minidlna Makefile distinfo pkg-descr pkg-plist
	ports/net/minidlna/files BSDmakefile config.h getifaddr.c
	minidlna.sh.in patch-2928850 patch-aa patch-ab patch-inline
	patch-minidlna.c patch-upnphttp ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Dec 2010 07:27:48 -0000

On Tue, Dec 14, 2010 at 06:11:04AM +0000, Mikhail Teterin wrote:
> mi          2010-12-14 06:11:04 UTC
> 
>   Added files:
>     net/minidlna         Makefile distinfo pkg-descr pkg-plist 
>     net/minidlna/files   BSDmakefile config.h getifaddr.c 
>                          minidlna.sh.in patch-2928850 patch-aa 
>                          patch-ab patch-inline patch-minidlna.c 
>                          patch-upnphttp pkg-message.in 
>                          scandir-patch 
>   Log:
>   Add the port of minidlna -- the DLNA-speaking service.
>   (Took me 6 months to come up with the etc/rc.d/ script...)

It's sad that during these 6 months you did not find few minutes to ask
dougb@ to review it.

>   Revision  Changes    Path
>   1.1       +11 -0     ports/net/minidlna/files/patch-aa (new)
>   1.1       +9 -0      ports/net/minidlna/files/patch-ab (new)

Apart from number of style bugs in the Makefile, can you explain why did
you go with `patch-xy' files, which is against current naming policy?

./danfe