From owner-svn-src-head@FreeBSD.ORG  Tue Oct 21 21:03:50 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5B79E166;
 Tue, 21 Oct 2014 21:03:50 +0000 (UTC)
Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 15AAD8E2;
 Tue, 21 Oct 2014 21:03:50 +0000 (UTC)
Received: from slw by zxy.spb.ru with local (Exim 4.82 (FreeBSD))
 (envelope-from <slw@zxy.spb.ru>)
 id 1Xggai-0000nD-JK; Wed, 22 Oct 2014 01:03:40 +0400
Date: Wed, 22 Oct 2014 01:03:40 +0400
From: Slawa Olhovchenkov <slw@zxy.spb.ru>
To: Mateusz Guzik <mjg@FreeBSD.org>
Subject: Re: svn commit: r273335 - head/sys/fs/unionfs
Message-ID: <20141021210340.GA2178@zxy.spb.ru>
References: <201410201753.s9KHrnaG009500@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201410201753.s9KHrnaG009500@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: slw@zxy.spb.ru
X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Oct 2014 21:03:50 -0000

On Mon, Oct 20, 2014 at 05:53:49PM +0000, Mateusz Guzik wrote:

> Author: mjg
> Date: Mon Oct 20 17:53:49 2014
> New Revision: 273335
> URL: https://svnweb.freebsd.org/changeset/base/273335
> 
> Log:
>   unionfs: hold mount interlock while manipulating mnt_flag
>   
>   This is for consistency with other filesystems.

Can you check interoperability unionfs with zfs and devfs?
I have crashed unionfs with zfs.
unionfs with devfs need double devfs mount.

> Modified:
>   head/sys/fs/unionfs/union_vfsops.c
> 
> Modified: head/sys/fs/unionfs/union_vfsops.c
> ==============================================================================
> --- head/sys/fs/unionfs/union_vfsops.c	Mon Oct 20 17:04:03 2014	(r273334)
> +++ head/sys/fs/unionfs/union_vfsops.c	Mon Oct 20 17:53:49 2014	(r273335)
> @@ -290,12 +290,14 @@ unionfs_domount(struct mount *mp)
>  		return (error);
>  	}
>  
> +	MNT_ILOCK(mp);
>  	/*
>  	 * Check mnt_flag
>  	 */
>  	if ((ump->um_lowervp->v_mount->mnt_flag & MNT_LOCAL) &&
>  	    (ump->um_uppervp->v_mount->mnt_flag & MNT_LOCAL))
>  		mp->mnt_flag |= MNT_LOCAL;
> +	MNT_IUNLOCK(mp);
>  
>  	/*
>  	 * Get new fsid
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"