From owner-svn-src-head@freebsd.org Tue Jun 2 01:09:17 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DC1892F9887; Tue, 2 Jun 2020 01:09:17 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49bYpj5Tg3z4KPT; Tue, 2 Jun 2020 01:09:17 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (c-98-207-126-143.hsd1.ca.comcast.net [98.207.126.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id DB7E31552E; Tue, 2 Jun 2020 01:09:16 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.37.20051002 Date: Mon, 01 Jun 2020 18:09:12 -0700 Subject: Re: svn commit: r361677 - in head/usr.bin/svn: . lib lib/libapr lib/libapr_util lib/libserf lib/libsvn_client lib/libsvn_delta lib/libsvn_diff lib/libsvn_fs lib/libsvn_fs_fs lib/libsvn_fs_util lib/libs... From: Ravi Pokala To: , Ian Lepore CC: Dimitry Andric , , , Message-ID: Thread-Topic: svn commit: r361677 - in head/usr.bin/svn: . lib lib/libapr lib/libapr_util lib/libserf lib/libsvn_client lib/libsvn_delta lib/libsvn_diff lib/libsvn_fs lib/libsvn_fs_fs lib/libsvn_fs_util lib/libs... References: <304bb13cb6e80791f8924a573355a3643d614184.camel@freebsd.org> <202006011640.051GeOaf013240@gndrsh.dnsmgr.net> In-Reply-To: <202006011640.051GeOaf013240@gndrsh.dnsmgr.net> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 01:09:17 -0000 -----Original Message----- From: on behalf of "Rodney W. Grimes" Reply-To: Date: 2020-06-01, Monday at 09:40 To: Ian Lepore Cc: Dimitry Andric , , , Subject: Re: svn commit: r361677 - in head/usr.bin/svn: . lib lib/libapr lib/libapr_util lib/libserf lib/libsvn_client lib/libsvn_delta lib/libsvn_diff lib/libsvn_fs lib/libsvn_fs_fs lib/libsvn_fs_util lib/libs... > On Sun, 2020-05-31 at 22:04 +0000, Dimitry Andric wrote: > > Author: dim > > Date: Sun May 31 22:04:51 2020 > > New Revision: 361677 > > URL: https://svnweb.freebsd.org/changeset/base/361677 > > > > Log: > > Change Makefiles under usr.bin/svn to make them easier to > > incrementally > > update. No functional change intended. > > > > MFC after: 2 weeks > > > > I wish we could get style.Makefile(9) updated to mandate this 1-per- > line style when listing sources, dirs, etc, when the number of items is > greater than N, where N is something like 3-6 filenames. Otherwise the > requirement to sort the names alphabetically pretty much mandates that > many lines of the file will change just to insert one or two new files, > and that makes it all but impossible to figure out from a diff what > actually changed. I like this idea, though rather than 3-6 filenames I propose it to be anything longer than 3 lines, which is kinda about when the pain point should start. See the immediate SUBDIR below, it is 11 items on 2ish/3 lines, and any change would worst case be a 3 line diff. This probably covers a large portion of the tree. FWIW, I'm partial to the 'FOO+=bar' syntax, rather than continuation lines. It's too easy to forget to add the continuation when appending or inserting. I particularly do not like massive amounts of vertical white space which this would create, but lacking an automated tool this is probably a reasonable compromise. If we did it everywhere it would mean lots of scrolling when working on rather simple makefiles. I generally feel the opposite -- I do a destressing amount of work on an 80x24 serial console :-/ -- but I agree that "> 3 lines" is a reasonable compromise. -Ravi (rpokala@) > -- Ian > > > > [...] > > -SUBDIR= lib .WAIT \ > > - svn svnadmin svnbench svndumpfilter svnfsfs svnlook svnserve \ > > - svnsync svnversion svnmucc svnrdump > > +SUBDIR= lib \ > > + .WAIT \ > > + svn \ > > + svnadmin \ > > + svnbench \ > > + svndumpfilter \ > > + svnfsfs \ > > + svnlook \ > > + svnserve \ > > + svnsync \ > > + svnversion \ > > + svnmucc \ > > + svnrdump > > SUBDIR_PARALLEL= > > > > -- Rod Grimes rgrimes@freebsd.org