From owner-svn-ports-head@freebsd.org Mon Oct 17 16:32:00 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBB47C15842; Mon, 17 Oct 2016 16:32:00 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A2C239; Mon, 17 Oct 2016 16:31:59 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [127.0.0.1] (ip72-204-34-204.fv.ks.cox.net [72.204.34.204]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 68D9743C19; Mon, 17 Oct 2016 11:31:31 -0500 (CDT) Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files To: Mathieu Arnold , marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201610171515.u9HFF8pG092481@repo.freebsd.org> <1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org> <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st> <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> Reply-To: marino@freebsd.org From: John Marino Message-ID: <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> Date: Mon, 17 Oct 2016 11:31:57 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Antivirus: avast! (VPS 161017-0, 10/17/2016), Outbound message X-Antivirus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 16:32:00 -0000 On 10/17/2016 11:28, Mathieu Arnold wrote: > Le 17/10/2016 à 18:26, John Marino a écrit : >> On 10/17/2016 11:20, Mathieu Arnold wrote: >>> Le 17/10/2016 à 17:55, John Marino a écrit : >>>> On 10/17/2016 10:52, Mathieu Arnold wrote: >>>>> Le 17/10/2016 à 17:15, John Marino a écrit : >>>>>> Apparently USES=pathfix and USES=autoreconf can't be used >>>>>> together, so >>>>>> the pkgconfig directory is now passed via MAKE_ARGS >>>>> >>>>> That is mostly not true. What usage makes it so that they do not work >>>>> together ? >>>> >>>> The results suggest that "${WRKSRC}/configure" was modified, then >>>> autoreconf regenerated ${WRKSRC}/configure afterwards so that the >>>> pkgconfig path change was reverted. >>>> >>>> That's why I had to replace pathfix with MAKE_ARGS. >>> >>> No, USES=pathfix changes the content of PATHFIX_MAKEFILEIN, which by >>> default, is Makefile.in. It won't change configure unless you set >>> PATHFIX_MAKEFILEIN=configure. >>> >> >> Well, I didn't add MAKE_ARGS for fun. >> After adding USES+=autoreconf, the build broke. pathfix was still in >> place. You can reproduce by adding pathfix back before "python" and >> commenting out the new MAKE_ARGS line I added and check with >> "check-plist" It's easy to confirm. > > I never said your fix did not work or was not right, I said USES=pathfix > won't touch configure. > Ah, that's the issue. I misspoke. I didn't mean "configure", I mean the Makefile all along. So you agree in this case pathfix and autoreconf aren't compatible, right? John --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus