From owner-freebsd-current@FreeBSD.ORG Fri Mar 11 19:11:50 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5672716A4CE for ; Fri, 11 Mar 2005 19:11:50 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id B090C43D39 for ; Fri, 11 Mar 2005 19:11:49 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] (sam@[66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j2BJAkms073278 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 Mar 2005 11:10:47 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <4231ED9A.3090504@errno.com> Date: Fri, 11 Mar 2005 11:12:26 -0800 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041208) X-Accept-Language: en-us, en MIME-Version: 1.0 To: frank@exit.com References: <200503111829.j2BITm9x094682@realtime.exit.com> In-Reply-To: <200503111829.j2BITm9x094682@realtime.exit.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: FreeBSD Current cc: Eric Anderson Subject: Re: [Fwd: cvs commit: src/sys/modules Makefile src/sys/conf files src/sys/modules/ath_rate_sample Makefile src/sys/i386/conf NOTES] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2005 19:11:50 -0000 Frank Mayhar wrote: > Eric Anderson wrote: > >>Hmm - this was working this morning before I updated, with a -CURRENT as of last week, and I didn't notice anything in /usr/src/UPDATING. So what I should have is: >> >>ath_load="YES" >>ath_hal_load="YES" >>ath_rate_load="YES" > > > I just have > > if_ath_load="YES" > > in my /boot/loader.conf. That picks up everything. > > >>I guess what I missed (and just noticed), is that there are not individual modules for each rate algorithm now, one module (named ath_rate) that is the algorithm of whatever is built. > > > It has been this way for some time, actually. Yes, I forgot about this little "detail". As a result of my change folks using modules are now using ath_rate_sample by default. I'll deal with it. > > >>>You want to go to sys/modules/ath_rate_{amrr|onoe|sample} and do a 'make >>>install'. >> >>I did that already - but why doesn't a 'make installkernel ...' not accomplish that? (forgive my ignorance) > > > It does. It installs ath_rate.ko for each of amrr, onoe and (now) sample. > Obviously, the last one in wins. You'll have to ask Sam about what shortcoming > of the FreeBSD module system leads to this. Actually it's nothing to do with the module system. When I split the rate control code into a separate module various folks didn't want to incur the overhead of using indrect function pointers in the fast path so we used the symbol names to bind rate control support to the driver. This has many downsides and I'm not reall happy with it but since it's unlikely folks will want to run multiple algorithms concurrently I've not spent any time on the issue. > > >>>Hmm. Is ath_rate_sample linked properly? >> >>How can I help you determine that? (is readelf -a output what you want?) > > > Already fixed; read your -current email. Yes, Tai-hwa fixed my botch (I'd tested only with a statically linked kernel). Sam