From owner-cvs-src@FreeBSD.ORG Sat Oct 18 12:15:06 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A73B416A4B3; Sat, 18 Oct 2003 12:15:06 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FC8443FA3; Sat, 18 Oct 2003 12:15:03 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id h9IJF2on009206; Sat, 18 Oct 2003 21:15:02 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Nate Lawson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 18 Oct 2003 12:13:09 PDT." <20031018121152.V47115@root.org> Date: Sat, 18 Oct 2003 21:15:02 +0200 Message-ID: <9205.1066504502@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_bio.c src/sys/fs/nwfs nwfs_vnops.c src/sys/fs/smbfs smbfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Oct 2003 19:15:06 -0000 In message <20031018121152.V47115@root.org>, Nate Lawson writes: >> @@ -799,8 +799,7 @@ >> KASSERT(ap->a_vp == ap->a_bp->b_vp, ("%s(%p != %p)", >> __func__, ap->a_vp, ap->a_bp->b_vp)); >> NCPVNDEBUG("\n"); >> - if (bp->b_flags & B_PHYS) >> - panic("nwfs physio"); >> + KASSERT(!(bp->b_flags & B_PHYS), ("nwfs physio")); >> if (bp->b_flags & B_ASYNC) >> td = (struct thread *)0; > else > >This removes sanity checks for the !INVARIANTS case (which all our >releases are). This sanity-check is OBE, and B_PHYS as such is about to disappear. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.