From owner-cvs-all Wed May 31 11: 9:37 2000 Delivered-To: cvs-all@freebsd.org Received: from mass.cdrom.com (www.slackware.com [204.216.27.13]) by hub.freebsd.org (Postfix) with ESMTP id 737B137BEAB; Wed, 31 May 2000 11:09:28 -0700 (PDT) (envelope-from msmith@mass.cdrom.com) Received: from mass.cdrom.com (localhost [127.0.0.1]) by mass.cdrom.com (8.9.3/8.9.3) with ESMTP id LAA00398; Wed, 31 May 2000 11:12:04 -0700 (PDT) (envelope-from msmith@mass.cdrom.com) Message-Id: <200005311812.LAA00398@mass.cdrom.com> X-Mailer: exmh version 2.1.1 10/15/1999 To: Bruce Evans Cc: Mike Smith , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/quot quot.c In-reply-to: Your message of "Thu, 01 Jun 2000 03:23:10 +1000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 31 May 2000 11:12:04 -0700 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > 8) This sounds like an argument for sysctlbyname("path_dev") to me... > > I only meant complete hard-coding of the strings. If everything used > macros for paths, then it might be possible to support dynamic paths by > #defining the macros as function calls. > > > How do you feel about ANSI string concatenation, eg: > > > > open(PATH_DEV "rmt0", ... > > This would break K&R support :-), and wouldn't work in most contexts > (the basename is normally from argv[]; for dump(8) it may be from the > environment). In the cases where path components are separate, there's no issue (since the code typically uses sprintf or strcat or similar); the only case that gives me pause is when we have something like: "/dev/rmt0" If all that we lose is K&R support, I'm not going to shed any tears. Sorry. 8) -- \\ Give a man a fish, and you feed him for a day. \\ Mike Smith \\ Tell him he should learn how to fish himself, \\ msmith@freebsd.org \\ and he'll hate you for a lifetime. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message