From owner-svn-src-head@FreeBSD.ORG Wed Nov 16 21:11:59 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A0981065674; Wed, 16 Nov 2011 21:11:59 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1EDD98FC18; Wed, 16 Nov 2011 21:11:36 +0000 (UTC) Received: by vcbfy13 with SMTP id fy13so301242vcb.13 for ; Wed, 16 Nov 2011 13:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=98oqXUBFXeFgc9aqPqtoMqJRhYA0UyzjITNmPPGA91k=; b=H7L+Sm8m3ACaQRWoxZWvN3VZgLf45zU0yKGFdWqMLUO8/+J0w/BuOYJjvXXoYyxWPW fJ/osjf5HuhJwWWX5f1uxNj2Htd1HHKYg1igxIcGCpC1WN9oToBwyv3kOQ4O6Q9jQZIZ k0yqQtw3ONqMsw8kZyx7M1KhigIIAgWMa2vPs= MIME-Version: 1.0 Received: by 10.52.34.78 with SMTP id x14mr46308598vdi.122.1321477896063; Wed, 16 Nov 2011 13:11:36 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.29.198 with HTTP; Wed, 16 Nov 2011 13:11:36 -0800 (PST) In-Reply-To: <20111116195912.GL36205@hoeg.nl> References: <201111081708.pA8H8CnM040532@svn.freebsd.org> <20111116195912.GL36205@hoeg.nl> Date: Wed, 16 Nov 2011 13:11:36 -0800 X-Google-Sender-Auth: XU_QBNai8FtC6bSUXSQEghozcCI Message-ID: From: Adrian Chadd To: Ed Schouten Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227344 - head/sys/dev/ath X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2011 21:11:59 -0000 On 16 November 2011 11:59, Ed Schouten wrote: > Hi Adrian, > > * Adrian Chadd , 20111108 18:08: >> -static MALLOC_DEFINE(M_ATHDEV, "athdev", "ath driver dma buffers"); >> +MALLOC_DEFINE(M_ATHDEV, "athdev", "ath driver dma buffers"); > > Is there a reason why we can't mark this static? Some future work is going to split out some of the TX and RX DMA buffer management, and this will require the definition to be non-static. Adrian