From owner-freebsd-current@FreeBSD.ORG Thu Jun 5 22:09:26 2008 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA7921065675; Thu, 5 Jun 2008 22:09:26 +0000 (UTC) (envelope-from stas@ht-systems.ru) Received: from smtp.ht-systems.ru (mr0.ht-systems.ru [78.110.50.55]) by mx1.freebsd.org (Postfix) with ESMTP id 9B47A8FC16; Thu, 5 Jun 2008 22:09:26 +0000 (UTC) (envelope-from stas@ht-systems.ru) Received: from [85.21.245.235] (helo=phonon.ht-systems.ru) by smtp.ht-systems.ru with esmtpa (Exim 4.62) (envelope-from ) id 1K4Ne8-0000Oh-VB; Fri, 06 Jun 2008 02:09:25 +0400 Received: by phonon.ht-systems.ru (Postfix, from userid 1001) id 2C0A37EDDDE; Fri, 6 Jun 2008 02:09:27 +0400 (MSD) Date: Fri, 6 Jun 2008 02:09:27 +0400 From: Stanislav Sedov To: Rui Paulo Message-Id: <20080606020927.8d6675e1.stas@FreeBSD.org> In-Reply-To: <20080605204823.GA7361@epsilon.local> References: <20080605231705.db589d89.stas@FreeBSD.org> <20080605204823.GA7361@epsilon.local> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-PGP-Fingerprin: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581 X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Fri__6_Jun_2008_02_09_27_+0400_/HeAP5=ja3dyVky6" Cc: kib@FreeBSD.org, current@FreeBSD.org Subject: Re: cpuctl(formely devcpu) patch test request X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jun 2008 22:09:27 -0000 --Signature=_Fri__6_Jun_2008_02_09_27_+0400_/HeAP5=ja3dyVky6 Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, 5 Jun 2008 21:55:39 +0100 Rui Paulo mentioned: > A couple comments: > 1) Do you plan to MFC this ? For what older versions of FreeBSD will devc= pu be > shipped? In fact, I plan to MFC that to all supported FreeBSD versions (6, 7), as changes are minimal. Until that those versions will be supported by sysutils/devcpu port. >=20 > 2) in cpuctl_modevent(): perhaps it's better to return ENOMEM instead of > ENOSYS if malloc() fails and ENXIO instead of ENOSYS if MSR functionality= is > not present I fully agree on ENOMEM (thanks for noticing that), while I think that returning ENOSYS for MSR-less systems is more correct, as it states that required functionality isn't implemented for this hardware. =20 > 3) I don't mean to impose, but this code needs some small style cleanup, > namely: characters above the 80 column, second level indents are four > spaces" Good catch! Fixed. The updated patch is available at http://www.springdaemons.com/stas/cpuctl.2.diff --=20 Stanislav Sedov ST4096-RIPE --Signature=_Fri__6_Jun_2008_02_09_27_+0400_/HeAP5=ja3dyVky6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkhIZBcACgkQK/VZk+smlYGAAwCeJaDzR/rTaHR5CKT3ASEVI0oB wpwAoIJRjxz21vbtRh61NLZkcOcLY/Rt =cXz9 -----END PGP SIGNATURE----- --Signature=_Fri__6_Jun_2008_02_09_27_+0400_/HeAP5=ja3dyVky6--