From owner-freebsd-bugs@FreeBSD.ORG  Thu Jul 31 15:50:21 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 08F5337B415
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 31 Jul 2003 15:50:21 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BCB8443FE3
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 31 Jul 2003 15:50:15 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h6VMoFUp023127
	for <freebsd-bugs@freefall.freebsd.org>;
	Thu, 31 Jul 2003 15:50:15 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h6VMoFM0023126;
	Thu, 31 Jul 2003 15:50:15 -0700 (PDT)
Date: Thu, 31 Jul 2003 15:50:15 -0700 (PDT)
Message-Id: <200307312250.h6VMoFM0023126@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Steve Roome <stephen_roome@pepcross.com>
Subject: Re: i386/41930: declaration clash for ffs() and ${CXX}
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Steve Roome <stephen_roome@pepcross.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Jul 2003 22:50:21 -0000

The following reply was made to PR i386/41930; it has been noted by GNATS.

From: Steve Roome <stephen_roome@pepcross.com>
To: freebsd-gnats-submit@FreeBSD.org, corecode@corecode.ath.cx
Cc:  
Subject: Re: i386/41930: declaration clash for ffs() and ${CXX}
Date: Thu, 31 Jul 2003 23:48:08 +0100

 Just noticed that on 4.8-STABLE I get a similar effect compiling code
 with -ansi. Which is similar, possibly slightly different, but adds
 weight for the argument for fixing the ffs() code.
 
 - Example Code ---------------------------------------------------------
 
 #include <string.h>
 #include <machine/console.h>
 #include <vgl.h>
 int main() { return 1; }
 
 - Example Compiler Output ----------------------------------------------
 
 gcc -ansi -Wall -Werror test.c
 cc1: warnings being treated as errors
 In file included from /usr/include/vgl.h:37,
                  from test.c:3:
 /usr/include/machine/cpufunc.h:118: warning: static declaration for `ffs' follows non-static
 
 - End Example ----------------------------------------------------------
 
 This "implementation detail" might be used by a programmer using C++
 or -ansi on a C program, surely it should work ?
 
 [ The code quality rant is left as an exersize for the reader! ]
 
 
         Steve Roome