From owner-cvs-src@FreeBSD.ORG Wed Oct 31 21:51:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B83516A469; Wed, 31 Oct 2007 21:51:55 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id DE19613C4B0; Wed, 31 Oct 2007 21:51:51 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9VLpK5W090371; Thu, 1 Nov 2007 00:51:20 +0300 (MSK) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1193867480; bh=w4NFilRvhToE39/cR8NWt6Jiz73NDS0CLj8ZS62 9AQ4=; l=939; h=Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:User-Agent; b=jquD8DXpSNMV8q3YbqakDI89I2n0N9z7l3qtC4zU Mh6cJ3vzU/Vg6plioLKw0p+FfGW3jgTHh7NyPpE+b5F9UWO5oyh+edVP1v4EB4E4WOf +FHmGsKtgKKe3tsohYD7OWJbGqfF/+Kzvglaof5FYf+SOpj4ud+vbzOheGzrw1ZY= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9VLpJZh090370; Thu, 1 Nov 2007 00:51:19 +0300 (MSK) (envelope-from ache) Date: Thu, 1 Nov 2007 00:51:18 +0300 From: Andrey Chernov To: Bruce Evans Message-ID: <20071031215117.GB89932@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Bruce Evans , d@delphij.net, Scott Long , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720E0AF.1010004@samsco.org> <4720E904.2090704@delphij.net> <20071031205412.U3526@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071031205412.U3526@delplex.bde.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.ORG, Scott Long , src-committers@FreeBSD.ORG, d@delphij.net, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2007 21:51:55 -0000 On Wed, Oct 31, 2007 at 09:41:13PM +1100, Bruce Evans wrote: > Now the limit is spelled 128, so it really is constant and won't cause > problems unless the constant changes. Only in one particular case, the rest cases still need __mb_sb_limit. > _ctype.h still declares __mb_sb_limit but now doesn't use it. Do you mean 6x _ctype.h? 8x _ctype.h uses it. > __mb_sb_limit is still initialized in many files in libc/locale. These > initializations now seem to be unused. Some of them are to 256, so why > is the constant only 128? As I already say, there is 3 cases left where it is non-constant. > __mb_sb_limit is still in Symbol.map. I think this would be needed if > __mb_sb_limit were actually used (since although it is now private to > the library, it would be part of an inter-library ABI if it were used). It is actually used (for __sbmaskrune, __sbtoupper and __sbtolower). -- http://ache.pp.ru/