From owner-cvs-all@FreeBSD.ORG  Mon Mar 31 17:02:04 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6ABB537B401; Mon, 31 Mar 2003 17:02:04 -0800 (PST)
Received: from k6.locore.ca (k6.locore.ca [198.96.117.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7BCE943F85; Mon, 31 Mar 2003 17:02:03 -0800 (PST)
	(envelope-from jake@k6.locore.ca)
Received: from k6.locore.ca (localhost.locore.ca [127.0.0.1])
	by k6.locore.ca (8.12.8/8.12.8) with ESMTP id h3118YxS039878;
	Mon, 31 Mar 2003 20:08:34 -0500 (EST)
	(envelope-from jake@k6.locore.ca)
Received: (from jake@localhost)
	by k6.locore.ca (8.12.8/8.12.8/Submit) id h3118Yeo039877;
	Mon, 31 Mar 2003 20:08:34 -0500 (EST)
Date: Mon, 31 Mar 2003 20:08:33 -0500
From: Jake Burkholder <jake@locore.ca>
To: Nate Lawson <nate@root.org>
Message-ID: <20030401010833.GA39531@locore.ca>
References: <XFMail.20030331155020.jhb@FreeBSD.org>
	<Pine.BSF.4.21.0303311635490.8123-100000@root.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.BSF.4.21.0303311635490.8123-100000@root.org>
User-Agent: Mutt/1.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: John Baldwin <jhb@FreeBSD.org>
Subject: Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c
	if_sis.c if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Apr 2003 01:02:04 -0000

Apparently, On Mon, Mar 31, 2003 at 04:37:15PM -0800,
	Nate Lawson said words to the effect of;

> On Mon, 31 Mar 2003, John Baldwin wrote:
> > On 31-Mar-2003 John Baldwin wrote:
> > > jhb         2003/03/31 12:22:00 PST
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/pci              if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c 
> > >                          if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c 
> > >   Log:
> > >   Add missing ()'s so that these drivers all compile again.
> > >   
> > >   Noticed by:     jake
> > >   Tested on:      i386 (compile)
> > 
> > Also, the pcn(4) driver still has some possibly bogus locking in
> > its probe routine.  Not sure if other drivers have locks in their
> > probe routines.
> 
> Thank you jhb and jake for fixing the KASSERT ()'s.  I had options
> INVARIANTS in my kernel so I'm not sure why this was not caught.  I was
> compiling them as modules so does INVARIANTS not enable KASSERT in
> modules?

It does not, option headers and not created automatically for modules.

Jake