Date: Wed, 02 Nov 2005 11:19:34 -0800 From: Julian Elischer <julian@elischer.org> To: Kazuhito HONDA <kazuhito@ph.noda.tus.ac.jp> Cc: freebsd-multimedia@freebsd.org, Alexander@Leidinger.net, skywizard@MyBSD.org.my Subject: Re: uaudio and Digigram UAX220 Message-ID: <43691146.7030404@elischer.org> In-Reply-To: <20051102.231412.343190544.kazuhito@ph.noda.tus.ac.jp> References: <20051027133448.vptim01kwoco8wcw@netchild.homeip.net> <20051028.224049.343190967.kazuhito@ph.noda.tus.ac.jp> <20051029094831.1c6c785d.skywizard@MyBSD.org.my> <20051102.231412.343190544.kazuhito@ph.noda.tus.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
Kazuhito HONDA wrote: >From: Ariff Abdullah <skywizard@MyBSD.org.my> >Subject: Re: uaudio and Digigram UAX220 >Date: Sat, 29 Oct 2005 09:48:31 +0800 > > > >>Could you please do the cleanup? :) The only thing is that Julian >>already said that those patch break his USB microphone, so this must >>undergo some serious regression test to be accepted. >> >> I'll try it on my microphone again tonight. > >Oh, I missed that. I wonder why it isn't committed. >I have searched the patch and found one problem. > >In uaudio_query_formats() of uaudio.c >+ >+ if ( numchan != 1 && numchan == 2 ) >+ >+ foundcount++; >+ > >`foundcount' is a flag to indicate which a valid format is found or not. >`numchan' is a number of channel. >If a device has mono channels only, foundcont flag isn't changed. >I guess that it broke Julian's USB microphone, >because microphone is usually mono. > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43691146.7030404>