Date: Mon, 23 Mar 2015 00:37:17 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r381980 - head Message-ID: <550FA68D.4080609@FreeBSD.org> In-Reply-To: <550F9BCB.5080004@FreeBSD.org> References: <201503230408.t2N48SZH015518@svn.freebsd.org> <550F9BCB.5080004@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NwGS5Ok5R1TRhaD9u3dDTFA6tA8xA3EPR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 3/22/2015 11:51 PM, Bryan Drewery wrote: > On 3/22/2015 11:08 PM, Bryan Drewery wrote: >> Author: bdrewery >> Date: Mon Mar 23 04:08:27 2015 >> New Revision: 381980 >> URL: https://svnweb.freebsd.org/changeset/ports/381980 >> QAT: https://qat.redports.org/buildarchive/r381980/ >> >> Log: >> Undocument BSDMAKE from r381977 as I have thought of a better way an= d will >> likely revert it. >> =20 >> With hat: portmgr >> >> Modified: >> head/CHANGES >> >> Modified: head/CHANGES >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/CHANGES Mon Mar 23 04:07:08 2015 (r381979) >> +++ head/CHANGES Mon Mar 23 04:08:27 2015 (r381980) >> @@ -10,13 +10,6 @@ in the release notes and/or placed into=20 >> =20 >> All ports committers are allowed to commit to this file. >> =20 >> -20150322: >> - AUTHOR: bdrewery@FreeBSD.org >> - >> - There is now a BSDMAKE that can be overriden for the location of >> - /usr/bin/make. It is a safer alternative to overriding MAKE_CMD whi= ch >> - will be force reset for gmake/fmake/scons ports. >> - >> 20150319: >> AUTHOR: bdrewery@FreeBSD.org >> =20 >> >=20 > I feel the need to define BSDMAKE still but don't like that it is not > just MAKE_CMD since that is what has been advertised for so long. >=20 > MAKE_CMD currently has 2 uses. Both the default /usr/bin/make location > and the make that is used to interact with a port's distribution > Makefile. When using USES=3Dgmake for example MAKE_CMD becomes gmake. > There then is no way to define what the default make was (/usr/bin/make= ) > if it is still needed. >=20 > From sometime last year until r381976 a user setting MAKE_CMD would not= > be able to build gmake/scons/fmake ports. >=20 > What I am trying to do is interact with the ports tree with bmake but > build ports with fmake. Bmake does not work with the /usr/share/mk on > 8.4/9.3 but it works fine with the ports tree. Any actual Makefile with= > real object targets it encounters hits a 'dirsyntax' error and fails. S= o > I am trying to ensure that ports are respecting MAKE_CMD and building > with my override of /usr/bin/fmake since I have made /usr/bin/make into= > bmake. This idea may grow into a bootstrapped bmake so 8.4 does not > instantly break on EOL day. I don't know if I will take it that far. >=20 > This is why I have added BSDMAKE and switched to it in the qemu ports i= n > r381978 since they have USES=3Dgmake and get a MAKE_CMD=3Dgmake. MAKE i= s > bmake in my use. I insist that using ${MAKE} to build a port's > distribution files is just fundamentally wrong; it should only be used > to interact recursively with the framework. This port was nice enough t= o > spell out that it needs a real bsd make to build. It may even work with= > gmake at this point but I did not test. >=20 > Incidentally I have been finding a lot interesting bugs with MAKE_CMD > usage. Some ports claim to need gmake but are accidentally using bsdmak= e > in the middle of their build. It has just worked by accident. I imagine= > that fixing these to properly use MAKE_CMD (hence gmake) will improve > parallel builds as well. >=20 > So my alternative idea for BSDMAKE was to mass replace MAKE_CMD with > _MAKE_CMD in ports and then keep MAKE_CMD to mean /usr/bin/make. I'm no= t > sure which route should be taken. >=20 Actually I've hit a few blockers that are showing me this is just not going to work. I'm going a different route with using bmake. I think there are a lot of MAKE->MAKE_CMD cleanup to still do but that it it not as relevant for my use case now. --=20 Regards, Bryan Drewery --NwGS5Ok5R1TRhaD9u3dDTFA6tA8xA3EPR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVD6aNAAoJEDXXcbtuRpfPVDwIAOBb781rgVdNwdr06qva3JhI zC6TagRl4ixbxgdZ4l/weWPTccQhcjjAal78JZEqwJ+WIoeER3OfdHPMB0pn3y9y /iOA6WHVLoTwSQpzXRNZft7mnmWyChTVEpZ3+sjgwYW0Nuvzlj50VeVtUWrvgjlB KDiL47nnM3slRUzT6XzJsI0syX9WU52dGp7qkFuAfyWjGZAmw6YBYpIF7fse5tKA OgZzIIJVXS5vvb7DO+mlxHUkbyiEpZL+GXN1bYFqhI88o12GM6E1cswsiiDhcamg XV9+bFaiADd23cvVtgwxx/GWjdjKGxi/FUOii0N1J+RLJgH/PXc8zrjH+NXmnms= =ezuo -----END PGP SIGNATURE----- --NwGS5Ok5R1TRhaD9u3dDTFA6tA8xA3EPR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?550FA68D.4080609>