From owner-svn-src-all@FreeBSD.ORG  Mon Aug 25 16:09:46 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CFCF769E;
 Mon, 25 Aug 2014 16:09:46 +0000 (UTC)
Received: from mail.made4.biz (mail.made4.biz [IPv6:2001:41d0:2:c018::1:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 947653B8C;
 Mon, 25 Aug 2014 16:09:46 +0000 (UTC)
Received: from 141.7.19.93.rev.sfr.net ([93.19.7.141] helo=i915.dumbbell.fr)
 by mail.made4.biz with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128)
 (Exim 4.82_1-5b7a7c0-XX (FreeBSD))
 (envelope-from <dumbbell@FreeBSD.org>)
 id 1XLwq0-000AgL-RW; Mon, 25 Aug 2014 18:09:45 +0200
Message-ID: <53FB5FC8.4030105@FreeBSD.org>
Date: Mon, 25 Aug 2014 18:09:44 +0200
From: =?windows-1252?Q?Jean-S=E9bastien_P=E9dron?= <dumbbell@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>, Adrian Chadd <adrian@freebsd.org>
Subject: Re: svn commit: r270516 - head/sys/dev/drm2/i915
References: <201408250503.s7P53Axo057720@svn.freebsd.org>
 <2177184.NMfUXrE71G@ralph.baldwin.cx>
In-Reply-To: <2177184.NMfUXrE71G@ralph.baldwin.cx>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Aug 2014 16:09:46 -0000

On 25.08.2014 16:26, John Baldwin wrote:
> Also, is leaving around the #if 0'd Linux version something the drm2 code does
> in general or was that unique to this patch?  If the latter, we should remove
> the duplicate #if 0 code (list_for_each, etc.)

There's no actual consensus, I guess. In my DRM 3.8 branch, where I try 
to reduce the diff with Linux, I try to provide wrappers and keep the 
Linux code.

Before that branch is merged, I'm in favor of keeping the Linux code 
around (but maybe use #ifdef __FreeBSD__) to keep an history of what was 
originally ported.

-- 
Jean-Sébastien Pédron