Date: Wed, 10 Dec 1997 18:28:09 -0800 From: David Greenman <dg@root.com> To: John-Mark Gurney <gurney_j@resnet.uoregon.edu> Cc: FreeBSD Hackers <freebsd-hackers@FreeBSD.ORG> Subject: Re: merge bpfattach into if_attach... Message-ID: <199712110228.SAA14235@implode.root.com> In-Reply-To: Your message of "Wed, 10 Dec 1997 16:46:19 PST." <19971210164619.03585@hydrogen.nike.efn.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>I was just working on the strip star mode driver from NetBSD (it works!) >and noticed this really stupid piece of code that I KNOW is in every >interface driver: >#if NBPFILTER > 0 > bpfattach(&sc->sc_if, DLT_SLIP, SLIP_HDRLEN); >#endif > >and just before that code is a call to if_attach... is there any >problem by merging these two together? and then in if_attach if >NBPFILTER is > 0, call the proper bpfattach routine? it seems really >stupid to touch ever driver, when a small modification can improve the >code... > >and yes, I know that it will break the interface that made it so easy >to get NetBSD's star mode driver up and running... :) If we did that, then we would require that all network drivers have BPF support. While this might be true at the moment, it hasn't always been true in the past nor can we assume it will be in the future. -DG David Greenman Core-team/Principal Architect, The FreeBSD Project
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712110228.SAA14235>