From owner-cvs-src@FreeBSD.ORG Fri May 6 03:22:05 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FCE216A4D0 for ; Fri, 6 May 2005 03:22:05 +0000 (GMT) Received: from mail27.sea5.speakeasy.net (mail27.sea5.speakeasy.net [69.17.117.29]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1364E43D76 for ; Fri, 6 May 2005 03:22:04 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 18417 invoked from network); 6 May 2005 03:22:03 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail27.sea5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 6 May 2005 03:22:03 -0000 Received: from hydrogen.funkthat.com (xklmrw@localhost.funkthat.com [127.0.0.1])j463M3mo036318; Thu, 5 May 2005 20:22:03 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id j463M37B036317; Thu, 5 May 2005 20:22:03 -0700 (PDT) Date: Thu, 5 May 2005 20:22:02 -0700 From: John-Mark Gurney To: Colin Percival Message-ID: <20050506032202.GC2670@funkthat.com> References: <200505060248.j462mL0k009905@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200505060248.j462mL0k009905@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_bus.c subr_rman.c vfs_subr.c src/sys/net if_mib.c src/sys/netinet ip_divert.c raw_ip.c udp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2005 03:22:05 -0000 Colin Percival wrote this message on Fri, May 06, 2005 at 02:48 +0000: > cperciva 2005-05-06 02:48:21 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_bus.c subr_rman.c vfs_subr.c > sys/net if_mib.c > sys/netinet ip_divert.c raw_ip.c udp_usrreq.c > Log: > If we are going to > 1. Copy a NULL-terminated string into a fixed-length buffer, and > 2. copyout that buffer to userland, > we really ought to > 0. Zero the entire buffer > first. > > Security: FreeBSD-SA-05:08.kmem /me notes this is a good reason to use strncpy instead of strlcpy. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."