Date: Thu, 9 Dec 2004 12:34:08 +0100 From: Max Laier <max@love2party.net> To: Ruslan Ermilov <ru@freebsd.org> Cc: Steve Kargl <sgk@troutmask.apl.washington.edu> Subject: Re: protocol timer running before protocol is fully initialized (again) (was re: panic: mtx_lock() of spin mutex ...) Message-ID: <200412091234.19912.max@love2party.net> In-Reply-To: <20041209101524.GC62331@ip.net.ua> References: <Pine.NEB.3.96L.1041209023008.44319C-100000@fledge.watson.org> <200412090411.42258.max@love2party.net> <20041209101524.GC62331@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1178026.9nY22vnAXz Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Ruslan, On Thursday 09 December 2004 11:15, Ruslan Ermilov wrote: > Hi Max, > > On Thu, Dec 09, 2004 at 04:11:26AM +0100, Max Laier wrote: > > On Thursday 09 December 2004 03:31, Robert Watson wrote: > > > On Wed, 8 Dec 2004, Steve Kargl wrote: > > > > panic: mtx_lock() of spin mutex (null) @ sys/netinet/frag6.c:682 > > > > cpuid =3D 0 > > > > kdb_backtrace+0x37 > > > > panic+0x1d1 > > > > _mtx_lock_flags+0x72 > > > > frag6_slowtimo+0x26 > > > > pfslowtimo+0x5a > > > > softclock+0x1c0 > > > > ithread_loop+0x179 > > > > fork_exit+0xe9 > > > > fork_trampoline+0xe > > > > > > > > This is FreeBSD/amd64 from today's sources of about 30 minutes ago. > > > > > > > >From the instant interpretation unit: it looks like this is another > > > > > > example of a protocl's timeout firing before the protocol is properly > > > initialized, as the mutex appears to be zero'd due to being in BSS. > > > > Here is a lazy fix: > > http://people.freebsd.org/~mlaier/uipc_domain.c.lazy.diff > > > > Should help for (almost) sure. This fixes all domains that are > > initialized in SI_SUB_PROTO_DOMAIN, those that are initialized later on > > (netgraph e.g.) can still trigger this prime example why it's bad to ho= ok > > something in before initializing it properly. Unfortunately our code and > > API force us to do so at the moment :-\ > > > > Please tell me if the patch (apply to src/sys/kern/uipc_domain.c) helps. > > I've got the same panic early on boot, but in ip_input(), on i386. > Your patch helps. in ip_input() - that's not good! Can you send me the trace? I was under the= =20 impression that net send and esp. reveice is off during this part of the=20 initialization. Crashing ip_input() would question that assumption. Thanks. Anyway, have enough "working for me" by now. Will commit the temporary fix. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart1178026.9nY22vnAXz Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBuDg7XyyEoT62BG0RAn/IAJ9EEGZeSi07aLkreBF4wrQ73figXgCfdwYq XXVqE+BSznlgx3+OZVTgnKw= =zr7M -----END PGP SIGNATURE----- --nextPart1178026.9nY22vnAXz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200412091234.19912.max>