Date: Tue, 28 Mar 2017 20:51:48 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Warner Losh <imp@bsdimp.com> Cc: Bruce Evans <brde@optusnet.com.au>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r316064 - head/sys/boot/i386/boot2 Message-ID: <20170328203618.N1920@besplex.bde.org> In-Reply-To: <CANCZdfrJNrk3h-vGzBcWkguWM3VimasYajxFgyOA9okPe5Ghrw@mail.gmail.com> References: <201703272253.v2RMra2L032487@repo.freebsd.org> <20170328141213.T927@besplex.bde.org> <CANCZdfrJNrk3h-vGzBcWkguWM3VimasYajxFgyOA9okPe5Ghrw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 28 Mar 2017, Warner Losh wrote: > [[ sorry for the top post but it's quick ]] It's quicker and almost equivalent to delete what you reply to. > Summary, in Bruce's own words > >> the whole optimization step was silly. > > I agree. on my -current system, clang compiled boot2 was 4 bytes > smaller after ripping it out. gcc was a whopping 7 bytes larger. Since > gcc has 156 still free, I think it's best to just retire this. > > Maybe you can give me a hint as to which structs to look at to get > back those 7 bytes :) Just sort the character arrays to get back 4. Maybe clang already does this, though I like getting the same order as in the sources. Reducing 1 of the arrays by 1 byte would then save 1 and get back the other 3. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170328203618.N1920>