From owner-svn-ports-head@FreeBSD.ORG  Sat Apr  6 09:03:44 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 92F44534; Sat,  6 Apr 2013 09:03:44 +0000 (UTC)
Date: Sat, 6 Apr 2013 09:03:44 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux
 graphics/xaos math/qtiplot multimedia/minitube print/hplip
 textproc/qstardict
Message-ID: <20130406090344.GB8364@FreeBSD.org>
References: <201303251359.r2PDxIXf035701@svn.freebsd.org>
 <20130328025321.GC72629@FreeBSD.org>
 <CAF6rxgkipVS-gneKbOO-zFyUm=W3AeffBDGd2EegcUt8iXufDw@mail.gmail.com>
 <CAMHz58TjHwW9iKb2jSSBUrWk-zqt4+4PDfxxcqBZVxShg_YjTA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <CAMHz58TjHwW9iKb2jSSBUrWk-zqt4+4PDfxxcqBZVxShg_YjTA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>,
 svn-ports-all@freebsd.org, Eitan Adler <eadler@freebsd.org>,
 ports-committers <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Apr 2013 09:03:44 -0000

On Thu, Apr 04, 2013 at 05:24:32PM +0800, Sunpoet Po-Chuan Hsieh wrote:
> If maintainers think these options are annoying, they could put them to the
> end of OPTIONS_DEFINE.

Option knobs are sorted by default, so their position within OPTIONS_DEFINE
does not usually matter.

> > Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set
> > globally (e.g., OPTIONS_UNSET= NLS) and not per port.  As such, it can
> > reduce user annoyance if the dialog box is not shown for such options.

The problem, however, is that sometimes DOCS really mean "build the docs
with some <heavy-stuff>, ergo pull lots of extra bdeps" rather than "copy
few docs into $docsdir".  I usually prefer to see if the former starts to
happen to quickly hit ^C and disable [misused] DOCS option.  That said, in
general I think it's better to list DOCS et al. even if there're no other
options (that is, always).

Maybe it makes sense to introduce a knob to suppress dialog pop-up when
OPTIONS_DEFINE contains only things like IPV6, DOCS, EXAMPLES, and NLS.
It can be opt-in or opt-out, but at least every option would consistently
be listed in OPTIONS_DEFINE.  This is also good for various ports sanity
checks, for example -- less special hacks to introduce.

./danfe