From owner-freebsd-current@freebsd.org Wed Mar 2 17:26:30 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 738CBAC1BF3; Wed, 2 Mar 2016 17:26:30 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 550E71C96; Wed, 2 Mar 2016 17:26:30 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 68796B958; Wed, 2 Mar 2016 12:26:29 -0500 (EST) From: John Baldwin To: Howard Su Cc: Kurt Jaeger , freebsd-current@freebsd.org, freebsd-emulation@freebsd.org Subject: Re: SVN r296272 breaks virtualbox Date: Wed, 02 Mar 2016 09:01:34 -0800 Message-ID: <1918581.xCMVRkph0K@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: References: <56D617D1.5040209@protected-networks.net> <20160302062745.GD79128@home.opsec.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 02 Mar 2016 12:26:29 -0500 (EST) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 17:26:30 -0000 On Wednesday, March 02, 2016 07:06:26 AM Howard Su wrote: > On Tue, Mar 1, 2016 at 10:28 PM Kurt Jaeger wrote: > > > Hi! > > > > > > > The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: > > [...] > > > Then the port needs to be patched? It's been using an API deprecated > > > for the last 15 years. A simple > > s/taskqueue_enqueue_fast/taskqueue_enqueue/ > > > will fix it. > > > > A patch is possible if a new __FreeBSD_version is created for that > > API. Who can do that ? > > > There is no version pump and it is not needed. r296272 didn't have any > behavior change. binary compatible is kept as well. Actually, I broke binary compat in HEAD as 11.0 hasn't shipped yet and 11.0 won't be released for a while yet. In this case I think ripping the band-aid off is fine, especially since the replacement API has been ready for such a long time (and goes back to 7.0). -- John Baldwin