From owner-freebsd-scsi@FreeBSD.ORG Mon Sep 2 08:49:39 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D212FC1E; Mon, 2 Sep 2013 08:49:39 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bk0-x22b.google.com (mail-bk0-x22b.google.com [IPv6:2a00:1450:4008:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D14CA283A; Mon, 2 Sep 2013 08:49:38 +0000 (UTC) Received: by mail-bk0-f43.google.com with SMTP id mz13so1423112bkb.16 for ; Mon, 02 Sep 2013 01:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=2NdJTP8xy/tghqvhT0eqh0KJKUr9tGy7D+crGKM1GIY=; b=dKSlxcmStpiRbVyDOmmOlKsD6ruXFiUKuXOJqnBTxRrBK3pUDKyYHW0OncjxVyavQE ymt70Y5gpagtjMNX2k0bD8zdteYVASadji67T46/14NnA7LZjzBS1HJdWin8BKTnrZOv qANR7zVGc+q1uBxDGohlm5OAt2V5VMTuCEqZVuP5/CILpislCQwEvRmVT6ZwNsCbzgGh wSdA5WRfuSSVEJ+OL8DilROTVVxA9HZ8zqqrtGz74YoAx8d4Fo1U1WtUXPo3H6oi1dFP N7ImHW63gKhaOXr22ie4ttVcGxNDdNLhqO/aeHzbfss57P8SCzlU4IffaTOZjlEYaw7D eCtw== X-Received: by 10.204.199.132 with SMTP id es4mr623140bkb.28.1378111776996; Mon, 02 Sep 2013 01:49:36 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([37.229.21.195]) by mx.google.com with ESMTPSA id jt14sm1918024bkb.0.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Sep 2013 01:49:36 -0700 (PDT) Sender: Alexander Motin Message-ID: <5224511D.4090503@FreeBSD.org> Date: Mon, 02 Sep 2013 11:49:33 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130616 Thunderbird/17.0.6 MIME-Version: 1.0 To: FreeBSD SCSI , freebsd-hackers@FreeBSD.org, freebsd-geom@FreeBSD.org, "freebsd-current@freebsd.org" Subject: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking References: <520D4ADB.50209@FreeBSD.org> In-Reply-To: <520D4ADB.50209@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2013 08:49:39 -0000 Hi. I would like to invite more people to review and test my patches for improving CAM and GEOM scalability, that for last six months you could see developing in project/camlock SVN branch. Full diff of that branch against present head (r255131) can be found here: http://people.freebsd.org/~mav/camlock_patches/camlock_20130902.patch Heavy CAM changes there were focused on reducing scope of SIM lock to only protecting SIM internals, but not CAM core. That allows many times reduce lock congestion, especially on heavily parallel request submission with GEOM changes below. More detailed description of changes you could see here earlier: http://docs.freebsd.org/cgi/mid.cgi?520D4ADB.50209 GEOM changes were focused on avoiding switching to GEOM up/down threads in relatively simple setups where respective classes don't require it (and were explicitly marked so). That allows save on context switches and on systems with several HBAs and disks talk to them concurrently (that is where CAM locking changes are handy). Such classes were modified to support it: DEV, DISK, LABEL, MULTIPATH, NOP, PART, RAID (partially), STRIPE, ZERO, VFS, ZFS::VDEV, ZFS::ZVOL and some others. Requests to/from other classes will be queued to GEOM threads same as before. Together that allows to double block subsystem performance on high (at least 100-200K) IOPS benchmarks, allowing to reach up to a million total IOPS, while keeping full compatibility with all major ABIs/KBIs. Since we are already in 10.0 release process and changes are quite big, my plan is to wait and commit them to head branch after the freeze end, and then merge to stable/10. I hope the release process will go on schedule to not delay this work for another six months. This work is sponsored by iXsystems, Inc. -- Alexander Motin From owner-freebsd-scsi@FreeBSD.ORG Mon Sep 2 11:06:51 2013 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C107C14B for ; Mon, 2 Sep 2013 11:06:51 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AE6C223B6 for ; Mon, 2 Sep 2013 11:06:51 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r82B6pPT016156 for ; Mon, 2 Sep 2013 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r82B6pJr016154 for freebsd-scsi@FreeBSD.org; Mon, 2 Sep 2013 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 2 Sep 2013 11:06:51 GMT Message-Id: <201309021106.r82B6pJr016154@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-scsi@FreeBSD.org Subject: Current problem reports assigned to freebsd-scsi@FreeBSD.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2013 11:06:51 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/179932 scsi [ciss] ciss i/o stall problem with HP Bl Gen8 (and HP o kern/178795 scsi [mps] MSI for mps driver doesn't work under vmware o kern/165982 scsi [mpt] mpt instability, drive resets, and losses on Fre o kern/165740 scsi [cam] SCSI code must drain callbacks before free f kern/162256 scsi [mpt] QUEUE FULL EVENT and 'mpt_cam_event: 0x0' o docs/151336 scsi Missing documentation of scsi_ and ata_ functions in c o kern/148083 scsi [aac] Strange device reporting o kern/144648 scsi [aac] Strange values of speed and bus width in dmesg o kern/142351 scsi [mpt] LSILogic driver performance problems o kern/134488 scsi [mpt] MPT SCSI driver probes max. 8 LUNs per device o kern/130621 scsi [mpt] tranfer rate is inscrutable slow when use lsi213 f kern/129602 scsi [ahd] ahd(4) gets confused and wedges SCSI bus f kern/123674 scsi [ahc] ahc driver dumping o sparc/121676 scsi [iscsi] iscontrol do not connect iscsi-target on sparc 14 problems total. From owner-freebsd-scsi@FreeBSD.ORG Tue Sep 3 13:42:53 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A9170611; Tue, 3 Sep 2013 13:42:53 +0000 (UTC) (envelope-from jlh@FreeBSD.org) Received: from caravan.chchile.org (caravan.chchile.org [178.32.125.136]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6EB032D3C; Tue, 3 Sep 2013 13:42:53 +0000 (UTC) Received: by caravan.chchile.org (Postfix, from userid 1000) id 75F99C0761; Tue, 3 Sep 2013 13:42:51 +0000 (UTC) Date: Tue, 3 Sep 2013 15:42:51 +0200 From: Jeremie Le Hen To: Alexander Motin Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking Message-ID: <20130903134251.GB43281@caravan.chchile.org> Mail-Followup-To: Alexander Motin , FreeBSD SCSI , freebsd-hackers@FreeBSD.org, freebsd-geom@FreeBSD.org, "freebsd-current@freebsd.org" References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5224511D.4090503@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: FreeBSD SCSI , freebsd-geom@FreeBSD.org, "freebsd-current@freebsd.org" , freebsd-hackers@FreeBSD.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 13:42:53 -0000 On Mon, Sep 02, 2013 at 11:49:33AM +0300, Alexander Motin wrote: > Hi. > > I would like to invite more people to review and test my patches for > improving CAM and GEOM scalability, that for last six months you could > see developing in project/camlock SVN branch. Full diff of that branch > against present head (r255131) can be found here: > http://people.freebsd.org/~mav/camlock_patches/camlock_20130902.patch I'm building my kernel right now. -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons. From owner-freebsd-scsi@FreeBSD.ORG Tue Sep 3 18:10:34 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 86D92F92; Tue, 3 Sep 2013 18:10:34 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com [IPv6:2607:f8b0:400e:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4B33527EB; Tue, 3 Sep 2013 18:10:34 +0000 (UTC) Received: by mail-pa0-f46.google.com with SMTP id fa1so6747736pad.19 for ; Tue, 03 Sep 2013 11:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=U6aTzULoJOmotb6EDysMmZrEOn4yEnc/RZxCGfXH28Y=; b=EeqOVeGgn3Pye1lgfkID5C11E+cuH7lE6Qkben4dI6lros8b7PNodUfLnVLW8Sn7r/ j6JrNrE7i5WGzpCg5U/XT6lH4d6V3Dz3KQzjnOorjwqybRG7AF+FFnGiqxapJc/+vsZD fqx5WhzsYIluohp9r9EDVoaaiXnazTxdB9M9SaHdIVmklFFfWOKndwccxCn7km77HS1z dE6Nv6+v2HWKru+SiwPqLUiRHW4Rw52fkd6LSwq1mm14WJO0W4X65qupGSyTxBgx7FXB R8TDtPBlG0Ml/LH0d0kAEnImMzIYXoNnBaB558jbA8jYLefRSD5FkknLeljpdkld6ZY3 zTFg== MIME-Version: 1.0 X-Received: by 10.68.76.101 with SMTP id j5mr32863063pbw.67.1378231832471; Tue, 03 Sep 2013 11:10:32 -0700 (PDT) Received: by 10.66.126.141 with HTTP; Tue, 3 Sep 2013 11:10:32 -0700 (PDT) In-Reply-To: <20130903134251.GB43281@caravan.chchile.org> References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> Date: Tue, 3 Sep 2013 14:10:32 -0400 Message-ID: Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking From: Outback Dingo To: Alexander Motin , FreeBSD SCSI , freebsd-hackers@freebsd.org, freebsd-geom@freebsd.org, "freebsd-current@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 18:10:34 -0000 On Tue, Sep 3, 2013 at 9:42 AM, Jeremie Le Hen wrote: > On Mon, Sep 02, 2013 at 11:49:33AM +0300, Alexander Motin wrote: > > Hi. > > > > I would like to invite more people to review and test my patches for > > improving CAM and GEOM scalability, that for last six months you could > > see developing in project/camlock SVN branch. Full diff of that branch > > against present head (r255131) can be found here: > > http://people.freebsd.org/~mav/camlock_patches/camlock_20130902.patch > > I'm building my kernel right now. > > Can anyone confirm how well tested/stable this patch set might be?? if theres positive input i have a zoo of dev machines i could load it on, to help further it. Just checking to see how widely its been tested, > -- > Jeremie Le Hen > > Scientists say the world is made up of Protons, Neutrons and Electrons. > They forgot to mention Morons. > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > From owner-freebsd-scsi@FreeBSD.ORG Tue Sep 3 21:31:50 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4E646654; Tue, 3 Sep 2013 21:31:50 +0000 (UTC) (envelope-from jlh@FreeBSD.org) Received: from caravan.chchile.org (caravan.chchile.org [178.32.125.136]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 117E72BCE; Tue, 3 Sep 2013 21:31:50 +0000 (UTC) Received: by caravan.chchile.org (Postfix, from userid 1000) id DF286C0961; Tue, 3 Sep 2013 21:24:26 +0000 (UTC) Date: Tue, 3 Sep 2013 23:24:26 +0200 From: Jeremie Le Hen To: Outback Dingo Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking Message-ID: <20130903212426.GC43281@caravan.chchile.org> Mail-Followup-To: Outback Dingo , Alexander Motin , FreeBSD SCSI , freebsd-hackers@freebsd.org, freebsd-geom@freebsd.org, "freebsd-current@freebsd.org" References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: FreeBSD SCSI , Alexander Motin , freebsd-geom@freebsd.org, "freebsd-current@freebsd.org" , freebsd-hackers@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 21:31:50 -0000 On Tue, Sep 03, 2013 at 02:10:32PM -0400, Outback Dingo wrote: > On Tue, Sep 3, 2013 at 9:42 AM, Jeremie Le Hen wrote: > > > On Mon, Sep 02, 2013 at 11:49:33AM +0300, Alexander Motin wrote: > > > Hi. > > > > > > I would like to invite more people to review and test my patches for > > > improving CAM and GEOM scalability, that for last six months you could > > > see developing in project/camlock SVN branch. Full diff of that branch > > > against present head (r255131) can be found here: > > > http://people.freebsd.org/~mav/camlock_patches/camlock_20130902.patch > > > > I'm building my kernel right now. > > > > > Can anyone confirm how well tested/stable this patch set might be?? if > theres positive input i have a zoo of dev machines i could load it on, to > help further it. > Just checking to see how widely its been tested, Very stable so far. I'm doing a make -j 4 buildworld in parallel of a periodic security run. This has been running for hours without failure. -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons. From owner-freebsd-scsi@FreeBSD.ORG Tue Sep 3 21:48:59 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CF592D11; Tue, 3 Sep 2013 21:48:59 +0000 (UTC) (envelope-from cochard@gmail.com) Received: from mail-vc0-x22e.google.com (mail-vc0-x22e.google.com [IPv6:2607:f8b0:400c:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 429CF2CE8; Tue, 3 Sep 2013 21:48:59 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id gd11so4411172vcb.33 for ; Tue, 03 Sep 2013 14:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=CBjXK0KDjfW54LD0Yc8Pdr2jYxRu1lPETfc0cnr1Bmc=; b=FpG2g3+gqV/sAGRekCamqW+S4AgnWmAAHYsDfwV8PYuMp25Pc7l2Yj+j91pf0Su4uu IcIMAh5gvovMC46lw2aukJBCDj1MjgqvYC2GeSY6J41OtF+hYB7wkZSc8i9PDQsSNh6B fhRzJWFFp7LJnLLlPIinShJjc/G+61lF9CMUhK9JFnOuEhrFEL7SLmpWfV3yILsWC8JZ NwrbWss4RjzGjROVy8/XNbhPsnib7Omewe9X8HWyV4caAokWoo35QCqTo76g3swbhmxi 0lEMbkNMFQoiMzNlmN7qQdc9UFKTaDAe5CmeVHNtXsUpNP+dZKHzfhX9vZLFWJMHbGws Cp5Q== X-Received: by 10.220.199.5 with SMTP id eq5mr30028964vcb.16.1378244938366; Tue, 03 Sep 2013 14:48:58 -0700 (PDT) MIME-Version: 1.0 Sender: cochard@gmail.com Received: by 10.58.221.9 with HTTP; Tue, 3 Sep 2013 14:48:38 -0700 (PDT) In-Reply-To: References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> From: =?ISO-8859-1?Q?Olivier_Cochard=2DLabb=E9?= Date: Tue, 3 Sep 2013 23:48:38 +0200 X-Google-Sender-Auth: aEdoOoFc0E9sVrPag-3cJJNc85Q Message-ID: Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking To: Outback Dingo Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD SCSI , Alexander Motin , freebsd-geom@freebsd.org, "freebsd-current@freebsd.org" , freebsd-hackers@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 21:48:59 -0000 On Tue, Sep 3, 2013 at 8:10 PM, Outback Dingo wrot= e: > Can anyone confirm how well tested/stable this patch set might be?? if > theres positive input i have a zoo of dev machines i could load it on, to > help further it. > Just checking to see how widely its been tested, I've installed this patch on 3 differents machines there status after about 12hours: - SUN FIRE X4170 M2 (amd64: r255178) with 6 SAS harddrives in one big zraid (LSI MegaSAS Gen2 controller): Used for generating package with poudriere=85 no probleme since; - HAL/Fujitsu SPARC64-V (sparc64: r255178) with two SCSI-3 disks in gmirror: Used for generating package with poudriere too=85 no probleme since; - HP EliteBook 8460p (amd64: r255188) with DVD replaced by a second hardrive (where fbsd is installed): It crash just after the message "GEOM: new disk ada1" during boot screenshot of the crash screen: http://goo.gl/tW1VIx A little more information: addr2line -e /boot/kernel/kernel.symbols 0xffffffff8083abd3 /usr/src/sys/geom/geom_io.c:129 Regards, Olivier From owner-freebsd-scsi@FreeBSD.ORG Tue Sep 3 21:52:30 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 821) id 5A8E4199; Tue, 3 Sep 2013 21:52:30 +0000 (UTC) Date: Tue, 3 Sep 2013 21:52:30 +0000 From: John To: FreeBSD SCSI Subject: Newer Qlogic FC card support? Message-ID: <20130903215230.GA5830@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 21:52:30 -0000 Hi Folks, I've been running ZFS systems for a while now exporting volumes via iSCSI and NFS. Recently I was asked to look into FC. I have a couple of older 2532 cards to do a prototype with, but need to support something a bit newer. I was wondering if anyone had any idea if newer cards would need much work to support? Above and beyond that, does anyone have any ideas if 16G support might be on the horizon somewhere? I've been scouring the lists and think I understand how to use the new CTL interface. If anyone would like to offer up any words of wisdom it would be appreciated! Cheers, John From owner-freebsd-scsi@FreeBSD.ORG Tue Sep 3 23:59:30 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6624FFB0; Tue, 3 Sep 2013 23:59:30 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from virtual.feral.com (virtual.feral.com [216.224.170.83]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2C93D26D8; Tue, 3 Sep 2013 23:59:29 +0000 (UTC) Received: from spea.in1.lcl (lowell.feral.com [76.14.48.84]) by virtual.feral.com (8.14.4/8.14.4) with ESMTP id r83NwHkR000313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Sep 2013 16:58:28 -0700 Received: from spea.in1.lcl (localhost [127.0.0.1]) by spea.in1.lcl (8.14.4/8.14.4) with ESMTP id r83NwHJj030216; Tue, 3 Sep 2013 16:58:17 -0700 Received: from localhost (mjacob@localhost) by spea.in1.lcl (8.14.4/8.14.4/Submit) with ESMTP id r83NwGnH030212; Tue, 3 Sep 2013 16:58:17 -0700 Date: Tue, 3 Sep 2013 16:58:16 -0700 (PDT) From: Matthew Jacob To: John Subject: Re: Newer Qlogic FC card support? In-Reply-To: <20130903215230.GA5830@FreeBSD.org> Message-ID: References: <20130903215230.GA5830@FreeBSD.org> User-Agent: Alpine 2.03 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (virtual.feral.com [216.224.170.83]); Tue, 03 Sep 2013 16:58:28 -0700 (PDT) Cc: FreeBSD SCSI X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: mjacob@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 23:59:30 -0000 On Tue, 3 Sep 2013, John wrote: > > Hi Folks, > > I've been running ZFS systems for a while now exporting > volumes via iSCSI and NFS. Recently I was asked to look into > FC. I have a couple of older 2532 cards to do a prototype with, > but need to support something a bit newer. I was wondering if > anyone had any idea if newer cards would need much work to > support? Above and beyond that, does anyone have any ideas > if 16G support might be on the horizon somewhere? > > I've been scouring the lists and think I understand how > to use the new CTL interface. If anyone would like to offer > up any words of wisdom it would be appreciated! The 25XX cards are the latest supported. I have manuals for the newer cards (that I can't release) but no hardware. From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 00:31:57 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8F70EAC0; Wed, 4 Sep 2013 00:31:57 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-oa0-x235.google.com (mail-oa0-x235.google.com [IPv6:2607:f8b0:4003:c02::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 21888294D; Wed, 4 Sep 2013 00:31:57 +0000 (UTC) Received: by mail-oa0-f53.google.com with SMTP id k18so7551333oag.40 for ; Tue, 03 Sep 2013 17:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=TId/rHSlvsa6OMpmrl6Hypdr+azDGQF6VQU75p4pbAo=; b=N9O4AbJbWm2zaYqkUExEK3TP0U5H2bZNKkcXKTW8ovzbRua0M90ILPnYT2RXTRSSrP zgIeARpfG96nx5/c0ngFPNngf7WinJkrThKkPi8d58Wzs0x+jIdUBmxEQ4nrzeZrRvvf UKnXqv/PydLKWaj7jUNpIvwIBumxj05SixTVz4+0yfPVJvret7XoojZvWbTw5Fs5llVf d696ivBUI6xN4pUpTRbc0gZzMQV/iFFm2WA4RrG5A7hbJ1EnmcHd1xHpFAGnQtXm8OOR hvTefxsIdmH4X5TeIcsNFZFUWWJIhYxRrmIFF3HooL2uwbJKEVpzdtk1ShdE90zlWzI/ sNrA== MIME-Version: 1.0 X-Received: by 10.60.52.244 with SMTP id w20mr128413oeo.30.1378254716439; Tue, 03 Sep 2013 17:31:56 -0700 (PDT) Received: by 10.76.114.227 with HTTP; Tue, 3 Sep 2013 17:31:56 -0700 (PDT) In-Reply-To: References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> Date: Tue, 3 Sep 2013 20:31:56 -0400 Message-ID: Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking From: Outback Dingo To: =?ISO-8859-1?Q?Olivier_Cochard=2DLabb=E9?= Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: FreeBSD SCSI , Alexander Motin , freebsd-geom@freebsd.org, "freebsd-current@freebsd.org" , freebsd-hackers@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 00:31:57 -0000 On Tue, Sep 3, 2013 at 5:48 PM, Olivier Cochard-Labb=E9 wrote: > On Tue, Sep 3, 2013 at 8:10 PM, Outback Dingo > wrote: > > Can anyone confirm how well tested/stable this patch set might be?? if > > theres positive input i have a zoo of dev machines i could load it on, = to > > help further it. > > Just checking to see how widely its been tested, > > I've installed this patch on 3 differents machines there status after > about 12hours: > - SUN FIRE X4170 M2 (amd64: r255178) with 6 SAS harddrives in one big > zraid (LSI MegaSAS Gen2 controller): Used for generating package with > poudriere=85 no probleme since; > - HAL/Fujitsu SPARC64-V (sparc64: r255178) with two SCSI-3 disks in > gmirror: Used for generating package with poudriere too=85 no probleme > since; > - HP EliteBook 8460p (amd64: r255188) with DVD replaced by a second > hardrive (where fbsd is installed): It crash just after the message > "GEOM: new disk ada1" during boot > > screenshot of the crash screen: > http://goo.gl/tW1VIx > > A little more information: > addr2line -e /boot/kernel/kernel.symbols 0xffffffff8083abd3 > /usr/src/sys/geom/geom_io.c:129 > > Regards, > > Olivier > Be nice if it was backported to 9/stable..... not sure how feasible it is though... patch fails in a few places..... From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 05:24:49 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0A1FEFC1; Wed, 4 Sep 2013 05:24:49 +0000 (UTC) (envelope-from jlh@FreeBSD.org) Received: from caravan.chchile.org (caravan.chchile.org [178.32.125.136]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C33F32E6C; Wed, 4 Sep 2013 05:24:48 +0000 (UTC) Received: by caravan.chchile.org (Postfix, from userid 1000) id EAEB2C0A95; Wed, 4 Sep 2013 05:24:46 +0000 (UTC) Date: Wed, 4 Sep 2013 07:24:46 +0200 From: Jeremie Le Hen To: Outback Dingo , Alexander Motin , FreeBSD SCSI , freebsd-hackers@freebsd.org, freebsd-geom@freebsd.org, "freebsd-current@freebsd.org" Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking Message-ID: <20130904052446.GD43281@caravan.chchile.org> Mail-Followup-To: Outback Dingo , Alexander Motin , FreeBSD SCSI , freebsd-hackers@freebsd.org, freebsd-geom@freebsd.org, "freebsd-current@freebsd.org" References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> <20130903212426.GC43281@caravan.chchile.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130903212426.GC43281@caravan.chchile.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 05:24:49 -0000 On Tue, Sep 03, 2013 at 11:24:26PM +0200, Jeremie Le Hen wrote: > On Tue, Sep 03, 2013 at 02:10:32PM -0400, Outback Dingo wrote: > > On Tue, Sep 3, 2013 at 9:42 AM, Jeremie Le Hen wrote: > > > > > On Mon, Sep 02, 2013 at 11:49:33AM +0300, Alexander Motin wrote: > > > > Hi. > > > > > > > > I would like to invite more people to review and test my patches for > > > > improving CAM and GEOM scalability, that for last six months you could > > > > see developing in project/camlock SVN branch. Full diff of that branch > > > > against present head (r255131) can be found here: > > > > http://people.freebsd.org/~mav/camlock_patches/camlock_20130902.patch > > > > > > I'm building my kernel right now. > > > > > > > > Can anyone confirm how well tested/stable this patch set might be?? if > > theres positive input i have a zoo of dev machines i could load it on, to > > help further it. > > Just checking to see how widely its been tested, > > Very stable so far. I'm doing a make -j 4 buildworld in parallel of a > periodic security run. This has been running for hours without failure. FWIW, I have 4 drives total, distributed in 2 zpool containing 2 mirrored zdev each. -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons. From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 07:01:10 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8FFDD7C1; Wed, 4 Sep 2013 07:01:10 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-wg0-x233.google.com (mail-wg0-x233.google.com [IPv6:2a00:1450:400c:c00::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9DA8C28C1; Wed, 4 Sep 2013 07:01:09 +0000 (UTC) Received: by mail-wg0-f51.google.com with SMTP id a12so2264428wgh.18 for ; Wed, 04 Sep 2013 00:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=qQcQ3lQg5yW+MrAD8YAtILdaaJNlfmGx3bzF9F7m8w4=; b=q8BByWIwrdXM0K8ttL7/CYbzTbXgtwpUKxUd5p0FbZVX2X9XpDwckinfdQuHvyrBUY nRy6UzUA1z/Zcr4TamS6QIfLFesAEaP2U4PhFAXGEBSAZovv++c+xBCE9aXc/ItIjdcg /0vhg42kSaV0JcI7uY1boJ8qr0hL8jyc7+gn3J8SaLGwgzP70UagttzyHZ7iPe9EGmRi PHG8OioZTgzu7P/TZA4Y/yKO7AAtgZyGP9s9ZU4wOAmww5/6AD/twLjYA+Bb7TlMi4mk Qfg8zOuneoPIQrJQoT7BsOpaJ4h4zEdJCmGmbwTr+lHJF569lSfAvRBY36ifozGjD7zy h2nw== X-Received: by 10.180.75.16 with SMTP id y16mr767253wiv.59.1378278067954; Wed, 04 Sep 2013 00:01:07 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([37.229.21.195]) by mx.google.com with ESMTPSA id mw9sm1595508wic.4.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Sep 2013 00:01:06 -0700 (PDT) Sender: Alexander Motin Message-ID: <5226DAB0.1060303@FreeBSD.org> Date: Wed, 04 Sep 2013 10:01:04 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130616 Thunderbird/17.0.6 MIME-Version: 1.0 To: =?windows-1252?Q?Olivier_Cochard-Labb=E9?= Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: Outback Dingo , freebsd-geom@freebsd.org, "freebsd-current@freebsd.org" , freebsd-hackers@freebsd.org, FreeBSD SCSI X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 07:01:10 -0000 On 04.09.2013 00:48, Olivier Cochard-Labbé wrote: > On Tue, Sep 3, 2013 at 8:10 PM, Outback Dingo wrote: >> Can anyone confirm how well tested/stable this patch set might be?? if >> theres positive input i have a zoo of dev machines i could load it on, to >> help further it. >> Just checking to see how widely its been tested, > > I've installed this patch on 3 differents machines there status after > about 12hours: > - SUN FIRE X4170 M2 (amd64: r255178) with 6 SAS harddrives in one big > zraid (LSI MegaSAS Gen2 controller): Used for generating package with > poudriere… no probleme since; > - HAL/Fujitsu SPARC64-V (sparc64: r255178) with two SCSI-3 disks in > gmirror: Used for generating package with poudriere too… no probleme > since; I've forgot to mention, but GEOM direct dispatch is now active only on x86 because GET_STACK_USAGE macro now defined only there and I wanted to stay on a safe side. On other archs GEOM works in old queued way. Somebody should port that small macro to other archs. But that is still interesting data point. Thanks. > - HP EliteBook 8460p (amd64: r255188) with DVD replaced by a second > hardrive (where fbsd is installed): It crash just after the message > "GEOM: new disk ada1" during boot > > screenshot of the crash screen: > http://goo.gl/tW1VIx > > A little more information: > addr2line -e /boot/kernel/kernel.symbols 0xffffffff8083abd3 > /usr/src/sys/geom/geom_io.c:129 Unfortunately I can't reproduce that and have not enough clues. It may be specific to some GEOM class. Could you describe/show all GEOM topology, file systems, etc. you have there? gpart show sysctl kern.geom.confxml ... Thank you! -- Alexander Motin From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 12:45:46 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9B0D06B2; Wed, 4 Sep 2013 12:45:46 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtpauth4.wiscmail.wisc.edu (wmauth4.doit.wisc.edu [144.92.197.145]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6CD8D2023; Wed, 4 Sep 2013 12:45:46 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=windows-1252; format=flowed Received: from avs-daemon.smtpauth4.wiscmail.wisc.edu by smtpauth4.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MSL00100PMPTB00@smtpauth4.wiscmail.wisc.edu>; Wed, 04 Sep 2013 07:45:38 -0500 (CDT) X-Spam-PmxInfo: Server=avs-4, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.4.123619, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from comporellon.tachypleus.net (adsl-76-208-67-185.dsl.mdsnwi.sbcglobal.net [76.208.67.185]) by smtpauth4.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MSL0024HQ41OI20@smtpauth4.wiscmail.wisc.edu>; Wed, 04 Sep 2013 07:45:38 -0500 (CDT) Message-id: <52272B6F.9060308@freebsd.org> Date: Wed, 04 Sep 2013 07:45:35 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130810 Thunderbird/17.0.8 To: Alexander Motin Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> <5226DAB0.1060303@FreeBSD.org> In-reply-to: <5226DAB0.1060303@FreeBSD.org> Cc: freebsd-geom@freebsd.org, freebsd-hackers@freebsd.org, "freebsd-current@freebsd.org" , FreeBSD SCSI , =?windows-1252?Q?Olivier_Cochard-Labb=E9?= , Outback Dingo X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 12:45:46 -0000 On 09/04/13 02:01, Alexander Motin wrote: > On 04.09.2013 00:48, Olivier Cochard-Labbé wrote: >> On Tue, Sep 3, 2013 at 8:10 PM, Outback Dingo >> wrote: >>> Can anyone confirm how well tested/stable this patch set might be?? if >>> theres positive input i have a zoo of dev machines i could load it >>> on, to >>> help further it. >>> Just checking to see how widely its been tested, >> >> I've installed this patch on 3 differents machines there status after >> about 12hours: >> - SUN FIRE X4170 M2 (amd64: r255178) with 6 SAS harddrives in one big >> zraid (LSI MegaSAS Gen2 controller): Used for generating package with >> poudriere… no probleme since; >> - HAL/Fujitsu SPARC64-V (sparc64: r255178) with two SCSI-3 disks in >> gmirror: Used for generating package with poudriere too… no probleme >> since; > > I've forgot to mention, but GEOM direct dispatch is now active only on > x86 because GET_STACK_USAGE macro now defined only there and I wanted > to stay on a safe side. On other archs GEOM works in old queued way. > Somebody should port that small macro to other archs. But that is > still interesting data point. Thanks. Could you describe what this macro is supposed to do so that we can do the porting work? -Nathan From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 13:20:43 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DB979543; Wed, 4 Sep 2013 13:20:43 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-oa0-x230.google.com (mail-oa0-x230.google.com [IPv6:2607:f8b0:4003:c02::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 63677232C; Wed, 4 Sep 2013 13:20:43 +0000 (UTC) Received: by mail-oa0-f48.google.com with SMTP id o17so336172oag.7 for ; Wed, 04 Sep 2013 06:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=uHQmwWU2MeBmE/1UIl47yFWFen4/AkTbDSQbsQhd/98=; b=enzMJG+Q9dZrdLHyb1h7LtN5bwcG03+y9VX9vqViqefI8Xfn4TWYmYwfAcF+qlPajc aRSfaiptbvyhvaBXy13j6fU3S8qgkA1ZiASZo8QW9xy1vfyntiguHgwsrg1rVQwoWZg0 jB94flQsMzViMSro/7HDhKwJZLEZvUQQfS/9sYmYkhxI5jZGBXOa4BQKDzWES1QGbwpf Oizz1P9WubWSrm92QtGsBkWB+HM2QdrYZQ75nCe/9u5j22q8bnkt57oAlQVtK5DjVh3h jOLiw/gTkx0IcWI8U/NIR79vbuBXa3nQiFrHMZU7uPRKg/gaSpIggGd7i6mi5HduGSY6 /2AQ== MIME-Version: 1.0 X-Received: by 10.182.73.136 with SMTP id l8mr2102864obv.53.1378300842725; Wed, 04 Sep 2013 06:20:42 -0700 (PDT) Received: by 10.76.68.38 with HTTP; Wed, 4 Sep 2013 06:20:42 -0700 (PDT) In-Reply-To: <52272B6F.9060308@freebsd.org> References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> <5226DAB0.1060303@FreeBSD.org> <52272B6F.9060308@freebsd.org> Date: Wed, 4 Sep 2013 09:20:42 -0400 Message-ID: Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking From: Ryan Stone To: Nathan Whitehorn Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-geom@freebsd.org, "freebsd-hackers@freebsd.org" , Alexander Motin , "freebsd-current@freebsd.org" , Outback Dingo , =?ISO-8859-1?Q?Olivier_Cochard=2DLabb=E9?= , FreeBSD SCSI X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 13:20:44 -0000 On Wed, Sep 4, 2013 at 8:45 AM, Nathan Whitehorn wrote: > Could you describe what this macro is supposed to do so that we can do the > porting work? > -Nathan #define GET_STACK_USAGE(total, used) GET_STACK_USAGE sets the variable passed in total to the total amount of stack space available to the current thread. used is set to the amount of stack space currently used (this does not have to have byte-precision). Netgraph uses this to decide when to stop recursing and instead defer to a work queue (to prevent stack overflow). I presume that Alexander is using it in a similar way. It looks like the amd64 version could be ported to other architectures quite easily if you were to account for stacks that grow up and stacks that grow down: http://svnweb.freebsd.org/base/head/sys/amd64/include/proc.h?revision=233291&view=markup /* Get the current kernel thread stack usage. */ #define GET_STACK_USAGE(total, used) do { \ struct thread *td = curthread; \ (total) = td->td_kstack_pages * PAGE_SIZE; \ (used) = (char *)td->td_kstack + \ td->td_kstack_pages * PAGE_SIZE - \ (char *)&td; \ } while (0) From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 13:29:36 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5C9FFA0B; Wed, 4 Sep 2013 13:29:36 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bk0-x236.google.com (mail-bk0-x236.google.com [IPv6:2a00:1450:4008:c01::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 311752412; Wed, 4 Sep 2013 13:29:34 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id mz12so167341bkb.41 for ; Wed, 04 Sep 2013 06:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=KjWIzi+zzjy5EixOq84YnmeCwO5/zYJUl+xwaZAS7cg=; b=0wsCwn3GAC/ztaUAyTioLu8wt7jKdQkNpoOBKxI/fIxljCYeuc8fS7HSV/3AfYAiSJ nkcBy+X5TCHq8Qx4Vd8y2f/UGyUu5GXtOpu6H++c/hhoqnd3ulD1V0kyCFTFJu+o27mK CKfHvsuCNeUapbd/ry9rs829ItCJMdu3jUQrvq9dpbCZCfr79CRp+JXHrFM5Cz4TPYpI yqqtOFs51qPuwJ//NLlz8gF6D6xDhu6m1jeUfet2chJUAoTEUa7EZlfuL1zAmTTspHLo us5pLyZb6qWMBdEBR42rmbqV51Bw58/dJh40ko038vjbqhznKhY3yKY9pt2W9HRvmJJU 1Wqg== X-Received: by 10.205.22.71 with SMTP id qv7mr2518681bkb.20.1378301373128; Wed, 04 Sep 2013 06:29:33 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([37.229.21.195]) by mx.google.com with ESMTPSA id 14sm6560105bkl.17.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Sep 2013 06:29:32 -0700 (PDT) Sender: Alexander Motin Message-ID: <522735B9.1070403@FreeBSD.org> Date: Wed, 04 Sep 2013 16:29:29 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130616 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Whitehorn Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> <5226DAB0.1060303@FreeBSD.org> <52272B6F.9060308@freebsd.org> In-Reply-To: <52272B6F.9060308@freebsd.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-geom@freebsd.org, freebsd-hackers@freebsd.org, "freebsd-current@freebsd.org" , FreeBSD SCSI , =?windows-1252?Q?Olivier_Cochard-Labb=E9?= , Outback Dingo X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 13:29:36 -0000 On 04.09.2013 15:45, Nathan Whitehorn wrote: > On 09/04/13 02:01, Alexander Motin wrote: >> On 04.09.2013 00:48, Olivier Cochard-Labbé wrote: >>> On Tue, Sep 3, 2013 at 8:10 PM, Outback Dingo >>> wrote: >>>> Can anyone confirm how well tested/stable this patch set might be?? if >>>> theres positive input i have a zoo of dev machines i could load it >>>> on, to >>>> help further it. >>>> Just checking to see how widely its been tested, >>> >>> I've installed this patch on 3 differents machines there status after >>> about 12hours: >>> - SUN FIRE X4170 M2 (amd64: r255178) with 6 SAS harddrives in one big >>> zraid (LSI MegaSAS Gen2 controller): Used for generating package with >>> poudriere… no probleme since; >>> - HAL/Fujitsu SPARC64-V (sparc64: r255178) with two SCSI-3 disks in >>> gmirror: Used for generating package with poudriere too… no probleme >>> since; >> >> I've forgot to mention, but GEOM direct dispatch is now active only on >> x86 because GET_STACK_USAGE macro now defined only there and I wanted >> to stay on a safe side. On other archs GEOM works in old queued way. >> Somebody should port that small macro to other archs. But that is >> still interesting data point. Thanks. > > Could you describe what this macro is supposed to do so that we can do > the porting work? It supposed to report total and used stack sizes for current thread. I suppose that it will be equal for the most archs, but better somebody familiar with each one looked on it. The macro itself is not new. It is for years used in Netgraph for equivalent purpose. -- Alexander Motin From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 14:34:09 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 23331F09; Wed, 4 Sep 2013 14:34:09 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119]) by mx1.freebsd.org (Postfix) with ESMTP id D9331284D; Wed, 4 Sep 2013 14:34:08 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 50CBE5838C; Wed, 4 Sep 2013 09:11:29 -0500 (CDT) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from mail.icecube.wisc.edu ([127.0.0.1]) by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id F6OyxvU8mfj5; Wed, 4 Sep 2013 09:11:29 -0500 (CDT) Received: from terminus.icecube.wisc.edu (terminus.icecube.wisc.edu [172.16.223.97]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 3115758388; Wed, 4 Sep 2013 09:11:29 -0500 (CDT) Message-ID: <52273F90.7020303@freebsd.org> Date: Wed, 04 Sep 2013 09:11:28 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130809 Thunderbird/17.0.8 MIME-Version: 1.0 To: Ryan Stone Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking References: <520D4ADB.50209@FreeBSD.org> <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> <5226DAB0.1060303@FreeBSD.org> <52272B6F.9060308@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-geom@freebsd.org, "freebsd-hackers@freebsd.org" , Alexander Motin , "freebsd-current@freebsd.org" , FreeBSD SCSI , =?ISO-8859-1?Q?Olivier_Cochard?= =?ISO-8859-1?Q?-Labb=E9?= , Outback Dingo X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 14:34:09 -0000 On 09/04/13 08:20, Ryan Stone wrote: > On Wed, Sep 4, 2013 at 8:45 AM, Nathan Whitehorn wrote: >> Could you describe what this macro is supposed to do so that we can do the >> porting work? >> -Nathan > #define GET_STACK_USAGE(total, used) > > GET_STACK_USAGE sets the variable passed in total to the total amount > of stack space available to the current thread. used is set to the > amount of stack space currently used (this does not have to have > byte-precision). Netgraph uses this to decide when to stop recursing > and instead defer to a work queue (to prevent stack overflow). I > presume that Alexander is using it in a similar way. It looks like > the amd64 version could be ported to other architectures quite easily > if you were to account for stacks that grow up and stacks that grow > down: > > http://svnweb.freebsd.org/base/head/sys/amd64/include/proc.h?revision=233291&view=markup > > /* Get the current kernel thread stack usage. */ > #define GET_STACK_USAGE(total, used) do { \ > struct thread *td = curthread; \ > (total) = td->td_kstack_pages * PAGE_SIZE; \ > (used) = (char *)td->td_kstack + \ > td->td_kstack_pages * PAGE_SIZE - \ > (char *)&td; \ > } while (0) > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" I think that should be MI for us anyway. I'm not aware of any architectures FreeBSD supports with stacks that grow up. I'll give it a test on PPC. -Nathan From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 16:07:51 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2BC56248; Wed, 4 Sep 2013 16:07:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EA3DA2E7C; Wed, 4 Sep 2013 16:07:50 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 99108B941; Wed, 4 Sep 2013 12:07:49 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking Date: Wed, 4 Sep 2013 12:00:55 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p28; KDE/4.5.5; amd64; ; ) References: <520D4ADB.50209@FreeBSD.org> <52273F90.7020303@freebsd.org> In-Reply-To: <52273F90.7020303@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201309041200.56024.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 04 Sep 2013 12:07:49 -0400 (EDT) Cc: freebsd-geom@freebsd.org, "freebsd-hackers@freebsd.org" , Alexander Motin , Nathan Whitehorn , Outback Dingo , Olivier =?iso-8859-1?q?Cochard-Labb=E9?= , FreeBSD SCSI X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 16:07:51 -0000 On Wednesday, September 04, 2013 10:11:28 am Nathan Whitehorn wrote: > On 09/04/13 08:20, Ryan Stone wrote: > > On Wed, Sep 4, 2013 at 8:45 AM, Nathan Whitehorn wrote: > >> Could you describe what this macro is supposed to do so that we can do the > >> porting work? > >> -Nathan > > #define GET_STACK_USAGE(total, used) > > > > GET_STACK_USAGE sets the variable passed in total to the total amount > > of stack space available to the current thread. used is set to the > > amount of stack space currently used (this does not have to have > > byte-precision). Netgraph uses this to decide when to stop recursing > > and instead defer to a work queue (to prevent stack overflow). I > > presume that Alexander is using it in a similar way. It looks like > > the amd64 version could be ported to other architectures quite easily > > if you were to account for stacks that grow up and stacks that grow > > down: > > > > http://svnweb.freebsd.org/base/head/sys/amd64/include/proc.h?revision=233291&view=markup > > > > /* Get the current kernel thread stack usage. */ > > #define GET_STACK_USAGE(total, used) do { \ > > struct thread *td = curthread; \ > > (total) = td->td_kstack_pages * PAGE_SIZE; \ > > (used) = (char *)td->td_kstack + \ > > td->td_kstack_pages * PAGE_SIZE - \ > > (char *)&td; \ > > } while (0) > > _______________________________________________ > > freebsd-hackers@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" > > I think that should be MI for us anyway. I'm not aware of any > architectures FreeBSD supports with stacks that grow up. I'll give it a > test on PPC. ia64 has the double stack thingie where the register stack spills into a stack that grows up rather than down. Not sure how sparc64 window spills are handled either. -- John Baldwin From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 18:29:58 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 06137B00 for ; Wed, 4 Sep 2013 18:29:58 +0000 (UTC) (envelope-from mathieu.sim@gmail.com) Received: from mail-la0-x229.google.com (mail-la0-x229.google.com [IPv6:2a00:1450:4010:c03::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8149A2A80 for ; Wed, 4 Sep 2013 18:29:57 +0000 (UTC) Received: by mail-la0-f41.google.com with SMTP id ec20so668442lab.14 for ; Wed, 04 Sep 2013 11:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=dllIpwPTXsp5/66Rfj+/mRFZwjNpnbtfNW/abmVg1zU=; b=Xrsw2RvLYy/LrCsqLL/8XCK4WMnrI3Vbork0SqOE1OkOij29pWu91quahiNKbm1mEU abLqCH8sxFvkWuGB5A+1SFzg9xwSM7+XGCeeoShUC3fC9/XokIblhMVruchJ3UCxAXMv rg2aQWorRjcVM2rS8JmJqsmoBEduL3f67W3cMbMb2sISPJA3BO5wv31xxUSrC/B6HddT 6mBy0VWKj97Eh3O/QB6okylqQLPo7i9soK9qLTJmC7FiSJjrSH3jzXbUGnnF0g0m00FP U92eBB37ctsU3+msK5S26SIHTQjFIFPa0jFBNxQevbTPSvw/h8/+OOOjtJzIzRDkCxKc UkNw== MIME-Version: 1.0 X-Received: by 10.112.158.225 with SMTP id wx1mr2777170lbb.37.1378319395430; Wed, 04 Sep 2013 11:29:55 -0700 (PDT) Received: by 10.114.12.9 with HTTP; Wed, 4 Sep 2013 11:29:55 -0700 (PDT) In-Reply-To: References: <20130903215230.GA5830@FreeBSD.org> Date: Wed, 4 Sep 2013 20:29:55 +0200 Message-ID: Subject: Re: Newer Qlogic FC card support? From: Mathieu Simon To: FreeBSD SCSI Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 18:29:58 -0000 G'day 2013/9/4 Matthew Jacob > > > The 25XX cards are the latest supported. I have manuals for the newer > cards (that I can't release) but no hardware. Turning the question the other way round (and possibly asking stupid dumb question): If you had access to hardware (and time etc.) then it could be possible to see support for QLE26xx (16G FC HBA) or QLE83x (10G CNA)? -- Mathieu (now sent to the list) From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 18:48:47 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 057BC4FA for ; Wed, 4 Sep 2013 18:48:47 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from virtual.feral.com (virtual.feral.com [216.224.170.83]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9FD4A2BCB for ; Wed, 4 Sep 2013 18:48:46 +0000 (UTC) Received: from spea.in1.lcl (lowell.feral.com [76.14.48.84]) by virtual.feral.com (8.14.4/8.14.4) with ESMTP id r84IlYr7006746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 Sep 2013 11:47:45 -0700 Received: from spea.in1.lcl (localhost [127.0.0.1]) by spea.in1.lcl (8.14.4/8.14.4) with ESMTP id r84IlYko002258; Wed, 4 Sep 2013 11:47:34 -0700 Received: from localhost (mjacob@localhost) by spea.in1.lcl (8.14.4/8.14.4/Submit) with ESMTP id r84IlYC0002254; Wed, 4 Sep 2013 11:47:34 -0700 Date: Wed, 4 Sep 2013 11:47:33 -0700 (PDT) From: Matthew Jacob To: Mathieu Simon Subject: Re: Newer Qlogic FC card support? In-Reply-To: Message-ID: References: <20130903215230.GA5830@FreeBSD.org> User-Agent: Alpine 2.03 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (virtual.feral.com [216.224.170.83]); Wed, 04 Sep 2013 11:47:45 -0700 (PDT) Cc: FreeBSD SCSI X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: mjacob@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 18:48:47 -0000 > > 2013/9/4 Matthew Jacob >> >> >> The 25XX cards are the latest supported. I have manuals for the newer >> cards (that I can't release) but no hardware. > > > Turning the question the other way round (and possibly asking stupid dumb > question): > > If you had access to hardware (and time etc.) then it could be possible to > see support for > QLE26xx (16G FC HBA) or QLE83x (10G CNA)? > Part of me says "Sure! That'd be great!". Part of me says I'm deathly tired of isp and Fibre Channel in general, and also of FreeBSD. The isp driver is long overdue for a rewrite to trim out cards that mostly are don't cares at this point. FreeBSD could use first class FC support as well. The ideal situation, possibly, would be to get the vendor interested in actually supporting the h/w by having a real engineer be a committer (much like Jack Vogel is for Intel NICs). I doubt that will happen any time soon. There's just a *bare* possibility that my current paying gig will have me work on QLogic CNA cards. That might get me an excuse to spend time on FreeBSD, but probably not with actual h/w (they have like *two* cards and it's a 2nd order project for them in support of their main h/w). If anyone in reading range of this email gets all hot and excited about adding CNA support to isp, or do a newer driver, please speak up! If nobody speaks up in the next couple of days, anyone who has h/w to loan please contact me off list. I don't have anything faster than a 4GiB switch, but I *do* have a couple of 16GiB Emulex cards so I could at least do point-to-point testing there. From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 4 21:30:01 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6C004C61; Wed, 4 Sep 2013 21:30:01 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119]) by mx1.freebsd.org (Postfix) with ESMTP id 304392742; Wed, 4 Sep 2013 21:30:00 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.icecube.wisc.edu (Postfix) with ESMTP id D4DB958385; Wed, 4 Sep 2013 16:29:59 -0500 (CDT) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from mail.icecube.wisc.edu ([127.0.0.1]) by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id C7+Tce5PvWx0; Wed, 4 Sep 2013 16:29:59 -0500 (CDT) Received: from terminus.icecube.wisc.edu (terminus.icecube.wisc.edu [172.16.223.97]) by mail.icecube.wisc.edu (Postfix) with ESMTP id A953E58384; Wed, 4 Sep 2013 16:29:59 -0500 (CDT) Message-ID: <5227A657.4010701@freebsd.org> Date: Wed, 04 Sep 2013 16:29:59 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130809 Thunderbird/17.0.8 MIME-Version: 1.0 To: John Baldwin Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking References: <520D4ADB.50209@FreeBSD.org> <52273F90.7020303@freebsd.org> <201309041200.56024.jhb@freebsd.org> In-Reply-To: <201309041200.56024.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-geom@freebsd.org, "freebsd-hackers@freebsd.org" , Alexander Motin , freebsd-current@freebsd.org, Outback Dingo , =?ISO-8859-1?Q?Olivier_Cochard-Labb=E9?= , FreeBSD SCSI X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 21:30:01 -0000 On 09/04/13 11:00, John Baldwin wrote: > On Wednesday, September 04, 2013 10:11:28 am Nathan Whitehorn wrote: >> On 09/04/13 08:20, Ryan Stone wrote: >>> On Wed, Sep 4, 2013 at 8:45 AM, Nathan Whitehorn > wrote: >>>> Could you describe what this macro is supposed to do so that we can do > the >>>> porting work? >>>> -Nathan >>> #define GET_STACK_USAGE(total, used) >>> >>> GET_STACK_USAGE sets the variable passed in total to the total amount >>> of stack space available to the current thread. used is set to the >>> amount of stack space currently used (this does not have to have >>> byte-precision). Netgraph uses this to decide when to stop recursing >>> and instead defer to a work queue (to prevent stack overflow). I >>> presume that Alexander is using it in a similar way. It looks like >>> the amd64 version could be ported to other architectures quite easily >>> if you were to account for stacks that grow up and stacks that grow >>> down: >>> >>> > http://svnweb.freebsd.org/base/head/sys/amd64/include/proc.h?revision=233291&view=markup >>> /* Get the current kernel thread stack usage. */ >>> #define GET_STACK_USAGE(total, used) do { \ >>> struct thread *td = curthread; \ >>> (total) = td->td_kstack_pages * PAGE_SIZE; \ >>> (used) = (char *)td->td_kstack + \ >>> td->td_kstack_pages * PAGE_SIZE - \ >>> (char *)&td; \ >>> } while (0) >>> _______________________________________________ >>> freebsd-hackers@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers >>> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" >> I think that should be MI for us anyway. I'm not aware of any >> architectures FreeBSD supports with stacks that grow up. I'll give it a >> test on PPC. > ia64 has the double stack thingie where the register stack spills into a stack > that grows up rather than down. Not sure how sparc64 window spills are > handled either. > Ah, very well. That's weird. Should be fine for PPC, however. -Nathan From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 02:20:28 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 821) id EA5E718C; Thu, 5 Sep 2013 02:20:28 +0000 (UTC) Date: Thu, 5 Sep 2013 02:20:28 +0000 From: John To: FreeBSD SCSI Subject: Hung boot - mps related? Message-ID: <20130905022028.GA28801@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 02:20:29 -0000 Hi Folks, I updated one of my servers today to the latest 9-stable. The system starts to boot up and then hangs with the following: mps1: _mapping_add_new_device: failed to add the device with handle 0xe1 to persistent table because there is no free space available Note, the above cycles though many devices up to 0xe1.. Then: run_interupt_driven_hooks: still waiting after 60 seconds for xpt_config run_interupt_driven_hooks: still waiting after 120 seconds for xpt_config run_interupt_driven_hooks: still waiting after 180 seconds for xpt_config run_interupt_driven_hooks: still waiting after 240 seconds for xpt_config run_interupt_driven_hooks: still waiting after 300 seconds for xpt_config Nothing else after the above. In looking through the logs, I wonder if this could be related to the following: http://svnweb.freebsd.org/changeset/base/254938 There are a number of changes in the area that seem like they might effect this. Note, in the past, the "failed" message are present along with the "waiting" messages, but the system continues to boot, not hang. These are the same systems I've posted about in the past. The hardware hasn't changed (Just Stable-9 :-) The last working dmesg output from this system is here: http://people.freebsd.org/~jwd/r246437/dmesg.working.txt For grins, I did comment out the call to mapping_add_new_device() and the system booted up, but none of the disks showed up :-( Currently the system is sitting, hung at the "still waiting" msg to see if it might recover and finish booting overnight. Or not.. Thoughts? Thanks, John From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 10:27:16 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E35F942C; Thu, 5 Sep 2013 10:27:16 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ea0-x22e.google.com (mail-ea0-x22e.google.com [IPv6:2a00:1450:4013:c01::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 333D4222F; Thu, 5 Sep 2013 10:27:16 +0000 (UTC) Received: by mail-ea0-f174.google.com with SMTP id z15so784878ead.19 for ; Thu, 05 Sep 2013 03:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:content-type:content-transfer-encoding:subject :message-id:date:to:mime-version; bh=ZhxXcqEqmO2GKk/Vf6GdsN9ZvMrDLcQspyIKFfZGAVQ=; b=nmMeByk7hO4xt1sbtFmwZToFoEeDuQ4FnKxOHpq0cHN6E3mzL2LCP6N96ixOyCAyMT +GOs/Qu2QD4/WhP0Mdt/Xi+ulVjpAjL6Sj4D29lNVmALati5yJ2ZtgJsXR2jjZJ75/RB PMcJJ3sghQqYULOkgl0gRdiucw5iDdMaPjUTO96kA/Y3BYAHlQriwb7Dus2ueZmCI/9z vtQo4hV0vEz4EC0Xbl+VVusebyyQ3J/3JuiC14u7i2sXc39mWckEQ4XYNR6Nf3UO+pca TVE2lbncTymbXWYon49tXS76e/sg4CP+r7buPXYnlnMud50z90A/hP2H6P433bOzddLP gIcw== X-Received: by 10.14.199.3 with SMTP id w3mr12475284een.33.1378376834367; Thu, 05 Sep 2013 03:27:14 -0700 (PDT) Received: from [192.168.1.102] (addr48.neoplus.adsl.tpnet.pl. [79.184.69.48]) by mx.google.com with ESMTPSA id r48sm47407059eev.14.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Sep 2013 03:27:14 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: New iSCSI stack. Message-Id: Date: Thu, 5 Sep 2013 12:27:12 +0200 To: "freebsd-arch@freebsd.org" , "freebsd-current@FreeBSD.org" , freebsd-scsi@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) X-Mailer: Apple Mail (2.1508) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 10:27:17 -0000 Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diff you'll = find=20 a patch which adds the new iSCSI initiator and target, against = 10-CURRENT. =20 To use the new initiator, start with "man iscsictl". For the target - = "man=20 ctld". All feedback is welcome. If nothing unexpected comes up, I'll commit it=20= in a few days from now. Note that it's still not optimized; at this = point=20 I'm focusing more on reliability and interoperability. This work is being sponsored by FreeBSD Foundation. From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 12:00:52 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A57826B3; Thu, 5 Sep 2013 12:00:52 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ee0-x231.google.com (mail-ee0-x231.google.com [IPv6:2a00:1450:4013:c00::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C080F2868; Thu, 5 Sep 2013 12:00:51 +0000 (UTC) Received: by mail-ee0-f49.google.com with SMTP id d41so845284eek.36 for ; Thu, 05 Sep 2013 05:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=zZEQnc0IA5DKZgvMjyaAA877lzmwAPfqEcCPFRp8nfQ=; b=fED9uxnhJlo74TTEYUeFWlq2Q7QkIAo+DMbKAKc1MOuAZs47FQHS2s/Ktg348GMSCJ qtPFP3zkyyiZ3wNtkjHhZ3LT49lj5BDgK9IwC9GWPWx+j90tQDnqsUumDpiaZve7OL+d 8751rbA5mxT6PEmhJk6knWqTczPZg4Wbjt8WuTFo37SiWj1iqEbIWKfUSFTrs+YBNTj1 eJRcvrIUUNLsl1SDEysZaW9OEbZBOMa/AEw5gtWurQtoEpc5+J/nOODbUmezbnR5/ZNg Y425ClTQOpAhlL6wQLlHeKmdshwRu23JtNvjc5LxVGajXOuMM4kI8mioKzPsP4r518Dg 5sNg== X-Received: by 10.14.241.74 with SMTP id f50mr13120554eer.29.1378382450093; Thu, 05 Sep 2013 05:00:50 -0700 (PDT) Received: from [192.168.1.102] (addr48.neoplus.adsl.tpnet.pl. [79.184.69.48]) by mx.google.com with ESMTPSA id j7sm48069464eeo.15.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Sep 2013 05:00:49 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Content-Type: text/plain; charset=iso-8859-2 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: New iSCSI stack. From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= In-Reply-To: Date: Thu, 5 Sep 2013 14:00:48 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> References: To: Ivan Voras X-Mailer: Apple Mail (2.1508) Cc: freebsd-scsi@freebsd.org, freebsd-current@freebsd.org, freebsd-arch@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 12:00:52 -0000 Wiadomo=B6=E6 napisana przez Ivan Voras w dniu 5 = wrz 2013, o godz. 13:18: > On 05/09/2013 12:27, Edward Tomasz Napiera=B3a wrote: >> Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diff = you'll find=20 >> a patch which adds the new iSCSI initiator and target, against = 10-CURRENT. =20 >> To use the new initiator, start with "man iscsictl". For the target = - "man=20 >> ctld". >=20 > Just a naming question: "ctld" could mean anything, I'd parse it as a > "control deamon" or something like that. Could you name it something > which reminds the user of iscsi? Like iscsictld? As the man page says, ctld is "CAM Target Layer / iSCSI target daemon". Sure, right now it's pretty iSCSI-specific, but it doesn't need to be - = it can be extended to just manage CTL configuration (e.g. for Fibre Channel), or to support other CTL-backed storage protocols, such as FCoE. It's just a helper daemon for ctl(4) - thus, ctld(8). And in case = someone does "man -k iscsi", there is the "iSCSI target" in the manual page = title. From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 12:02:42 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B893F9F9; Thu, 5 Sep 2013 12:02:42 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-vc0-x230.google.com (mail-vc0-x230.google.com [IPv6:2607:f8b0:400c:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3B23A2897; Thu, 5 Sep 2013 12:02:42 +0000 (UTC) Received: by mail-vc0-f176.google.com with SMTP id lf11so1032641vcb.21 for ; Thu, 05 Sep 2013 05:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=shhfdmESCDns11D0oUrHWzke6gJlzhOPs3T32CamCSI=; b=WNVJTpM4UjIZeiYQx4mSB6aY5nLrck60CwGQIOxZ4EblepKrGeq8IVM1O0e9PMLRvL 2vJtsp2oH6Ji/7jrL6vvNBn9LeFq7NPrPY82o//HFKm2c9yCy+inA5dCidR9B/+cmQJM fQVMo67arwOA+PSxQ0Ptg0X3V5d6jMaZ+3QMtL7oeGEOTP1SP19Uo7FaV39CkLve/OOw kazS9m9OfC806uryETyKopFK5kcUIog/HUC+J6EZZCbHMfPfKC/SssgjiDiQ5r3Dmaiy xSm5iS51gbbm7MK1CHcl9JuRFKD2Kkirik4NGmRKz2JjbhxfmvS20uTNcJ2zGmuQctso GTaw== X-Received: by 10.52.98.66 with SMTP id eg2mr5661754vdb.24.1378382561266; Thu, 05 Sep 2013 05:02:41 -0700 (PDT) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.58.229.167 with HTTP; Thu, 5 Sep 2013 05:02:01 -0700 (PDT) In-Reply-To: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> From: Ivan Voras Date: Thu, 5 Sep 2013 14:02:01 +0200 X-Google-Sender-Auth: t0wqRhVH_HVHn62OcfGtOOEAkds Message-ID: Subject: Re: New iSCSI stack. To: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-scsi@freebsd.org, FreeBSD-Current , freebsd-arch@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 12:02:42 -0000 On 5 September 2013 14:00, Edward Tomasz Napiera=C5=82a = wrote: > Wiadomo=C5=9B=C4=87 napisana przez Ivan Voras w dniu= 5 wrz 2013, o godz. 13:18: >> On 05/09/2013 12:27, Edward Tomasz Napiera=C5=82a wrote: >>> Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diff you'l= l find >>> a patch which adds the new iSCSI initiator and target, against 10-CURRE= NT. >>> To use the new initiator, start with "man iscsictl". For the target - = "man >>> ctld". >> >> Just a naming question: "ctld" could mean anything, I'd parse it as a >> "control deamon" or something like that. Could you name it something >> which reminds the user of iscsi? Like iscsictld? > > As the man page says, ctld is "CAM Target Layer / iSCSI target daemon". > Sure, right now it's pretty iSCSI-specific, but it doesn't need to be - i= t can > be extended to just manage CTL configuration (e.g. for Fibre Channel), > or to support other CTL-backed storage protocols, such as FCoE. > > It's just a helper daemon for ctl(4) - thus, ctld(8). And in case someon= e > does "man -k iscsi", there is the "iSCSI target" in the manual page title= . Thanks, you're right! From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 15:14:42 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7006C349 for ; Thu, 5 Sep 2013 15:14:42 +0000 (UTC) (envelope-from bryanv@daemoninthecloset.org) Received: from torment.daemoninthecloset.org (torment.daemoninthecloset.org [94.242.209.234]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C1CD32656 for ; Thu, 5 Sep 2013 15:14:41 +0000 (UTC) Received: from sage.daemoninthecloset.org (unknown [70.114.209.60]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "sage.daemoninthecloset.org", Issuer "daemoninthecloset.org" (verified OK)) by torment.daemoninthecloset.org (Postfix) with ESMTPS id 4C68342C2631 for ; Thu, 5 Sep 2013 17:20:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at daemoninthecloset.org X-Virus-Scanned: amavisd-new at daemoninthecloset.org Date: Thu, 5 Sep 2013 10:14:17 -0500 (CDT) From: Bryan Venteicher To: freebsd-scsi@freebsd.org Message-ID: <1292769639.3059.1378394057334.JavaMail.root@daemoninthecloset.org> In-Reply-To: <1895443574.3014.1378393339664.JavaMail.root@daemoninthecloset.org> Subject: camcontrol SCSI sanitize MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3057_1096540079.1378394057331" X-Originating-IP: [10.51.1.6] X-Mailer: Zimbra 8.0.2_GA_5569 (ZimbraWebClient - GC29 (Mac)/8.0.2_GA_5569) Thread-Topic: camcontrol SCSI sanitize Thread-Index: WZuN9+NkfKCoDoyUJzD+clp//f3JTw== X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 15:14:42 -0000 ------=_Part_3057_1096540079.1378394057331 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, Anybody with more SCSI experience than myself interested in reviewing the attached patch that adds SCSI sanitize support to camcontrol? It has been compiled tested on -current, but a very similar patch works on 8.x. The time is short, but I wouldn't mind sneaking this into 10 before the code freeze so I have one less local patch to deal with later. http://people.freebsd.org/~bryanv/patches/camcontrol_sanitize.diff Thanks. ------=_Part_3057_1096540079.1378394057331 Content-Type: text/x-patch; name=camcontrol_sanitize.patch Content-Disposition: attachment; filename=camcontrol_sanitize.patch Content-Transfer-Encoding: base64 Y29tbWl0IDk0ZjdjOGQxMWEzMjBlMzZmNTllZGI3N2ZjZTU5M2I2Yzg5MmFhM2MKQXV0aG9yOiBC cnlhbiBWZW50ZWljaGVyIDxicnlhbnZAZGFlbW9uaW50aGVjbG9zZXQub3JnPgpEYXRlOiAgIFRo dSBTZXAgNSAwMDoxNDowOCAyMDEzIC0wNTAwCgogICAgQWRkIGNhbWNvbnRyb2wgc2FuaXRpemUg c3VwcG9ydAoKZGlmZiAtLWdpdCBhL3NiaW4vY2FtY29udHJvbC9jYW1jb250cm9sLjggYi9zYmlu L2NhbWNvbnRyb2wvY2FtY29udHJvbC44CmluZGV4IGRmMGIzZTcuLjBhMmJlNjQgMTAwNjQ0Ci0t LSBhL3NiaW4vY2FtY29udHJvbC9jYW1jb250cm9sLjgKKysrIGIvc2Jpbi9jYW1jb250cm9sL2Nh bWNvbnRyb2wuOApAQCAtMjA3LDYgKzIwNywxOSBAQAogLk9wIEZsIHcKIC5PcCBGbCB5CiAuTm0K Ky5JYyBzYW5pdGl6ZQorLk9wIGRldmljZSBpZAorLk9wIGdlbmVyaWMgYXJncworLkFxIEZsIGEg QXIgb3ZlcndyaXRlfGJsb2NrfGNyeXB0b3xleGl0ZmFpbHVyZQorLk9wIEZsIGMgY291bnQKKy5P cCBGbCBQIGZpbGUKKy5PcCBGbCBJCisuT3AgRmwgVQorLk9wIEZsIHEKKy5PcCBGbCByCisuT3Ag RmwgdworLk9wIEZsIHkKKy5ObQogLkljIGlkbGUKIC5PcCBkZXZpY2UgaWQKIC5PcCBnZW5lcmlj IGFyZ3MKQEAgLTEwODgsNiArMTEwMSwxMTcgQEAgVGhlIHVzZXIKIHdpbGwgbm90IGJlIGFza2Vk IGFib3V0IHRoZSB0aW1lb3V0IGlmIGEgdGltZW91dCBpcyBzcGVjaWZpZWQgb24gdGhlCiBjb21t YW5kIGxpbmUuCiAuRWwKKy5JdCBJYyBzYW5pdGl6ZQorSXNzdWUgdGhlCisuVG4gU0NTSQorU0FO SVRJWkUgY29tbWFuZCB0byB0aGUgbmFtZWQgZGV2aWNlLgorLlBwCisuRW0gV0FSTklORyEgV0FS TklORyEgV0FSTklORyEKKy5QcAorQUxMIGV4aXN0aW5nIGRhdGEgaW4gdGhlIGNhY2hlIGFuZCBv biB0aGUgZGlzayB3aWxsIGJlCitkZXN0cm95ZWQgb3IgbWFkZSBpbmFjY2Vzc2libGUuCitSZWNv dmVyeSBvZiB0aGUgZGF0YSBpcyBub3QgcG9zc2libGUuCitVc2UgZXh0cmVtZSBjYXV0aW9uIHdo ZW4gaXNzdWluZyB0aGlzIGNvbW1hbmQuCisuUHAKK1RoZQorLlNxIHNhbml0aXplCitzdWJjb21t YW5kIHRha2VzIHNldmVyYWwgYXJndW1lbnRzIHRoYXQgbW9kaWZ5IGl0cyBkZWZhdWx0IGJlaGF2 aW9yLgorVGhlCisuRmwgcQorYW5kCisuRmwgeQorYXJndW1lbnRzIGNhbiBiZSB1c2VmdWwgZm9y IHNjcmlwdHMuCisuQmwgLXRhZyAtd2lkdGggNm4KKy5JdCBGbCBxCitCZSBxdWlldCwgZG8gbm90 IHByaW50IGFueSBzdGF0dXMgbWVzc2FnZXMuCitUaGlzIG9wdGlvbiB3aWxsIG5vdCBkaXNhYmxl Cit0aGUgcXVlc3Rpb25zLCBob3dldmVyLgorVG8gZGlzYWJsZSBxdWVzdGlvbnMsIHVzZSB0aGUK Ky5GbCB5Cithcmd1bWVudCwgYmVsb3cuCisuSXQgRmwgYSBBciBhY3Rpb24KK1NwZWNpZnkgdGhl IHNhbml0aXplIG9wZXJhdGlvbiB0byBwZXJmb3JtLiBPbmx5IG9uZQorLkZsIGEKK2FjdGlvbiBt YXkgYmUgc3BlY2lmaWVkLgorLkJsIC10YWcgLXdpZHRoIDE2bgorLkl0IG92ZXJ3cml0ZQorUGVy Zm9ybSBhbiBvdmVyd3JpdGUgb3BlcmF0aW9uIGJ5IHdyaXRpbmcgYSB1c2VyIHN1cHBsaWVkCitk YXRhIHBhdHRlcm4gdG8gdGhlIGRldmljZSBvbmUgb3IgbW9yZSB0aW1lcy4KK1RoZSBwYXR0ZXJu IGlzIGdpdmVuIGJ5IHRoZQorLkZsIFAKK2FyZ3VtZW50LgorVGhlIGNvdW50IGlzIGdpdmVuIGJ5 IHRoZQorLkZsIGMKK2FyZ3VtZW50LgorLkl0IGJsb2NrCitQZXJmb3JtIGEgYmxvY2sgZXJhc2Ug b3BlcmF0aW9uLgorVGhlIHBoeXNpY2FsIGJsb2NrcyBhcmUgc2V0IHRvIGEgdmVuZG9yIGRlZmlu ZWQgdmFsdWUsIHR5cGljYWxseSBhbGwgemVyb3MuCisuSXQgY3J5cHRvCitQZXJmb3JtIGEgY3J5 cHRvZ3JhcGhpYyBlcmFzZSBvcGVyYXRpb24uCitUaGUgZW5jcnlwdGlvbiBrZXlzIGFyZSBjaGFu Z2VkLgorLkl0IGV4aXRmYWlsdXJlCitDbGVhcnMgYSBmYWlsZWQgc2FuaXRpemUgb3BlcmF0aW9u LgorQSBmYWlsZWQgc2FuaXRpemUgY2FuIG9ubHkgYmUgY2xlYXJlZCBpZiBpdCB3YXMgcnVuIGlu Cit0aGUgdW5yZXN0cmljdGVkIGNvbXBsZXRpb24gbW9kZSB3aXRoIHRoZQorLkZsIFUKK2FyZ3Vt ZW50LgorLkVsCisuSXQgRmwgYyBBciBjb3VudAorVGhlIG51bWJlciBvZiBwYXNzZXMgdG8gcGVy Zm9ybSB3aGVuIHBlcmZvcm1pbmcgYW4KKy5TcSBvdmVyd3JpdGUKK29wZXJhdGlvbi4KK1ZhbGlk IHZhbHVlcyBhcmUgYmV0d2VlbiAxIGFuZCAzMS4gIFRoZSBkZWZhdWx0IGlzIDEuCisuSXQgRmwg UCBBciBmaWxlCitQYXRoIHRvIHRoZSBmaWxlIGNvbnRhaW5pbmcgdGhlIHBhdHRlcm4gdG8gdXNl IHdoZW4KK3BlcmZvcm1pbmcgYW4KKy5TcSBvdmVyd3JpdGUKK29wZXJhdGlvbi4KK1RoZSBwYXR0 ZXJuIGlzIHJlcGVhdGVkIGFzIG5lZWRlZCB0byBmaWxsIGVhY2ggbG9naWNhbCBibG9jay4KKy5J dCBGbCBJCitXaGVuIHBlcmZvcm1pbmcgYW4KKy5TcSBvdmVyd3JpdGUKK29wZXJhdGlvbiwgdGhp cyBjYXVzZXMgdGhlIHBhdHRlcm4gdG8gYmUgaW52ZXJ0ZWQgYmV0d2VlbiBjb25zZWN1dGl2ZSBw YXNzZXMuCisuSXQgRmwgVQorUGVyZm9ybSB0aGUgc2FuaXRpemUgaW4gdGhlIHVucmVzdHJpY3Rl ZCBjb21wbGV0aW9uIG1vZGUuCitBIGZhaWxlZCBzYW5pdGl6ZSBvcGVyYXRpb24gY2FuIGxhdGVy IGJlIGNsZWFyZWQgd2l0aCB0aGUKKy5TcSBleGl0ZmFpbHVyZQorYWN0aW9uLgorLkl0IEZsIHIK K1J1biBpbgorLkRxIHJlcG9ydCBvbmx5Cittb2RlLgorVGhpcyB3aWxsIHJlcG9ydCBzdGF0dXMg b24gYSBzYW5pdGl6ZSB0aGF0IGlzIGFscmVhZHkgcnVubmluZyBvbiB0aGUgZHJpdmUuCisuSXQg RmwgdworSXNzdWUgYSBub24taW1tZWRpYXRlIHNhbml0aXplIGNvbW1hbmQuCitCeSBkZWZhdWx0 LAorLk5tCitpc3N1ZXMgdGhlIFNBTklUSVpFIGNvbW1hbmQgd2l0aCB0aGUgaW1tZWRpYXRlIGJp dCBzZXQuCitUaGlzIHRlbGxzIHRoZQorZGV2aWNlIHRvIGltbWVkaWF0ZWx5IHJldHVybiB0aGUg c2FuaXRpemUgY29tbWFuZCwgYmVmb3JlCit0aGUgc2FuaXRpemUgaGFzIGFjdHVhbGx5IGNvbXBs ZXRlZC4KK1RoZW4sCisuTm0KK2dhdGhlcnMKKy5UbiBTQ1NJCitzZW5zZSBpbmZvcm1hdGlvbiBm cm9tIHRoZSBkZXZpY2UgZXZlcnkgc2Vjb25kIHRvIGRldGVybWluZSBob3cgZmFyIGFsb25nCitp biB0aGUgc2FuaXRpemUgcHJvY2VzcyBpdCBpcy4KK0lmIHRoZQorLkZsIHcKK2FyZ3VtZW50IGlz IHNwZWNpZmllZCwKKy5ObQord2lsbCBpc3N1ZSBhIG5vbi1pbW1lZGlhdGUgc2FuaXRpemUgY29t bWFuZCwgYW5kIHdpbGwgYmUgdW5hYmxlIHRvIHByaW50IGFueQoraW5mb3JtYXRpb24gdG8gbGV0 IHRoZSB1c2VyIGtub3cgd2hhdCBwZXJjZW50YWdlIG9mIHRoZSBkaXNrIGhhcyBiZWVuCitzYW5p dGl6ZWQuCisuSXQgRmwgeQorRG8gbm90IGFzayBhbnkgcXVlc3Rpb25zLgorQnkgZGVmYXVsdCwK Ky5ObQord2lsbCBhc2sgdGhlIHVzZXIgaWYgaGUvc2hlIHJlYWxseSB3YW50cyB0byBzYW5pdGl6 ZSB0aGUgZGlzayBpbiBxdWVzdGlvbiwKK2FuZCBhbHNvIGlmIHRoZSBkZWZhdWx0IHNhbml0aXpl IGNvbW1hbmQgdGltZW91dCBpcyBhY2NlcHRhYmxlLgorVGhlIHVzZXIKK3dpbGwgbm90IGJlIGFz a2VkIGFib3V0IHRoZSB0aW1lb3V0IGlmIGEgdGltZW91dCBpcyBzcGVjaWZpZWQgb24gdGhlCitj b21tYW5kIGxpbmUuCisuRWwKIC5JdCBJYyBpZGxlCiBQdXQgQVRBIGRldmljZSBpbnRvIElETEUg c3RhdGUuIE9wdGlvbmFsIHBhcmFtZXRlcgogLlBxIEZsIHQKZGlmZiAtLWdpdCBhL3NiaW4vY2Ft Y29udHJvbC9jYW1jb250cm9sLmMgYi9zYmluL2NhbWNvbnRyb2wvY2FtY29udHJvbC5jCmluZGV4 IDc2YjM5MzkuLjY1MzFkNTQgMTAwNjQ0Ci0tLSBhL3NiaW4vY2FtY29udHJvbC9jYW1jb250cm9s LmMKKysrIGIvc2Jpbi9jYW1jb250cm9sL2NhbWNvbnRyb2wuYwpAQCAtMzIsNiArMzIsNyBAQCBf X0ZCU0RJRCgiJEZyZWVCU0QkIik7CiAjaW5jbHVkZSA8c3lzL2lvY3RsLmg+CiAjaW5jbHVkZSA8 c3lzL3N0ZGludC5oPgogI2luY2x1ZGUgPHN5cy90eXBlcy5oPgorI2luY2x1ZGUgPHN5cy9zdGF0 Lmg+CiAjaW5jbHVkZSA8c3lzL2VuZGlhbi5oPgogI2luY2x1ZGUgPHN5cy9zYnVmLmg+CiAKQEAg LTkzLDcgKzk0LDggQEAgdHlwZWRlZiBlbnVtIHsKIAlDQU1fQ01EX1NNUF9NQU5JTkZPCT0gMHgw MDAwMDAxYiwKIAlDQU1fQ01EX0RPV05MT0FEX0ZXCT0gMHgwMDAwMDAxYywKIAlDQU1fQ01EX1NF Q1VSSVRZCT0gMHgwMDAwMDAxZCwKLQlDQU1fQ01EX0hQQQkJPSAweDAwMDAwMDFlCisJQ0FNX0NN RF9IUEEJCT0gMHgwMDAwMDAxZSwKKwlDQU1fQ01EX1NBTklUSVpFCT0gMHgwMDAwMDAxZiwKIH0g Y2FtX2NtZG1hc2s7CiAKIHR5cGVkZWYgZW51bSB7CkBAIC0yMTUsNiArMjE3LDcgQEAgc3RhdGlj IHN0cnVjdCBjYW1jb250cm9sX29wdHMgb3B0aW9uX3RhYmxlW10gPSB7CiAJeyJmd2Rvd25sb2Fk IiwgQ0FNX0NNRF9ET1dOTE9BRF9GVywgQ0FNX0FSR19OT05FLCAiZjp5cyJ9LAogCXsic2VjdXJp dHkiLCBDQU1fQ01EX1NFQ1VSSVRZLCBDQU1fQVJHX05PTkUsICJkOmU6Zmg6azpsOnFzOlQ6VTp5 In0sCiAJeyJocGEiLCBDQU1fQ01EX0hQQSwgQ0FNX0FSR19OT05FLCAiUGZscDpxczpVOnkifSwK Kwl7InNhbml0aXplIiwgQ0FNX0NNRF9TQU5JVElaRSwgQ0FNX0FSR19OT05FLCAiYTpjOklQOnFy VXd5In0sCiAjZW5kaWYgLyogTUlOSU1BTElTVElDICovCiAJeyJoZWxwIiwgQ0FNX0NNRF9VU0FH RSwgQ0FNX0FSR19OT05FLCBOVUxMfSwKIAl7Ii0/IiwgQ0FNX0NNRF9VU0FHRSwgQ0FNX0FSR19O T05FLCBOVUxMfSwKQEAgLTMwMSw2ICszMDQsOCBAQCBzdGF0aWMgaW50IHJhdGVjb250cm9sKHN0 cnVjdCBjYW1fZGV2aWNlICpkZXZpY2UsIGludCByZXRyeV9jb3VudCwKIAkJICAgICAgIGludCB0 aW1lb3V0LCBpbnQgYXJnYywgY2hhciAqKmFyZ3YsIGNoYXIgKmNvbWJpbmVkb3B0KTsKIHN0YXRp YyBpbnQgc2NzaWZvcm1hdChzdHJ1Y3QgY2FtX2RldmljZSAqZGV2aWNlLCBpbnQgYXJnYywgY2hh ciAqKmFyZ3YsCiAJCSAgICAgIGNoYXIgKmNvbWJpbmVkb3B0LCBpbnQgcmV0cnlfY291bnQsIGlu dCB0aW1lb3V0KTsKK3N0YXRpYyBpbnQgc2NzaXNhbml0aXplKHN0cnVjdCBjYW1fZGV2aWNlICpk ZXZpY2UsIGludCBhcmdjLCBjaGFyICoqYXJndiwKKwkJCWNoYXIgKmNvbWJpbmVkb3B0LCBpbnQg cmV0cnlfY291bnQsIGludCB0aW1lb3V0KTsKIHN0YXRpYyBpbnQgc2NzaXJlcG9ydGx1bnMoc3Ry dWN0IGNhbV9kZXZpY2UgKmRldmljZSwgaW50IGFyZ2MsIGNoYXIgKiphcmd2LAogCQkJICBjaGFy ICpjb21iaW5lZG9wdCwgaW50IHJldHJ5X2NvdW50LCBpbnQgdGltZW91dCk7CiBzdGF0aWMgaW50 IHNjc2lyZWFkY2FwYWNpdHkoc3RydWN0IGNhbV9kZXZpY2UgKmRldmljZSwgaW50IGFyZ2MsIGNo YXIgKiphcmd2LApAQCAtNTUzNyw2ICs1NTQyLDQwMSBAQCBzY3NpZm9ybWF0X2JhaWxvdXQ6CiB9 CiAKIHN0YXRpYyBpbnQKK3Njc2lzYW5pdGl6ZShzdHJ1Y3QgY2FtX2RldmljZSAqZGV2aWNlLCBp bnQgYXJnYywgY2hhciAqKmFyZ3YsCisJICAgICBjaGFyICpjb21iaW5lZG9wdCwgaW50IHJldHJ5 X2NvdW50LCBpbnQgdGltZW91dCkKK3sKKwl1bmlvbiBjY2IgKmNjYjsKKwl1X2ludDhfdCBhY3Rp b24gPSAwOworCWludCBjOworCWludCB5Y291bnQgPSAwLCBxdWlldCA9IDA7CisJaW50IGVycm9y ID0gMCwgcmV0dmFsID0gMDsKKwlpbnQgdXNlX3RpbWVvdXQgPSAxMDgwMCAqIDEwMDA7CisJaW50 IGltbWVkaWF0ZSA9IDE7CisJaW50IGludmVydCA9IDA7CisJaW50IHBhc3NlcyA9IDA7CisJaW50 IGF1c2UgPSAwOworCWludCBmZCA9IC0xOworCWNvbnN0IGNoYXIgKnBhdHRlcm4gPSBOVUxMOwor CXVfaW50OF90ICpkYXRhX3B0ciA9IE5VTEw7CisJdV9pbnQzMl90IGR4ZmVyX2xlbiA9IDA7CisJ dV9pbnQ4X3QgYnl0ZTIgPSAwOworCWludCBudW1fd2FybmluZ3MgPSAwOworCWludCByZXBvcnRv bmx5ID0gMDsKKworCWNjYiA9IGNhbV9nZXRjY2IoZGV2aWNlKTsKKworCWlmIChjY2IgPT0gTlVM TCkgeworCQl3YXJueCgic2NzaXNhbml0aXplOiBlcnJvciBhbGxvY2F0aW5nIGNjYiIpOworCQly ZXR1cm4oMSk7CisJfQorCisJYnplcm8oJigmY2NiLT5jY2JfaClbMV0sCisJICAgICAgc2l6ZW9m KHN0cnVjdCBjY2Jfc2NzaWlvKSAtIHNpemVvZihzdHJ1Y3QgY2NiX2hkcikpOworCisJd2hpbGUg KChjID0gZ2V0b3B0KGFyZ2MsIGFyZ3YsIGNvbWJpbmVkb3B0KSkgIT0gLTEpIHsKKwkJc3dpdGNo KGMpIHsKKwkJY2FzZSAnYSc6CisJCQlpZiAoc3RyY2FzZWNtcChvcHRhcmcsICJvdmVyd3JpdGUi KSA9PSAwKQorCQkJCWFjdGlvbiA9IFNTWl9TRVJWSUNFX0FDVElPTl9PVkVSV1JJVEU7CisJCQll bHNlIGlmIChzdHJjYXNlY21wKG9wdGFyZywgImJsb2NrIikgPT0gMCkKKwkJCQlhY3Rpb24gPSBT U1pfU0VSVklDRV9BQ1RJT05fQkxPQ0tfRVJBU0U7CisJCQllbHNlIGlmIChzdHJjYXNlY21wKG9w dGFyZywgImNyeXB0byIpID09IDApCisJCQkJYWN0aW9uID0gU1NaX1NFUlZJQ0VfQUNUSU9OX0NS WVBUT19FUkFTRTsKKwkJCWVsc2UgaWYgKHN0cmNhc2VjbXAob3B0YXJnLCAiZXhpdGZhaWx1cmUi KSA9PSAwKQorCQkJCWFjdGlvbiA9IFNTWl9TRVJWSUNFX0FDVElPTl9FWElUX01PREVfRkFJTFVS RTsKKwkJCWVsc2UgeworCQkJCXdhcm54KCJpbnZhbGlkIHNlcnZpY2UgYWN0aW9uIG1vZGUgXCIl c1wiIiwKKwkJCQkgICAgICBvcHRhcmcpOworCQkJCWVycm9yID0gMTsKKwkJCQlnb3RvIHNjc2lz YW5pdGl6ZV9iYWlsb3V0OworCQkJfQorCQkJYnJlYWs7CisJCWNhc2UgJ2MnOgorCQkJcGFzc2Vz ID0gc3RydG9sKG9wdGFyZywgTlVMTCwgMCk7CisJCQlpZiAocGFzc2VzIDwgMSB8fCBwYXNzZXMg PiAzMSkgeworCQkJCXdhcm54KCJpbnZhbGlkIHBhc3NlcyB2YWx1ZSAlZCIsIHBhc3Nlcyk7CisJ CQkJZXJyb3IgPSAxOworCQkJCWdvdG8gc2NzaXNhbml0aXplX2JhaWxvdXQ7CisJCQl9CisJCQli cmVhazsKKwkJY2FzZSAnSSc6CisJCQlpbnZlcnQgPSAxOworCQkJYnJlYWs7CisJCWNhc2UgJ1An OgorCQkJcGF0dGVybiA9IG9wdGFyZzsKKwkJCWJyZWFrOworCQljYXNlICdxJzoKKwkJCXF1aWV0 Kys7CisJCQlicmVhazsKKwkJY2FzZSAncic6CisJCQlyZXBvcnRvbmx5ID0gMTsKKwkJCWJyZWFr OworCQljYXNlICdVJzoKKwkJCWF1c2UgPSAxOworCQkJYnJlYWs7CisJCWNhc2UgJ3cnOgorCQkJ aW1tZWRpYXRlID0gMDsKKwkJCWJyZWFrOworCQljYXNlICd5JzoKKwkJCXljb3VudCsrOworCQkJ YnJlYWs7CisJCX0KKwl9CisKKwlpZiAocmVwb3J0b25seSkKKwkJZ290byBkb3JlcG9ydDsKKwor CWlmIChhY3Rpb24gPT0gMCkgeworCQl3YXJueCgiYW4gYWN0aW9uIGlzIHJlcXVpcmVkIik7CisJ CWVycm9yID0gMTsKKwkJZ290byBzY3Npc2FuaXRpemVfYmFpbG91dDsKKwl9IGVsc2UgaWYgKGFj dGlvbiA9PSBTU1pfU0VSVklDRV9BQ1RJT05fT1ZFUldSSVRFKSB7CisJCXN0cnVjdCBzY3NpX3Nh bml0aXplX3BhcmFtZXRlcl9saXN0ICpwbDsKKwkJc3RydWN0IHN0YXQgc2I7CisJCXNzaXplX3Qg c3osIGFtdDsKKworCQlpZiAocGF0dGVybiA9PSBOVUxMKSB7CisJCQl3YXJueCgib3ZlcndyaXRl IGFjdGlvbiByZXF1aXJlcyAtUCBhcmd1bWVudCIpOworCQkJZXJyb3IgPSAxOworCQkJZ290byBz Y3Npc2FuaXRpemVfYmFpbG91dDsKKwkJfQorCQlmZCA9IG9wZW4ocGF0dGVybiwgT19SRE9OTFkp OworCQlpZiAoZmQgPCAwKSB7CisJCQl3YXJuKCJjYW5ub3Qgb3BlbiBwYXR0ZXJuIGZpbGUgJXMi LCBwYXR0ZXJuKTsKKwkJCWVycm9yID0gMTsKKwkJCWdvdG8gc2NzaXNhbml0aXplX2JhaWxvdXQ7 CisJCX0KKwkJaWYgKGZzdGF0KGZkLCAmc2IpIDwgMCkgeworCQkJd2FybigiY2Fubm90IHN0YXQg cGF0dGVybiBmaWxlICVzIiwgcGF0dGVybik7CisJCQllcnJvciA9IDE7CisJCQlnb3RvIHNjc2lz YW5pdGl6ZV9iYWlsb3V0OworCQl9CisJCXN6ID0gc2Iuc3Rfc2l6ZTsKKwkJaWYgKHN6ID4gU1Na UExfTUFYX1BBVFRFUk5fTEVOR1RIKSB7CisJCQl3YXJueCgicGF0dGVybiBmaWxlIHNpemUgZXhj ZWVkcyBtYXhpbXVtIHZhbHVlICVkIiwKKwkJCSAgICAgIFNTWlBMX01BWF9QQVRURVJOX0xFTkdU SCk7CisJCQllcnJvciA9IDE7CisJCQlnb3RvIHNjc2lzYW5pdGl6ZV9iYWlsb3V0OworCQl9CisJ CWR4ZmVyX2xlbiA9IHNpemVvZigqcGwpICsgc3o7CisJCWRhdGFfcHRyID0gY2FsbG9jKDEsIGR4 ZmVyX2xlbik7CisJCWlmIChkYXRhX3B0ciA9PSBOVUxMKSB7CisJCQl3YXJueCgiY2Fubm90IGFs bG9jYXRlIHBhcmFtZXRlciBsaXN0IGJ1ZmZlciIpOworCQkJZXJyb3IgPSAxOworCQkJZ290byBz Y3Npc2FuaXRpemVfYmFpbG91dDsKKwkJfQorCisJCWFtdCA9IHJlYWQoZmQsIGRhdGFfcHRyICsg c2l6ZW9mKCpwbCksIHN6KTsKKwkJaWYgKGFtdCA8IDApIHsKKwkJCXdhcm4oImNhbm5vdCByZWFk IHBhdHRlcm4gZmlsZSIpOworCQkJZXJyb3IgPSAxOworCQkJZ290byBzY3Npc2FuaXRpemVfYmFp bG91dDsKKwkJfSBlbHNlIGlmIChhbXQgIT0gc3opIHsKKwkJCXdhcm54KCJzaG9ydCBwYXR0ZXJu IGZpbGUgcmVhZCIpOworCQkJZXJyb3IgPSAxOworCQkJZ290byBzY3Npc2FuaXRpemVfYmFpbG91 dDsKKwkJfQorCisJCXBsID0gKHN0cnVjdCBzY3NpX3Nhbml0aXplX3BhcmFtZXRlcl9saXN0ICop ZGF0YV9wdHI7CisJCWlmIChwYXNzZXMgPT0gMCkKKwkJCXBsLT5ieXRlMSA9IDE7CisJCWVsc2UK KwkJCXBsLT5ieXRlMSA9IHBhc3NlczsKKwkJaWYgKGludmVydCAhPSAwKQorCQkJcGwtPmJ5dGUx IHw9IFNTWlBMX0lOVkVSVDsKKwkJc2NzaV91bHRvMmIoc3osIHBsLT5sZW5ndGgpOworCX0gZWxz ZSB7CisJCWNvbnN0IGNoYXIgKmFyZzsKKworCQlpZiAocGFzc2VzICE9IDApCisJCQlhcmcgPSAi LWMiOworCQllbHNlIGlmIChwYXR0ZXJuICE9IE5VTEwpCisJCQlhcmcgPSAiLVAiOworCQllbHNl IGlmIChpbnZlcnQgIT0gMCkKKwkJCWFyZyA9ICItSSI7CisJCWVsc2UKKwkJCWFyZyA9IE5VTEw7 CisJCWlmIChhcmcgIT0gTlVMTCkgeworCQkJd2FybngoIiVzIGFyZ3VtZW50IG9ubHkgdmFsaWQg d2l0aCBvdmVyd3JpdGUgYWN0aW9uIiwgYXJnKTsKKwkJCWVycm9yID0gMTsKKwkJCWdvdG8gc2Nz aXNhbml0aXplX2JhaWxvdXQ7CisJCX0KKwl9CisKKwlpZiAocXVpZXQgPT0gMCkgeworCQlmcHJp bnRmKHN0ZG91dCwgIllvdSBhcmUgYWJvdXQgdG8gUkVNT1ZFIEFMTCBEQVRBIGZyb20gdGhlICIK KwkJCSJmb2xsb3dpbmcgZGV2aWNlOlxuIik7CisKKwkJZXJyb3IgPSBzY3NpZG9pbnF1aXJ5KGRl dmljZSwgYXJnYywgYXJndiwgY29tYmluZWRvcHQsCisJCQkJICAgICAgcmV0cnlfY291bnQsIHRp bWVvdXQpOworCisJCWlmIChlcnJvciAhPSAwKSB7CisJCQl3YXJueCgic2NzaXNhbml0aXplOiBl cnJvciBzZW5kaW5nIGlucXVpcnkiKTsKKwkJCWdvdG8gc2NzaXNhbml0aXplX2JhaWxvdXQ7CisJ CX0KKwl9CisKKwlpZiAoeWNvdW50ID09IDApIHsKKwkJaWYgKCFnZXRfY29uZmlybWF0aW9uKCkp IHsKKwkJCWVycm9yID0gMTsKKwkJCWdvdG8gc2NzaXNhbml0aXplX2JhaWxvdXQ7CisJCX0KKwl9 CisKKwlpZiAodGltZW91dCAhPSAwKQorCQl1c2VfdGltZW91dCA9IHRpbWVvdXQ7CisKKwlpZiAo cXVpZXQgPT0gMCkgeworCQlmcHJpbnRmKHN0ZG91dCwgIkN1cnJlbnQgc2FuaXRpemUgdGltZW91 dCBpcyAlZCBzZWNvbmRzXG4iLAorCQkJdXNlX3RpbWVvdXQgLyAxMDAwKTsKKwl9CisKKwkvKgor CSAqIElmIHRoZSB1c2VyIGhhc24ndCBkaXNhYmxlZCBxdWVzdGlvbnMgYW5kIGRpZG4ndCBzcGVj aWZ5IGEKKwkgKiB0aW1lb3V0IG9uIHRoZSBjb21tYW5kIGxpbmUsIGFzayB0aGVtIGlmIHRoZXkg d2FudCB0aGUgY3VycmVudAorCSAqIHRpbWVvdXQuCisJICovCisJaWYgKCh5Y291bnQgPT0gMCkK KwkgJiYgKHRpbWVvdXQgPT0gMCkpIHsKKwkJY2hhciBzdHJbMTAyNF07CisJCWludCBuZXdfdGlt ZW91dCA9IDA7CisKKwkJZnByaW50ZihzdGRvdXQsICJFbnRlciBuZXcgdGltZW91dCBpbiBzZWNv bmRzIG9yIHByZXNzXG4iCisJCQkicmV0dXJuIHRvIGtlZXAgdGhlIGN1cnJlbnQgdGltZW91dCBb JWRdICIsCisJCQl1c2VfdGltZW91dCAvIDEwMDApOworCisJCWlmIChmZ2V0cyhzdHIsIHNpemVv ZihzdHIpLCBzdGRpbikgIT0gTlVMTCkgeworCQkJaWYgKHN0clswXSAhPSAnXDAnKQorCQkJCW5l d190aW1lb3V0ID0gYXRvaShzdHIpOworCQl9CisKKwkJaWYgKG5ld190aW1lb3V0ICE9IDApIHsK KwkJCXVzZV90aW1lb3V0ID0gbmV3X3RpbWVvdXQgKiAxMDAwOworCQkJZnByaW50ZihzdGRvdXQs ICJVc2luZyBuZXcgdGltZW91dCB2YWx1ZSAlZFxuIiwKKwkJCQl1c2VfdGltZW91dCAvIDEwMDAp OworCQl9CisJfQorCisJYnl0ZTIgPSBhY3Rpb247CisJaWYgKGF1c2UgIT0gMCkKKwkJYnl0ZTIg fD0gU1NaX1VOUkVTVFJJQ1RFRF9FWElUOworCWlmIChpbW1lZGlhdGUgIT0gMCkKKwkJYnl0ZTIg fD0gU1NaX0lNTUVEOworCisJc2NzaV9zYW5pdGl6ZSgmY2NiLT5jc2lvLAorCQkgICAgICAvKiBy ZXRyaWVzICovIHJldHJ5X2NvdW50LAorCQkgICAgICAvKiBjYmZjbnAgKi8gTlVMTCwKKwkJICAg ICAgLyogdGFnX2FjdGlvbiAqLyBNU0dfU0lNUExFX1FfVEFHLAorCQkgICAgICAvKiBieXRlMiAq LyBieXRlMiwKKwkJICAgICAgLyogY29udHJvbCAqLyAwLAorCQkgICAgICAvKiBkYXRhX3B0ciAq LyBkYXRhX3B0ciwKKwkJICAgICAgLyogZHhmZXJfbGVuICovIGR4ZmVyX2xlbiwKKwkJICAgICAg Lyogc2Vuc2VfbGVuICovIFNTRF9GVUxMX1NJWkUsCisJCSAgICAgIC8qIHRpbWVvdXQgKi8gdXNl X3RpbWVvdXQpOworCisJLyogRGlzYWJsZSBmcmVlemluZyB0aGUgZGV2aWNlIHF1ZXVlICovCisJ Y2NiLT5jY2JfaC5mbGFncyB8PSBDQU1fREVWX1FGUlpESVM7CisKKwlpZiAoYXJnbGlzdCAmIENB TV9BUkdfRVJSX1JFQ09WRVIpCisJCWNjYi0+Y2NiX2guZmxhZ3MgfD0gQ0FNX1BBU1NfRVJSX1JF Q09WRVI7CisKKwlpZiAoKChyZXR2YWwgPSBjYW1fc2VuZF9jY2IoZGV2aWNlLCBjY2IpKSA8IDAp CisJIHx8ICgoaW1tZWRpYXRlID09IDApCisJICAgJiYgKChjY2ItPmNjYl9oLnN0YXR1cyAmIENB TV9TVEFUVVNfTUFTSykgIT0gQ0FNX1JFUV9DTVApKSkgeworCQljb25zdCBjaGFyIGVycnN0cltd ID0gImVycm9yIHNlbmRpbmcgc2FuaXRpemUgY29tbWFuZCI7CisKKwkJaWYgKHJldHZhbCA8IDAp CisJCQl3YXJuKGVycnN0cik7CisJCWVsc2UKKwkJCXdhcm54KGVycnN0cik7CisKKwkJaWYgKGFy Z2xpc3QgJiBDQU1fQVJHX1ZFUkJPU0UpIHsKKwkJCWNhbV9lcnJvcl9wcmludChkZXZpY2UsIGNj YiwgQ0FNX0VTRl9BTEwsCisJCQkJCUNBTV9FUEZfQUxMLCBzdGRlcnIpOworCQl9CisJCWVycm9y ID0gMTsKKwkJZ290byBzY3Npc2FuaXRpemVfYmFpbG91dDsKKwl9CisKKwkvKgorCSAqIElmIHdl IHJhbiBpbiBub24taW1tZWRpYXRlIG1vZGUsIHdlIGFscmVhZHkgY2hlY2tlZCBmb3IgZXJyb3Jz CisJICogYWJvdmUgYW5kIHByaW50ZWQgb3V0IGFueSBuZWNlc3NhcnkgaW5mb3JtYXRpb24uICBJ ZiB3ZSdyZSBpbgorCSAqIGltbWVkaWF0ZSBtb2RlLCB3ZSBuZWVkIHRvIGxvb3AgdGhyb3VnaCBh bmQgZ2V0IHN0YXR1cworCSAqIGluZm9ybWF0aW9uIHBlcmlvZGljYWxseS4KKwkgKi8KKwlpZiAo aW1tZWRpYXRlID09IDApIHsKKwkJaWYgKHF1aWV0ID09IDApIHsKKwkJCWZwcmludGYoc3Rkb3V0 LCAiU2FuaXRpemUgQ29tcGxldGVcbiIpOworCQl9CisJCWdvdG8gc2NzaXNhbml0aXplX2JhaWxv dXQ7CisJfQorCitkb3JlcG9ydDoKKwlkbyB7CisJCWNhbV9zdGF0dXMgc3RhdHVzOworCisJCWJ6 ZXJvKCYoJmNjYi0+Y2NiX2gpWzFdLAorCQkgICAgICBzaXplb2Yoc3RydWN0IGNjYl9zY3NpaW8p IC0gc2l6ZW9mKHN0cnVjdCBjY2JfaGRyKSk7CisKKwkJLyoKKwkJICogVGhlcmUncyByZWFsbHkg bm8gbmVlZCB0byBkbyBlcnJvciByZWNvdmVyeSBvcgorCQkgKiByZXRyaWVzIGhlcmUsIHNpbmNl IHdlJ3JlIGp1c3QgZ29pbmcgdG8gc2l0IGluIGEKKwkJICogbG9vcCBhbmQgd2FpdCBmb3IgdGhl IGRldmljZSB0byBmaW5pc2ggc2FuaXRpemluZy4KKwkJICovCisJCXNjc2lfdGVzdF91bml0X3Jl YWR5KCZjY2ItPmNzaW8sCisJCQkJICAgICAvKiByZXRyaWVzICovIDAsCisJCQkJICAgICAvKiBj YmZjbnAgKi8gTlVMTCwKKwkJCQkgICAgIC8qIHRhZ19hY3Rpb24gKi8gTVNHX1NJTVBMRV9RX1RB RywKKwkJCQkgICAgIC8qIHNlbnNlX2xlbiAqLyBTU0RfRlVMTF9TSVpFLAorCQkJCSAgICAgLyog dGltZW91dCAqLyA1MDAwKTsKKworCQkvKiBEaXNhYmxlIGZyZWV6aW5nIHRoZSBkZXZpY2UgcXVl dWUgKi8KKwkJY2NiLT5jY2JfaC5mbGFncyB8PSBDQU1fREVWX1FGUlpESVM7CisKKwkJcmV0dmFs ID0gY2FtX3NlbmRfY2NiKGRldmljZSwgY2NiKTsKKworCQkvKgorCQkgKiBJZiB3ZSBnZXQgYW4g ZXJyb3IgZnJvbSB0aGUgaW9jdGwsIGJhaWwgb3V0LiAgU0NTSQorCQkgKiBlcnJvcnMgYXJlIGV4 cGVjdGVkLgorCQkgKi8KKwkJaWYgKHJldHZhbCA8IDApIHsKKwkJCXdhcm4oImVycm9yIHNlbmRp bmcgQ0FNSU9DT01NQU5EIGlvY3RsIik7CisJCQlpZiAoYXJnbGlzdCAmIENBTV9BUkdfVkVSQk9T RSkgeworCQkJCWNhbV9lcnJvcl9wcmludChkZXZpY2UsIGNjYiwgQ0FNX0VTRl9BTEwsCisJCQkJ CQlDQU1fRVBGX0FMTCwgc3RkZXJyKTsKKwkJCX0KKwkJCWVycm9yID0gMTsKKwkJCWdvdG8gc2Nz aXNhbml0aXplX2JhaWxvdXQ7CisJCX0KKworCQlzdGF0dXMgPSBjY2ItPmNjYl9oLnN0YXR1cyAm IENBTV9TVEFUVVNfTUFTSzsKKworCQlpZiAoKHN0YXR1cyAhPSBDQU1fUkVRX0NNUCkKKwkJICYm IChzdGF0dXMgPT0gQ0FNX1NDU0lfU1RBVFVTX0VSUk9SKQorCQkgJiYgKChjY2ItPmNjYl9oLnN0 YXR1cyAmIENBTV9BVVRPU05TX1ZBTElEKSAhPSAwKSkgeworCQkJc3RydWN0IHNjc2lfc2Vuc2Vf ZGF0YSAqc2Vuc2U7CisJCQlpbnQgZXJyb3JfY29kZSwgc2Vuc2Vfa2V5LCBhc2MsIGFzY3E7CisK KwkJCXNlbnNlID0gJmNjYi0+Y3Npby5zZW5zZV9kYXRhOworCQkJc2NzaV9leHRyYWN0X3NlbnNl X2xlbihzZW5zZSwgY2NiLT5jc2lvLnNlbnNlX2xlbiAtCisJCQkgICAgY2NiLT5jc2lvLnNlbnNl X3Jlc2lkLCAmZXJyb3JfY29kZSwgJnNlbnNlX2tleSwKKwkJCSAgICAmYXNjLCAmYXNjcSwgLypz aG93X2Vycm9ycyovIDEpOworCisJCQkvKgorCQkJICogQWNjb3JkaW5nIHRvIHRoZSBTQ1NJLTMg c3BlYywgYSBkcml2ZSB0aGF0IGlzIGluIHRoZQorCQkJICogbWlkZGxlIG9mIGEgc2FuaXRpemUg c2hvdWxkIHJldHVybiBOT1QgUkVBRFkgd2l0aCBhbgorCQkJICogQVNDIG9mICJsb2dpY2FsIHVu aXQgbm90IHJlYWR5LCBzYW5pdGl6ZSBpbgorCQkJICogcHJvZ3Jlc3MiLiBUaGUgc2Vuc2Uga2V5 IHNwZWNpZmljIGJ5dGVzIHdpbGwgdGhlbgorCQkJICogYmUgYSBwcm9ncmVzcyBpbmRpY2F0b3Iu CisJCQkgKi8KKwkJCWlmICgoc2Vuc2Vfa2V5ID09IFNTRF9LRVlfTk9UX1JFQURZKQorCQkJICYm IChhc2MgPT0gMHgwNCkgJiYgKGFzY3EgPT0gMHgxYikpIHsKKwkJCQl1aW50OF90IHNrc1szXTsK KworCQkJCWlmICgoc2NzaV9nZXRfc2tzKHNlbnNlLCBjY2ItPmNzaW8uc2Vuc2VfbGVuIC0KKwkJ CQkgICAgIGNjYi0+Y3Npby5zZW5zZV9yZXNpZCwgc2tzKSA9PSAwKQorCQkJCSAmJiAocXVpZXQg PT0gMCkpIHsKKwkJCQkJaW50IHZhbDsKKwkJCQkJdV9pbnQ2NF90IHBlcmNlbnRhZ2U7CisKKwkJ CQkJdmFsID0gc2NzaV8yYnRvdWwoJnNrc1sxXSk7CisJCQkJCXBlcmNlbnRhZ2UgPSAxMDAwMCAq IHZhbDsKKworCQkJCQlmcHJpbnRmKHN0ZG91dCwKKwkJCQkJCSJcclNhbml0aXppbmc6ICAlanUu JTAydSAlJSAiCisJCQkJCQkiKCVkLyVkKSBkb25lIiwKKwkJCQkJCSh1aW50bWF4X3QpKHBlcmNl bnRhZ2UgLworCQkJCQkJKDB4MTAwMDAgKiAxMDApKSwKKwkJCQkJCSh1bnNpZ25lZCkoKHBlcmNl bnRhZ2UgLworCQkJCQkJMHgxMDAwMCkgJSAxMDApLAorCQkJCQkJdmFsLCAweDEwMDAwKTsKKwkJ CQkJZmZsdXNoKHN0ZG91dCk7CisJCQkJfSBlbHNlIGlmICgocXVpZXQgPT0gMCkKKwkJCQkJJiYg KCsrbnVtX3dhcm5pbmdzIDw9IDEpKSB7CisJCQkJCXdhcm54KCJVbmV4cGVjdGVkIFNDU0kgU2Vu c2UgS2V5ICIKKwkJCQkJICAgICAgIlNwZWNpZmljIHZhbHVlIHJldHVybmVkICIKKwkJCQkJICAg ICAgImR1cmluZyBzYW5pdGl6ZToiKTsKKwkJCQkJc2NzaV9zZW5zZV9wcmludChkZXZpY2UsICZj Y2ItPmNzaW8sCisJCQkJCQkJIHN0ZGVycik7CisJCQkJCXdhcm54KCJVbmFibGUgdG8gcHJpbnQg c3RhdHVzICIKKwkJCQkJICAgICAgImluZm9ybWF0aW9uLCBidXQgc2FuaXR6ZSB3aWxsICIKKwkJ CQkJICAgICAgInByb2NlZWQuIik7CisJCQkJCXdhcm54KCJ3aWxsIGV4aXQgd2hlbiBzYW5pdGl6 ZSBpcyAiCisJCQkJCSAgICAgICJjb21wbGV0ZSIpOworCQkJCX0KKwkJCQlzbGVlcCgxKTsKKwkJ CX0gZWxzZSB7CisJCQkJd2FybngoIlVuZXhwZWN0ZWQgU0NTSSBlcnJvciBkdXJpbmcgc2FuaXRp emUiKTsKKwkJCQljYW1fZXJyb3JfcHJpbnQoZGV2aWNlLCBjY2IsIENBTV9FU0ZfQUxMLAorCQkJ CQkJQ0FNX0VQRl9BTEwsIHN0ZGVycik7CisJCQkJZXJyb3IgPSAxOworCQkJCWdvdG8gc2NzaXNh bml0aXplX2JhaWxvdXQ7CisJCQl9CisKKwkJfSBlbHNlIGlmIChzdGF0dXMgIT0gQ0FNX1JFUV9D TVApIHsKKwkJCXdhcm54KCJVbmV4cGVjdGVkIENBTSBzdGF0dXMgJSN4Iiwgc3RhdHVzKTsKKwkJ CWlmIChhcmdsaXN0ICYgQ0FNX0FSR19WRVJCT1NFKQorCQkJCWNhbV9lcnJvcl9wcmludChkZXZp Y2UsIGNjYiwgQ0FNX0VTRl9BTEwsCisJCQkJCQlDQU1fRVBGX0FMTCwgc3RkZXJyKTsKKwkJCWVy cm9yID0gMTsKKwkJCWdvdG8gc2NzaXNhbml0aXplX2JhaWxvdXQ7CisJCX0KKwl9IHdoaWxlKChj Y2ItPmNjYl9oLnN0YXR1cyAmIENBTV9TVEFUVVNfTUFTSykgIT0gQ0FNX1JFUV9DTVApOworCisJ aWYgKHF1aWV0ID09IDApCisJCWZwcmludGYoc3Rkb3V0LCAiXG5TYW5pdGl6ZSBDb21wbGV0ZVxu Iik7CisKK3Njc2lzYW5pdGl6ZV9iYWlsb3V0OgorCWlmIChmZCA+PSAwKQorCQljbG9zZShmZCk7 CisJaWYgKGRhdGFfcHRyICE9IE5VTEwpCisJCWZyZWUoZGF0YV9wdHIpOworCWNhbV9mcmVlY2Ni KGNjYik7CisKKwlyZXR1cm4oZXJyb3IpOworfQorCitzdGF0aWMgaW50CiBzY3NpcmVwb3J0bHVu cyhzdHJ1Y3QgY2FtX2RldmljZSAqZGV2aWNlLCBpbnQgYXJnYywgY2hhciAqKmFyZ3YsCiAJICAg ICAgIGNoYXIgKmNvbWJpbmVkb3B0LCBpbnQgcmV0cnlfY291bnQsIGludCB0aW1lb3V0KQogewpA QCAtNzM3MSw2ICs3NzcxLDkgQEAgdXNhZ2UoaW50IHByaW50bG9uZykKICIgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBbLVUgPHVzZXJ8bWFzdGVyPl0gWy15XVxuIgogIiAgICAgICAgY2Ft Y29udHJvbCBocGEgICAgICAgIFtkZXZfaWRdW2dlbmVyaWMgYXJnc10gWy1mXSBbLWxdIFstUF0g Wy1wIHB3ZF1cbiIKICIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbLXFdIFstcyBtYXhf c2VjdG9yc10gWy1VIHB3ZF0gWy15XVxuIgorIiAgICAgICAgY2FtY29udHJvbCBzYW5pdGl6ZSAg IFtkZXZfaWRdW2dlbmVyaWMgYXJnc11cbiIKKyIgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBbLWEgb3ZlcndyaXRlfGJsb2NrfGNyeXB0b3xleGl0ZmFpbHVyZV1cbiIKKyIgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBbLWMgY291bnRdWy1QIGZpbGVdWy1JXVstVV1bLXFdWy1yXVst d11bLXldXG4iCiAjZW5kaWYgLyogTUlOSU1BTElTVElDICovCiAiICAgICAgICBjYW1jb250cm9s IGhlbHBcbiIpOwogCWlmICghcHJpbnRsb25nKQpAQCAtNzUzMiw2ICs3OTM1LDE2IEBAIHVzYWdl KGludCBwcmludGxvbmcpCiAiICAgICAgICAgICAgICAgICAgZGV2aWNlXG4iCiAiLVUgcHdkICAg ICAgICAgICAgdW5sb2NrIHRoZSBIUEEgY29uZmlndXJhdGlvbiBvZiB0aGUgZGV2aWNlXG4iCiAi LXkgICAgICAgICAgICAgICAgZG9uJ3QgYXNrIGFueSBxdWVzdGlvbnNcbiIKKyJzYW5pdGl6ZSBh cmd1bWVudHM6XG4iCisiLWEgYWN0aW9uICAgICAgICAgc2VydmljZSBhY3Rpb24gbW9kZSAob3Zl cndyaXRlLCBibG9jaywgY3J5cHRvIG9yIGV4aXRmYWlsdXJlKVxuIgorIi1jIGNvdW50ICAgICAg ICAgIG92ZXJ3cml0ZSBwYXNzZXMgcGVyZm9ybWVkICgxIHRvIDMxKVxuIgorIi1QIGZpbGUgICAg ICAgICAgIG92ZXJ3cml0ZSBpbml0aWFsaXphdGlvbiBwYXR0ZXJuXG4iCisiLUkgICAgICAgICAg ICAgICAgaW52ZXJ0IG92ZXJ3cml0ZSBwYXR0ZXJuIGFmdGVyIGVhY2ggcGFzc1xuIgorIi1VICAg ICAgICAgICAgICAgIHNldCB1bnJlc3RyaWN0ZWQgc2FuaXRpemUgZXhpdCAoQVVTRSkgYml0XG4i CisiLXEgICAgICAgICAgICAgICAgYmUgcXVpZXQsIGRvbid0IHByaW50IHN0YXR1cyBtZXNzYWdl c1xuIgorIi1yICAgICAgICAgICAgICAgIHJ1biBpbiByZXBvcnQgb25seSBtb2RlXG4iCisiLXcg ICAgICAgICAgICAgICAgZG9uJ3Qgc2VuZCBpbW1lZGlhdGUgZm9ybWF0IGNvbW1hbmRcbiIKKyIt eSAgICAgICAgICAgICAgICBkb24ndCBhc2sgYW55IHF1ZXN0aW9uc1xuIgogKTsKICNlbmRpZiAv KiBNSU5JTUFMSVNUSUMgKi8KIH0KQEAgLTc4NjAsNiArODI3MywxMCBAQCBtYWluKGludCBhcmdj LCBjaGFyICoqYXJndikKIAkJCSAgICBhcmdsaXN0ICYgQ0FNX0FSR19WRVJCT1NFLCByZXRyeV9j b3VudCwgdGltZW91dCwKIAkJCSAgICBnZXRfZGlza190eXBlKGNhbV9kZXYpKTsKIAkJCWJyZWFr OworCQljYXNlIENBTV9DTURfU0FOSVRJWkU6CisJCQllcnJvciA9IHNjc2lzYW5pdGl6ZShjYW1f ZGV2LCBhcmdjLCBhcmd2LAorCQkJCQkgICAgIGNvbWJpbmVkb3B0LCByZXRyeV9jb3VudCwgdGlt ZW91dCk7CisJCQlicmVhazsKICNlbmRpZiAvKiBNSU5JTUFMSVNUSUMgKi8KIAkJY2FzZSBDQU1f Q01EX1VTQUdFOgogCQkJdXNhZ2UoMSk7CmRpZmYgLS1naXQgYS9zeXMvY2FtL3Njc2kvc2NzaV9k YS5jIGIvc3lzL2NhbS9zY3NpL3Njc2lfZGEuYwppbmRleCA4ZWU0N2Y5Li45MTM5NTFlIDEwMDY0 NAotLS0gYS9zeXMvY2FtL3Njc2kvc2NzaV9kYS5jCisrKyBiL3N5cy9jYW0vc2NzaS9zY3NpX2Rh LmMKQEAgLTM4NTEsNCArMzg1MSwzMSBAQCBzY3NpX2Zvcm1hdF91bml0KHN0cnVjdCBjY2Jfc2Nz aWlvICpjc2lvLCB1X2ludDMyX3QgcmV0cmllcywKIAkJICAgICAgdGltZW91dCk7CiB9CiAKK3Zv aWQKK3Njc2lfc2FuaXRpemUoc3RydWN0IGNjYl9zY3NpaW8gKmNzaW8sIHVfaW50MzJfdCByZXRy aWVzLAorCSAgICAgIHZvaWQgKCpjYmZjbnApKHN0cnVjdCBjYW1fcGVyaXBoICosIHVuaW9uIGNj YiAqKSwKKwkgICAgICB1X2ludDhfdCB0YWdfYWN0aW9uLCB1X2ludDhfdCBieXRlMiwgdV9pbnQx Nl90IGNvbnRyb2wsCisJICAgICAgdV9pbnQ4X3QgKmRhdGFfcHRyLCB1X2ludDMyX3QgZHhmZXJf bGVuLCB1X2ludDhfdCBzZW5zZV9sZW4sCisJICAgICAgdV9pbnQzMl90IHRpbWVvdXQpCit7CisJ c3RydWN0IHNjc2lfc2FuaXRpemUgKnNjc2lfY21kOworCisJc2NzaV9jbWQgPSAoc3RydWN0IHNj c2lfc2FuaXRpemUgKikmY3Npby0+Y2RiX2lvLmNkYl9ieXRlczsKKwlzY3NpX2NtZC0+b3Bjb2Rl ID0gU0FOSVRJWkU7CisJc2NzaV9jbWQtPmJ5dGUyID0gYnl0ZTI7CisJc2NzaV9jbWQtPmNvbnRy b2wgPSBjb250cm9sOworCXNjc2lfdWx0bzJiKGR4ZmVyX2xlbiwgc2NzaV9jbWQtPmxlbmd0aCk7 CisKKwljYW1fZmlsbF9jc2lvKGNzaW8sCisJCSAgICAgIHJldHJpZXMsCisJCSAgICAgIGNiZmNu cCwKKwkJICAgICAgLypmbGFncyovIChkeGZlcl9sZW4gPiAwKSA/IENBTV9ESVJfT1VUIDogQ0FN X0RJUl9OT05FLAorCQkgICAgICB0YWdfYWN0aW9uLAorCQkgICAgICBkYXRhX3B0ciwKKwkJICAg ICAgZHhmZXJfbGVuLAorCQkgICAgICBzZW5zZV9sZW4sCisJCSAgICAgIHNpemVvZigqc2NzaV9j bWQpLAorCQkgICAgICB0aW1lb3V0KTsKK30KKwogI2VuZGlmIC8qIF9LRVJORUwgKi8KZGlmZiAt LWdpdCBhL3N5cy9jYW0vc2NzaS9zY3NpX2RhLmggYi9zeXMvY2FtL3Njc2kvc2NzaV9kYS5oCmlu ZGV4IDU3OTkyMzguLjRmYmQ3MjUgMTAwNjQ0Ci0tLSBhL3N5cy9jYW0vc2NzaS9zY3NpX2RhLmgK KysrIGIvc3lzL2NhbS9zY3NpL3Njc2lfZGEuaApAQCAtMTE2LDYgKzExNiwzMSBAQCBzdHJ1Y3Qg c2NzaV9yZWFkX2RlZmVjdF9kYXRhXzEwCiAJdV9pbnQ4X3QgY29udHJvbDsKIH07CiAKK3N0cnVj dCBzY3NpX3Nhbml0aXplCit7CisJdV9pbnQ4X3Qgb3Bjb2RlOworCXVfaW50OF90IGJ5dGUyOwor I2RlZmluZSBTU1pfU0VSVklDRV9BQ1RJT05fT1ZFUldSSVRFICAgICAgICAgMHgwMQorI2RlZmlu ZSBTU1pfU0VSVklDRV9BQ1RJT05fQkxPQ0tfRVJBU0UgICAgICAgMHgwMgorI2RlZmluZSBTU1pf U0VSVklDRV9BQ1RJT05fQ1JZUFRPX0VSQVNFICAgICAgMHgwMworI2RlZmluZSBTU1pfU0VSVklD RV9BQ1RJT05fRVhJVF9NT0RFX0ZBSUxVUkUgMHgxRgorI2RlZmluZSBTU1pfVU5SRVNUUklDVEVE X0VYSVQgICAgICAgICAgICAgICAgMHgyMAorI2RlZmluZSBTU1pfSU1NRUQgICAgICAgICAgICAg ICAgICAgICAgICAgICAgMHg4MAorCXVfaW50OF90IHJlc2VydmVkWzVdOworCXVfaW50OF90IGxl bmd0aFsyXTsKKwl1X2ludDhfdCBjb250cm9sOworfTsKKworc3RydWN0IHNjc2lfc2FuaXRpemVf cGFyYW1ldGVyX2xpc3QKK3sKKwl1X2ludDhfdCBieXRlMTsKKyNkZWZpbmUgU1NaUExfSU5WRVJU IDB4ODAKKwl1X2ludDhfdCByZXNlcnZlZDsKKwl1X2ludDhfdCBsZW5ndGhbMl07CisJLyogVmFy aWFibGUgbGVuZ3RoIGluaXRpYWxpemF0aW9uIHBhdHRlcm4uICovCisjZGVmaW5lIFNTWlBMX01B WF9QQVRURVJOX0xFTkdUSCA2NTUzNQorfTsKKwogc3RydWN0IHNjc2lfcmVhZF9kZWZlY3RfZGF0 YV8xMgogewogCXVfaW50OF90IG9wY29kZTsKQEAgLTE1Niw2ICsxODEsNyBAQCBzdHJ1Y3Qgc2Nz aV9yZWFkX2RlZmVjdF9kYXRhXzEyCiAjZGVmaW5lCVdSSVRFX0FORF9WRVJJRlkJMHgyZQogI2Rl ZmluZQlWRVJJRlkJCQkweDJmCiAjZGVmaW5lIFJFQURfREVGRUNUX0RBVEFfMTAJMHgzNworI2Rl ZmluZSBTQU5JVElaRQkJMHg0OAogI2RlZmluZSBSRUFEX0RFRkVDVF9EQVRBXzEyCTB4YjcKIAog c3RydWN0IGZvcm1hdF9kZWZlY3RfbGlzdF9oZWFkZXIKQEAgLTUwOCw2ICs1MzQsMTIgQEAgdm9p ZCBzY3NpX2Zvcm1hdF91bml0KHN0cnVjdCBjY2Jfc2NzaWlvICpjc2lvLCB1X2ludDMyX3QgcmV0 cmllcywKIAkJICAgICAgdV9pbnQ4X3QgKmRhdGFfcHRyLCB1X2ludDMyX3QgZHhmZXJfbGVuLAog CQkgICAgICB1X2ludDhfdCBzZW5zZV9sZW4sIHVfaW50MzJfdCB0aW1lb3V0KTsKIAordm9pZCBz Y3NpX3Nhbml0aXplKHN0cnVjdCBjY2Jfc2NzaWlvICpjc2lvLCB1X2ludDMyX3QgcmV0cmllcywK KwkJICAgdm9pZCAoKmNiZmNucCkoc3RydWN0IGNhbV9wZXJpcGggKiwgdW5pb24gY2NiICopLAor CQkgICB1X2ludDhfdCB0YWdfYWN0aW9uLCB1X2ludDhfdCBieXRlMiwgdV9pbnQxNl90IGNvbnRy b2wsCisJCSAgIHVfaW50OF90ICpkYXRhX3B0ciwgdV9pbnQzMl90IGR4ZmVyX2xlbiwgdV9pbnQ4 X3Qgc2Vuc2VfbGVuLAorCQkgICB1X2ludDMyX3QgdGltZW91dCk7CisKICNlbmRpZiAvKiAhX0tF Uk5FTCAqLwogX19FTkRfREVDTFMKIAo= ------=_Part_3057_1096540079.1378394057331-- From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 15:44:10 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0583E3B1 for ; Thu, 5 Sep 2013 15:44:10 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from virtual.feral.com (virtual.feral.com [216.224.170.83]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BE6442AE3 for ; Thu, 5 Sep 2013 15:44:09 +0000 (UTC) Received: from spea.in1.lcl (lowell.feral.com [76.14.48.84]) by virtual.feral.com (8.14.4/8.14.4) with ESMTP id r85FgnL5014017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 5 Sep 2013 08:42:59 -0700 Received: from spea.in1.lcl (localhost [127.0.0.1]) by spea.in1.lcl (8.14.4/8.14.4) with ESMTP id r85FgmcD006847; Thu, 5 Sep 2013 08:42:48 -0700 Received: from localhost (mjacob@localhost) by spea.in1.lcl (8.14.4/8.14.4/Submit) with ESMTP id r85Fgmu2006843; Thu, 5 Sep 2013 08:42:48 -0700 Date: Thu, 5 Sep 2013 08:42:47 -0700 (PDT) From: Zorko To: Bryan Venteicher Subject: Re: camcontrol SCSI sanitize In-Reply-To: <1292769639.3059.1378394057334.JavaMail.root@daemoninthecloset.org> Message-ID: References: <1292769639.3059.1378394057334.JavaMail.root@daemoninthecloset.org> User-Agent: Alpine 2.03 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (virtual.feral.com [216.224.170.83]); Thu, 05 Sep 2013 08:43:00 -0700 (PDT) Cc: freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: mjacob@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 15:44:10 -0000 On Thu, 5 Sep 2013, Bryan Venteicher wrote: > Hi, > > Anybody with more SCSI experience than myself interested in > reviewing the attached patch that adds SCSI sanitize support > to camcontrol? It has been compiled tested on -current, but > a very similar patch works on 8.x. > > The time is short, but I wouldn't mind sneaking this into 10 > before the code freeze so I have one less local patch to deal > with later. > > http://people.freebsd.org/~bryanv/patches/camcontrol_sanitize.diff FWIW looks good to me. Ship It! From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 15:54:49 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 71A22DF1 for ; Thu, 5 Sep 2013 15:54:49 +0000 (UTC) (envelope-from ken@kdm.org) Received: from nargothrond.kdm.org (nargothrond.kdm.org [70.56.43.81]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3D9002BCC for ; Thu, 5 Sep 2013 15:54:49 +0000 (UTC) Received: from nargothrond.kdm.org (localhost [127.0.0.1]) by nargothrond.kdm.org (8.14.2/8.14.2) with ESMTP id r85FscG9033696; Thu, 5 Sep 2013 09:54:38 -0600 (MDT) (envelope-from ken@nargothrond.kdm.org) Received: (from ken@localhost) by nargothrond.kdm.org (8.14.2/8.14.2/Submit) id r85Fscfg033695; Thu, 5 Sep 2013 09:54:38 -0600 (MDT) (envelope-from ken) Date: Thu, 5 Sep 2013 09:54:38 -0600 From: "Kenneth D. Merry" To: Bryan Venteicher Subject: Re: camcontrol SCSI sanitize Message-ID: <20130905155438.GA33654@nargothrond.kdm.org> References: <1895443574.3014.1378393339664.JavaMail.root@daemoninthecloset.org> <1292769639.3059.1378394057334.JavaMail.root@daemoninthecloset.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1292769639.3059.1378394057334.JavaMail.root@daemoninthecloset.org> User-Agent: Mutt/1.4.2i Cc: freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 15:54:49 -0000 On Thu, Sep 05, 2013 at 10:14:17 -0500, Bryan Venteicher wrote: > Hi, > > Anybody with more SCSI experience than myself interested in > reviewing the attached patch that adds SCSI sanitize support > to camcontrol? It has been compiled tested on -current, but > a very similar patch works on 8.x. > > The time is short, but I wouldn't mind sneaking this into 10 > before the code freeze so I have one less local patch to deal > with later. > > http://people.freebsd.org/~bryanv/patches/camcontrol_sanitize.diff Looks good, and pretty much how I would do it. Check it in! Ken -- Kenneth Merry ken@FreeBSD.ORG From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 17:48:39 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0DE483A1 for ; Thu, 5 Sep 2013 17:48:39 +0000 (UTC) (envelope-from prvs=19600282c8=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A400823DA for ; Thu, 5 Sep 2013 17:48:38 +0000 (UTC) Received: from r2d2 ([82.69.141.170]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50005863501.msg for ; Thu, 05 Sep 2013 18:48:28 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Thu, 05 Sep 2013 18:48:28 +0100 (not processed: message from valid local sender) X-MDDKIM-Result: neutral (mail1.multiplay.co.uk) X-MDRemoteIP: 82.69.141.170 X-Return-Path: prvs=19600282c8=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk X-MDaemon-Deliver-To: freebsd-scsi@freebsd.org Message-ID: From: "Steven Hartland" To: "Bryan Venteicher" , References: <1292769639.3059.1378394057334.JavaMail.root@daemoninthecloset.org> Subject: Re: camcontrol SCSI sanitize Date: Thu, 5 Sep 2013 18:48:45 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 17:48:39 -0000 ----- Original Message ----- From: "Bryan Venteicher" To: Sent: Thursday, September 05, 2013 4:14 PM Subject: camcontrol SCSI sanitize > Hi, > > Anybody with more SCSI experience than myself interested in > reviewing the attached patch that adds SCSI sanitize support > to camcontrol? It has been compiled tested on -current, but > a very similar patch works on 8.x. > > The time is short, but I wouldn't mind sneaking this into 10 > before the code freeze so I have one less local patch to deal > with later. > > http://people.freebsd.org/~bryanv/patches/camcontrol_sanitize.diff Might be an idea to take the lead set by fwdownload and split each new command off into its own file? Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk. From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 17:55:07 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 185C0C5E; Thu, 5 Sep 2013 17:55:07 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-ob0-x236.google.com (mail-ob0-x236.google.com [IPv6:2607:f8b0:4003:c01::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8F97B2466; Thu, 5 Sep 2013 17:55:06 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id wo10so2317455obc.41 for ; Thu, 05 Sep 2013 10:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=jdn9NyYiVN0ndjJomcjRFSLPXdSkDafBQ0fciSN+EwY=; b=m1keMMsRigmcbQ/jF4zWCLSGBvQbmEKgC14Fiv9HZeQFWlPLpZWm4y6ytZ1jhvyj/6 km5PFaZEJGoqhK55iZHdauGvW/8jzcd799ln0h9vLobCns3v5SDzAQeDC1c2pHBtbqHI e1zemETHX6VVMqFFmFvF0JLMTyhKbCWCJ3KpVBPTNcr+k+d5uCXRcarlT4YiyeZY+xtk HCF/Wr4LYWORTynYjYJtijRmTcC/14zo+7v/FEg0ADHmqMk4pDd+9WMU1aMA5xrwVOvt 5eVjtPv7QbKbRkcZrZMAwUt3gAEOSVQ9jagyykNF5QdX2hKocm/aPrmADwac9wOJaiGh FadA== MIME-Version: 1.0 X-Received: by 10.182.53.138 with SMTP id b10mr6843404obp.66.1378403705859; Thu, 05 Sep 2013 10:55:05 -0700 (PDT) Received: by 10.76.114.227 with HTTP; Thu, 5 Sep 2013 10:55:05 -0700 (PDT) In-Reply-To: References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> Date: Thu, 5 Sep 2013 13:55:05 -0400 Message-ID: Subject: Re: New iSCSI stack. From: Outback Dingo To: Ivan Voras Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-scsi@freebsd.org, FreeBSD-Current , freebsd-arch@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 17:55:07 -0000 On Thu, Sep 5, 2013 at 8:02 AM, Ivan Voras wrote: > On 5 September 2013 14:00, Edward Tomasz Napiera=B3a > wrote: > > Wiadomo=B6=E6 napisana przez Ivan Voras w dniu 5 w= rz > 2013, o godz. 13:18: > >> On 05/09/2013 12:27, Edward Tomasz Napiera=B3a wrote: > >>> Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diffyou'= ll find > >>> a patch which adds the new iSCSI initiator and target, against > 10-CURRENT. > >>> To use the new initiator, start with "man iscsictl". For the target = - > "man > >>> ctld". > >> > >> Just a naming question: "ctld" could mean anything, I'd parse it as a > >> "control deamon" or something like that. Could you name it something > >> which reminds the user of iscsi? Like iscsictld? > > > > As the man page says, ctld is "CAM Target Layer / iSCSI target daemon". > > Sure, right now it's pretty iSCSI-specific, but it doesn't need to be - > it can > > be extended to just manage CTL configuration (e.g. for Fibre Channel), > > or to support other CTL-backed storage protocols, such as FCoE. > > > > It's just a helper daemon for ctl(4) - thus, ctld(8). And in case > someone > > does "man -k iscsi", there is the "iSCSI target" in the manual page > title. > > Thanks, you're right! > Is it me, or is this patch mangled and does not apply cleanly to CURRENT > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " > From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 18:01:09 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 92F6B5D1; Thu, 5 Sep 2013 18:01:09 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-oa0-x230.google.com (mail-oa0-x230.google.com [IPv6:2607:f8b0:4003:c02::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 27A6A2501; Thu, 5 Sep 2013 18:01:09 +0000 (UTC) Received: by mail-oa0-f48.google.com with SMTP id o17so2643746oag.21 for ; Thu, 05 Sep 2013 11:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ViwHB0zlWaqMV3VEThhL6H/VZ4sODZCvDr20xzDcUiE=; b=kwjVB6jdrq+TJ9qVzhm0DRLxrKq3/OUIG6zHeBZruEYbMGBjkNSG7nDL9bDr1dAbdO 2f10g0yST1pdzO8hh6/nLLylog426dibyv9QsjpBNeaoLboAeWGWMUuA8llPXXuYEiBH 8bmElUwkMFsVVjr1AGrg7MReoJ9mR6FcKxQ4Om0CcCxRZu4HNCGoKZYF/VvZxTZa2Qtd 0erqsGu/UBELuvAUuHgRAs8wSiZvaIP3QerYecAaYgE3z/b4nTr159I1dVsUyr2x3JG3 ec6iDiVivvmeKXD3/ZjcO3aizHsLfn5I83APlfr/NuRMyCljyTm7CSaRfFP6pqLOYBaB MelA== MIME-Version: 1.0 X-Received: by 10.60.133.71 with SMTP id pa7mr7428179oeb.44.1378404068290; Thu, 05 Sep 2013 11:01:08 -0700 (PDT) Received: by 10.76.114.227 with HTTP; Thu, 5 Sep 2013 11:01:08 -0700 (PDT) In-Reply-To: References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> Date: Thu, 5 Sep 2013 14:01:08 -0400 Message-ID: Subject: Re: New iSCSI stack. From: Outback Dingo To: Ivan Voras Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-scsi@freebsd.org, FreeBSD-Current , freebsd-arch@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 18:01:09 -0000 On Thu, Sep 5, 2013 at 1:55 PM, Outback Dingo wrote= : > > > > On Thu, Sep 5, 2013 at 8:02 AM, Ivan Voras wrote: > >> On 5 September 2013 14:00, Edward Tomasz Napiera=B3a >> wrote: >> > Wiadomo=B6=E6 napisana przez Ivan Voras w dniu 5 = wrz >> 2013, o godz. 13:18: >> >> On 05/09/2013 12:27, Edward Tomasz Napiera=B3a wrote: >> >>> Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diffyou= 'll find >> >>> a patch which adds the new iSCSI initiator and target, against >> 10-CURRENT. >> >>> To use the new initiator, start with "man iscsictl". For the target >> - "man >> >>> ctld". >> >> >> >> Just a naming question: "ctld" could mean anything, I'd parse it as a >> >> "control deamon" or something like that. Could you name it something >> >> which reminds the user of iscsi? Like iscsictld? >> > >> > As the man page says, ctld is "CAM Target Layer / iSCSI target daemon"= . >> > Sure, right now it's pretty iSCSI-specific, but it doesn't need to be = - >> it can >> > be extended to just manage CTL configuration (e.g. for Fibre Channel), >> > or to support other CTL-backed storage protocols, such as FCoE. >> > >> > It's just a helper daemon for ctl(4) - thus, ctld(8). And in case >> someone >> > does "man -k iscsi", there is the "iSCSI target" in the manual page >> title. >> >> Thanks, you're right! >> > > Nevermind.... > Is it me, or is this patch mangled and does not apply cleanly to CURRENT > > > _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.or= g >> " >> > > From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 18:34:41 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id BDE1056B; Thu, 5 Sep 2013 18:34:41 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) by mx1.freebsd.org (Postfix) with ESMTP id 48A102762; Thu, 5 Sep 2013 18:34:41 +0000 (UTC) Received: from slw by zxy.spb.ru with local (Exim 4.69 (FreeBSD)) (envelope-from ) id 1VHeQ9-00095s-FJ; Thu, 05 Sep 2013 22:36:45 +0400 Date: Thu, 5 Sep 2013 22:36:45 +0400 From: Slawa Olhovchenkov To: Edward Tomasz Napiera?a Subject: Re: New iSCSI stack. Message-ID: <20130905183645.GA34714@zxy.spb.ru> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false Cc: freebsd-scsi@freebsd.org, "freebsd-current@FreeBSD.org" , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 18:34:41 -0000 On Thu, Sep 05, 2013 at 12:27:12PM +0200, Edward Tomasz Napiera?a wrote: > Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diff you'll find > a patch which adds the new iSCSI initiator and target, against 10-CURRENT. > To use the new initiator, start with "man iscsictl". For the target - "man > ctld". > > All feedback is welcome. If nothing unexpected comes up, I'll commit it > in a few days from now. Note that it's still not optimized; at this point > I'm focusing more on reliability and interoperability. I (as you probaly know) use cfiscsi-20130426.diff in producrion. Nice! Sorry, I don't have hardware for test cfiscsi-20130904.diff. From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 18:47:12 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7714AC50; Thu, 5 Sep 2013 18:47:12 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 312852856; Thu, 5 Sep 2013 18:47:11 +0000 (UTC) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 0D88628429; Thu, 5 Sep 2013 20:47:04 +0200 (CEST) Received: from [192.168.1.2] (ip-89-177-49-222.net.upcbroadband.cz [89.177.49.222]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id D345E28426; Thu, 5 Sep 2013 20:47:02 +0200 (CEST) Message-ID: <5228D1A6.4020405@quip.cz> Date: Thu, 05 Sep 2013 20:47:02 +0200 From: Miroslav Lachman <000.fbsd@quip.cz> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1.19) Gecko/20110420 Lightning/1.0b1 SeaMonkey/2.0.14 MIME-Version: 1.0 To: =?ISO-8859-2?Q?Edward_Tomasz_Napiera=B3a?= Subject: Re: New iSCSI stack. References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> In-Reply-To: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-scsi@freebsd.org, freebsd-current@freebsd.org, Ivan Voras , freebsd-arch@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 18:47:12 -0000 Edward Tomasz Napiera³a wrote: > Wiadomo¶æ napisana przez Ivan Voras w dniu 5 wrz 2013, o godz. 13:18: >> On 05/09/2013 12:27, Edward Tomasz Napiera³a wrote: >>> Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diff you'll find >>> a patch which adds the new iSCSI initiator and target, against 10-CURRENT. >>> To use the new initiator, start with "man iscsictl". For the target - "man >>> ctld". >> >> Just a naming question: "ctld" could mean anything, I'd parse it as a >> "control deamon" or something like that. Could you name it something >> which reminds the user of iscsi? Like iscsictld? > > As the man page says, ctld is "CAM Target Layer / iSCSI target daemon". > Sure, right now it's pretty iSCSI-specific, but it doesn't need to be - it can > be extended to just manage CTL configuration (e.g. for Fibre Channel), > or to support other CTL-backed storage protocols, such as FCoE. > > It's just a helper daemon for ctl(4) - thus, ctld(8). And in case someone > does "man -k iscsi", there is the "iSCSI target" in the manual page title. I understand your explanation, but still thinking rc.conf variables are really confusing and unintuitive: iscsid_enable iscsictl_enable ctld_enable I cannot tell what they control just by their names and the same apply for services names. "If I want to restart iscsi target, should I use 'service iscsid restart' or 'service iscsictl restart'? ... oh wait, it should be 'service ctld restart'" I think it should be more user friendly. Something as Apache 2.2.x has httpd and httpd.conf, but users are using 'service apache22 restart' and 'apache22_enable="YES"', because there can be more "http" daemons. My $0.02 Miroslav Lachman From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 20:03:32 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 74072A99; Thu, 5 Sep 2013 20:03:32 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-ob0-x22f.google.com (mail-ob0-x22f.google.com [IPv6:2607:f8b0:4003:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 07BEB2CF3; Thu, 5 Sep 2013 20:03:31 +0000 (UTC) Received: by mail-ob0-f175.google.com with SMTP id xn12so2554492obc.34 for ; Thu, 05 Sep 2013 13:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=SHaFvhh8lssvSKV1E4SsAt8zp2JwoN3gARZAmmVmxOo=; b=JY6G+5yaf2npmPH7WETXgYB5SeUBs7r1No9FZn8BC+Ow4caV2MUFrUXna+vBVpHwlg oe/z1Fr7naF4pzBAgJq8Kcavqp4EDgBv2XVPkAGVr0ViZeSp6jPhchX0ByQtwQeI+4dM co4dW7s51O+iA5vhfLWfpPC+E856hu2+qSuxPlHZdiwlIvka3SJumuBA0LMctoo7sLqq rqkPgYcV15yLgoniJQSf5XwDpudh8WocC0heLmhD3LAQaY8lZ37wDzeOmKMNwbAxtBq2 Nl18lRc1Gw0+36KV0awj0rCZpCxsza3nCZUo0BWKf2m28ePv34ympne4Lej89GtnButP i3WQ== MIME-Version: 1.0 X-Received: by 10.182.101.198 with SMTP id fi6mr7741772obb.79.1378411411115; Thu, 05 Sep 2013 13:03:31 -0700 (PDT) Received: by 10.76.114.227 with HTTP; Thu, 5 Sep 2013 13:03:31 -0700 (PDT) In-Reply-To: <5228D1A6.4020405@quip.cz> References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> <5228D1A6.4020405@quip.cz> Date: Thu, 5 Sep 2013 16:03:31 -0400 Message-ID: Subject: Re: New iSCSI stack. From: Outback Dingo To: Miroslav Lachman <000.fbsd@quip.cz> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-scsi@freebsd.org, freebsd-current@freebsd.org, Ivan Voras , freebsd-arch@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 20:03:32 -0000 On Thu, Sep 5, 2013 at 2:47 PM, Miroslav Lachman <000.fbsd@quip.cz> wrote: > Edward Tomasz Napiera=B3a wrote: > >> Wiadomo=B6=E6 napisana przez Ivan Voras w dniu 5 wr= z >> 2013, o godz. 13:18: >> >>> On 05/09/2013 12:27, Edward Tomasz Napiera=B3a wrote: >>> >>>> Hello. At http://people.freebsd.org/~**trasz/cfiscsi-20130904.diffyou'll find >>>> a patch which adds the new iSCSI initiator and target, against >>>> 10-CURRENT. >>>> To use the new initiator, start with "man iscsictl". For the target - >>>> "man >>>> ctld". >>>> >>> >>> Just a naming question: "ctld" could mean anything, I'd parse it as a >>> "control deamon" or something like that. Could you name it something >>> which reminds the user of iscsi? Like iscsictld? >>> >> >> As the man page says, ctld is "CAM Target Layer / iSCSI target daemon". >> Sure, right now it's pretty iSCSI-specific, but it doesn't need to be - >> it can >> be extended to just manage CTL configuration (e.g. for Fibre Channel), >> or to support other CTL-backed storage protocols, such as FCoE. >> >> It's just a helper daemon for ctl(4) - thus, ctld(8). And in case someo= ne >> does "man -k iscsi", there is the "iSCSI target" in the manual page titl= e. >> > > I understand your explanation, but still thinking rc.conf variables are > really confusing and unintuitive: > > iscsid_enable > iscsictl_enable > ctld_enable > > I cannot tell what they control just by their names and the same apply fo= r > services names. > > "If I want to restart iscsi target, should I use 'service iscsid restart' > or 'service iscsictl restart'? ... oh wait, it should be 'service ctld > restart'" > > I think it should be more user friendly. Something as Apache 2.2.x has > httpd and httpd.conf, but users are using 'service apache22 restart' and > 'apache22_enable=3D"YES"', because there can be more "http" daemons. > > My $0.02 > > Just an FYI 10_CURRENT svn info Path: . Working Copy Root Path: /usr/src URL: http://svn.freebsd.org/base/head Relative URL: ^/head Repository Root: http://svn.freebsd.org/base Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f Revision: 255253 Node Kind: directory Schedule: normal Last Changed Author: sjg Last Changed Rev: 255253 Last Changed Date: 2013-09-05 11:57:26 -0400 (Thu, 05 Sep 2013) cc -O2 -pipe -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 -Qunused-argument= s -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/ctld.c cc -O2 -pipe -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 -Qunused-argument= s -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/discovery.c cc -O2 -pipe -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 -Qunused-argument= s -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/kernel.c /usr/src/usr.sbin/ctld/kernel.c:762:35: error: incompatible integer to pointer conversion passing 'unsigned long long' to parameter of type 'const cap_rights_t *' (aka 'const struct cap_rights *') [-Werror,-Wint-conversion= ] error =3D cap_rights_limit(ctl_fd, CAP_IOCTL); ^~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:197:20: note: expanded from macro 'CAP_IOCTL' #define CAP_IOCTL CAPRIGHT(1, 0x0000000000000080ULL) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:53:28: note: expanded from macro 'CAPRIGHT' #define CAPRIGHT(idx, bit) ((1ULL << (57 + (idx))) | (bit)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:327:50: note: passing argument to parameter 'rights' here int cap_rights_limit(int fd, const cap_rights_t *rights); ^ 1 error generated. *** Error code 1 Stop. make[4]: stopped in /usr/src/usr.sbin/ctld > Miroslav Lachman > > ______________________________**_________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/**mailman/listinfo/freebsd-**current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@** > freebsd.org " > From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 21:04:48 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 69C203B0; Thu, 5 Sep 2013 21:04:48 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EE051207B; Thu, 5 Sep 2013 21:04:47 +0000 (UTC) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.80.1) with esmtp (envelope-from ) id <1VHgjM-003VX2-P6>; Thu, 05 Sep 2013 23:04:44 +0200 Received: from g231087154.adsl.alicedsl.de ([92.231.87.154] helo=munin.geoinf.fu-berlin.de) by inpost2.zedat.fu-berlin.de (Exim 4.80.1) with esmtpsa (envelope-from ) id <1VHgjM-002DxU-K1>; Thu, 05 Sep 2013 23:04:44 +0200 Date: Thu, 5 Sep 2013 23:09:07 +0200 From: "O. Hartmann" To: Outback Dingo Subject: Re: New iSCSI stack. Message-ID: <20130905230907.179efafd@munin.geoinf.fu-berlin.de> In-Reply-To: References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> <5228D1A6.4020405@quip.cz> Organization: FU Berlin X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.19; amd64-portbld-freebsd9.2) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/IesW3td1jyGsyiR40aYBXUA"; protocol="application/pgp-signature" X-Originating-IP: 92.231.87.154 Cc: Miroslav Lachman <000.fbsd@quip.cz>, freebsd-current@freebsd.org, Ivan Voras , freebsd-arch@freebsd.org, freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 21:04:48 -0000 --Sig_/IesW3td1jyGsyiR40aYBXUA Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable On Thu, 5 Sep 2013 16:03:31 -0400 Outback Dingo wrote: > On Thu, Sep 5, 2013 at 2:47 PM, Miroslav Lachman <000.fbsd@quip.cz> > wrote: >=20 > > Edward Tomasz Napiera=B3a wrote: > > > >> Wiadomo=B6=E6 napisana przez Ivan Voras w dniu 5 > >> wrz 2013, o godz. 13:18: > >> > >>> On 05/09/2013 12:27, Edward Tomasz Napiera=B3a wrote: > >>> > >>>> Hello. At > >>>> http://people.freebsd.org/~**trasz/cfiscsi-20130904.diffyou'll > >>>> find a patch which adds the new iSCSI initiator and target, > >>>> against 10-CURRENT. To use the new initiator, start with "man > >>>> iscsictl". For the target - "man > >>>> ctld". > >>>> > >>> > >>> Just a naming question: "ctld" could mean anything, I'd parse it > >>> as a "control deamon" or something like that. Could you name it > >>> something which reminds the user of iscsi? Like iscsictld? > >>> > >> > >> As the man page says, ctld is "CAM Target Layer / iSCSI target > >> daemon". Sure, right now it's pretty iSCSI-specific, but it > >> doesn't need to be - it can > >> be extended to just manage CTL configuration (e.g. for Fibre > >> Channel), or to support other CTL-backed storage protocols, such > >> as FCoE. > >> > >> It's just a helper daemon for ctl(4) - thus, ctld(8). And in case > >> someone does "man -k iscsi", there is the "iSCSI target" in the > >> manual page title. > >> > > > > I understand your explanation, but still thinking rc.conf variables > > are really confusing and unintuitive: > > > > iscsid_enable > > iscsictl_enable > > ctld_enable > > > > I cannot tell what they control just by their names and the same > > apply for services names. > > > > "If I want to restart iscsi target, should I use 'service iscsid > > restart' or 'service iscsictl restart'? ... oh wait, it should be > > 'service ctld restart'" > > > > I think it should be more user friendly. Something as Apache 2.2.x > > has httpd and httpd.conf, but users are using 'service apache22 > > restart' and 'apache22_enable=3D"YES"', because there can be more > > "http" daemons. > > > > My $0.02 > > > > > Just an FYI 10_CURRENT svn info > Path: . > Working Copy Root Path: /usr/src > URL: http://svn.freebsd.org/base/head > Relative URL: ^/head > Repository Root: http://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 255253 > Node Kind: directory > Schedule: normal > Last Changed Author: sjg > Last Changed Rev: 255253 > Last Changed Date: 2013-09-05 11:57:26 -0400 (Thu, 05 Sep 2013) >=20 >=20 > cc -O2 -pipe -I/usr/src/usr.sbin/ctld > -I/usr/src/usr.sbin/ctld/../../sys > -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl > -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 > -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall > -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual > -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > -Wold-style-definition -Wno-pointer-sign -Wno-empty-body > -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/ctld.c cc -O2 -pipe > -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys > -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl > -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 > -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall > -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual > -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > -Wold-style-definition -Wno-pointer-sign -Wno-empty-body > -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/discovery.c cc -O2 > -pipe -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys > -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl > -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 > -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall > -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual > -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > -Wold-style-definition -Wno-pointer-sign -Wno-empty-body > -Wno-string-plus-int > -c /usr/src/usr.sbin/ctld/kernel.c /usr/src/usr.sbin/ctld/kernel.c:762:35: > error: incompatible integer to pointer conversion passing 'unsigned > long long' to parameter of type 'const cap_rights_t *' (aka 'const > struct cap_rights *') [-Werror,-Wint-conversion] error =3D > cap_rights_limit(ctl_fd, CAP_IOCTL); > ^~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:197:20: > note: expanded from macro 'CAP_IOCTL' #define CAP_IOCTL > CAPRIGHT(1, 0x0000000000000080ULL) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/c= apability.h:53:28: > note: expanded from macro 'CAPRIGHT' #define CAPRIGHT(idx, bit) > ((1ULL << (57 + (idx))) | (bit)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/cap= ability.h:327:50: > note: passing argument to parameter 'rights' here int > cap_rights_limit(int fd, const cap_rights_t *rights); ^ 1 error > generated. *** Error code 1 >=20 > Stop. > make[4]: stopped in /usr/src/usr.sbin/ctld >=20 >=20 >=20 > > Miroslav Lachman > > > > ______________________________**_________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/**mailman/listinfo/freebsd-**current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@** > > freebsd.org " > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org" I get the very same mysterious error when compiling port x11/nvidia-driver: --- nvidia_linux.o --- nvidia_linux.c:42:37: error: incompatible integer to pointer conversion passing 'unsigned long long' to parameter of type 'cap_rights_t *' (aka 'struct cap_rights *') [-Werror,-Wint-conversion] if ((error =3D fget(td, args->fd, CAP_IOCTL, &fp)) !=3D 0) ^~~~~~~~~ @/sys/capability.h:197:20: note: expanded from macro 'CAP_IOCTL' #define CAP_IOCTL CAPRIGHT(1, 0x0000000000000080ULL) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @/sys/capability.h:53:28: note: expanded from macro 'CAPRIGHT' #define CAPRIGHT(idx, bit) ((1ULL << (57 + (idx))) | (bit)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @/sys/file.h:220:51: note: passing argument to parameter 'rightsp' here int fget(struct thread *td, int fd, cap_rights_t *rightsp, struct file **fpp); This from CURRENT > r255211, I'm with=20 FreeBSD 10.0-CURRENT #1 r255249: Thu Sep 5 16:42:56 CEST 2013 amd64 and on another box it is FreeBSD 10.0-CURRENT #3 r255259: Thu Sep 5 20:31:20 CEST 2013 amd64 --Sig_/IesW3td1jyGsyiR40aYBXUA Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQEcBAEBAgAGBQJSKPL4AAoJEOgBcD7A/5N8lgkIAICQicFshE1wSG98kTQXTjwT 5SCD9t1bqcbVuPkt/f5dLjWEw1A7C/OUNUE9ZDmy6vVWeaJQxvbjbjvGd0nRxIPs uolOV3M/IAcMoy5PHe+cipIwRnFwDatSlhhfPGTydtumZR68tQFRJQ+zHETQavvT Q0x826CMrqIQajtbMDvYVskRY3c+qSMbZ5gOSxTn+8oigyu8L7GWuCQP7a3pzv5Z ribikDErlbUWREclBe2lufzyy0eo9WCl6CPDfgedJp3tfsl4XvgJV5ySpsE+u5Ud H0eJUzxzvBXo+pfLpWkfUqMvPUkdD6rKR59FKRd57YpGZ/1rPPKmeaEHSlRvFlA= =2acO -----END PGP SIGNATURE----- --Sig_/IesW3td1jyGsyiR40aYBXUA-- From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 21:09:00 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B95D76B3; Thu, 5 Sep 2013 21:09:00 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ee0-x22b.google.com (mail-ee0-x22b.google.com [IPv6:2a00:1450:4013:c00::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CA41B20B3; Thu, 5 Sep 2013 21:08:59 +0000 (UTC) Received: by mail-ee0-f43.google.com with SMTP id e52so1181348eek.30 for ; Thu, 05 Sep 2013 14:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0XBSyq/JQdOfKE1tUSxLEhObAMe41PhDk1PD1y0ExIQ=; b=MW20spU+ulzqmjsItyW1RCwZ/035K4Idj19TRCc2/LcSZKzmCcX2pW8nalhzn9PYKg sOIUPpq+JIvL/KZ1TmK+4D1sLFganpvj6ExMaikiN92MFj+SZShlkQUIKr3gyPZAPJvp RydPyenRGuHoIcAFl1gtl9L99EwMXeGGWx2Mw2q9LDJ5CTtlBIcspeKSEwyfisi2dBuj 8ZlLymIhv8xO8p+Ij9ySuGs3/DZ895qDrbmZDx5K3R5rHKJp2wFRTlPF6zDkKS9moonx ew0I0IGofmH+UPMZHj4qIdkKTOOmy/7r64ecRaIeECxsVyudJZY0BpgErie0XtUpk7me NXbw== X-Received: by 10.14.87.135 with SMTP id y7mr515245eee.69.1378414969783; Thu, 05 Sep 2013 14:02:49 -0700 (PDT) Received: from [192.168.1.102] (ajg161.neoplus.adsl.tpnet.pl. [83.25.240.161]) by mx.google.com with ESMTPSA id b45sm51836694eef.4.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Sep 2013 14:02:49 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Content-Type: text/plain; charset=iso-8859-2 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: New iSCSI stack. From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= In-Reply-To: Date: Thu, 5 Sep 2013 23:02:47 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <240FF3FA-E757-417A-B08A-4413533A34D1@freebsd.org> References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> <5228D1A6.4020405@quip.cz> To: Outback Dingo X-Mailer: Apple Mail (2.1508) Cc: freebsd-scsi@freebsd.org, freebsd-arch@freebsd.org, freebsd-current@freebsd.org, Miroslav Lachman <000.fbsd@quip.cz>, Ivan Voras X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 21:09:00 -0000 Wiadomo=B6=E6 napisana przez Outback Dingo w = dniu 5 wrz 2013, o godz. 22:03: >=20 > On Thu, Sep 5, 2013 at 2:47 PM, Miroslav Lachman <000.fbsd@quip.cz> = wrote: > Edward Tomasz Napiera=B3a wrote: > Wiadomo=B6=E6 napisana przez Ivan Voras w dniu 5 = wrz 2013, o godz. 13:18: > On 05/09/2013 12:27, Edward Tomasz Napiera=B3a wrote: > Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diff = you'll find > a patch which adds the new iSCSI initiator and target, against = 10-CURRENT. > To use the new initiator, start with "man iscsictl". For the target - = "man > ctld". >=20 > Just a naming question: "ctld" could mean anything, I'd parse it as a > "control deamon" or something like that. Could you name it something > which reminds the user of iscsi? Like iscsictld? >=20 > As the man page says, ctld is "CAM Target Layer / iSCSI target = daemon". > Sure, right now it's pretty iSCSI-specific, but it doesn't need to be = - it can > be extended to just manage CTL configuration (e.g. for Fibre Channel), > or to support other CTL-backed storage protocols, such as FCoE. >=20 > It's just a helper daemon for ctl(4) - thus, ctld(8). And in case = someone > does "man -k iscsi", there is the "iSCSI target" in the manual page = title. >=20 > I understand your explanation, but still thinking rc.conf variables = are really confusing and unintuitive: >=20 > iscsid_enable > iscsictl_enable > ctld_enable >=20 > I cannot tell what they control just by their names and the same apply = for services names. >=20 > "If I want to restart iscsi target, should I use 'service iscsid = restart' or 'service iscsictl restart'? ... oh wait, it should be = 'service ctld restart'" >=20 > I think it should be more user friendly. Something as Apache 2.2.x has = httpd and httpd.conf, but users are using 'service apache22 restart' and = 'apache22_enable=3D"YES"', because there can be more "http" daemons. >=20 > My $0.02 >=20 >=20 > Just an FYI 10_CURRENT svn info > Path: . > Working Copy Root Path: /usr/src > URL: http://svn.freebsd.org/base/head > Relative URL: ^/head > Repository Root: http://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 255253 > Node Kind: directory > Schedule: normal > Last Changed Author: sjg > Last Changed Rev: 255253 > Last Changed Date: 2013-09-05 11:57:26 -0400 (Thu, 05 Sep 2013) >=20 >=20 > cc -O2 -pipe -I/usr/src/usr.sbin/ctld = -I/usr/src/usr.sbin/ctld/../../sys = -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl = -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 = -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall = -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes = -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual = -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align = -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls = -Wold-style-definition -Wno-pointer-sign -Wno-empty-body = -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/ctld.c > cc -O2 -pipe -I/usr/src/usr.sbin/ctld = -I/usr/src/usr.sbin/ctld/../../sys = -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl = -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 = -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall = -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes = -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual = -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align = -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls = -Wold-style-definition -Wno-pointer-sign -Wno-empty-body = -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/discovery.c > cc -O2 -pipe -I/usr/src/usr.sbin/ctld = -I/usr/src/usr.sbin/ctld/../../sys = -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl = -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 = -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall = -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes = -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual = -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align = -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls = -Wold-style-definition -Wno-pointer-sign -Wno-empty-body = -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/kernel.c > /usr/src/usr.sbin/ctld/kernel.c:762:35: error: incompatible integer to = pointer conversion passing 'unsigned long long' to parameter of type = 'const cap_rights_t *' (aka 'const struct cap_rights *') = [-Werror,-Wint-conversion] > error =3D cap_rights_limit(ctl_fd, CAP_IOCTL); > ^~~~~~~~~ > /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:197:20: note: = expanded from macro 'CAP_IOCTL' > #define CAP_IOCTL CAPRIGHT(1, 0x0000000000000080ULL) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:53:28: note: = expanded from macro 'CAPRIGHT' > #define CAPRIGHT(idx, bit) ((1ULL << (57 + (idx))) | (bit)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:327:50: note: = passing argument to parameter 'rights' here > int cap_rights_limit(int fd, const cap_rights_t *rights); Yeah, broken by Capsicum changes committed earlier today. I'll update = the patch soon. >=20 From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 22:19:31 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7E479CC0; Thu, 5 Sep 2013 22:19:31 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-ob0-x234.google.com (mail-ob0-x234.google.com [IPv6:2607:f8b0:4003:c01::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1057E243F; Thu, 5 Sep 2013 22:19:31 +0000 (UTC) Received: by mail-ob0-f180.google.com with SMTP id v19so2645230obq.25 for ; Thu, 05 Sep 2013 15:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ttsP6+OZ0Nd+abx3B4H11+ygW9csLZO3KHjuvbT87Ks=; b=RmWwClurn4ft0MQOOZ2Q7AONzdd0d1ILlsVPyemkjVYfaF4BVN5a7N1ZxPe8JeQi1r S48kRN+UmURvn5hWPbXaN5aKZPulrj9qH9QtnHJDNoCgWtoKq6EElEEi9DA5gLIskQia +D5XywCSxKSauTThdNHRB6Cz7KrYTuQMsg64PH/f0WqMmo40lZO/5tec0jSEGj/nD3+5 tPKIKKbD4N01qLxg6n+T+WA6gA468FuzglC9x6XUH35H0LzBiZIbRbnXees2YppbzbTX DcopY3O1jwHcR/ndYtpKTAoKMhqEoCGTB+hNuIlTY7GvOzM27l/m+kT/AIrOnuJL0XMt Coew== MIME-Version: 1.0 X-Received: by 10.182.51.132 with SMTP id k4mr8193766obo.101.1378419570236; Thu, 05 Sep 2013 15:19:30 -0700 (PDT) Received: by 10.76.114.227 with HTTP; Thu, 5 Sep 2013 15:19:30 -0700 (PDT) In-Reply-To: <20130905230907.179efafd@munin.geoinf.fu-berlin.de> References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> <5228D1A6.4020405@quip.cz> <20130905230907.179efafd@munin.geoinf.fu-berlin.de> Date: Thu, 5 Sep 2013 18:19:30 -0400 Message-ID: Subject: Re: New iSCSI stack. From: Outback Dingo To: "O. Hartmann" Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Miroslav Lachman <000.fbsd@quip.cz>, freebsd-current@freebsd.org, Ivan Voras , freebsd-arch@freebsd.org, freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 22:19:31 -0000 On Thu, Sep 5, 2013 at 5:09 PM, O. Hartmann wr= ote: > On Thu, 5 Sep 2013 16:03:31 -0400 > Outback Dingo wrote: > > > On Thu, Sep 5, 2013 at 2:47 PM, Miroslav Lachman <000.fbsd@quip.cz> > > wrote: > > > > > Edward Tomasz Napiera=B3a wrote: > > > > > >> Wiadomo=B6=E6 napisana przez Ivan Voras w dniu = 5 > > >> wrz 2013, o godz. 13:18: > > >> > > >>> On 05/09/2013 12:27, Edward Tomasz Napiera=B3a wrote: > > >>> > > >>>> Hello. At > > >>>> http://people.freebsd.org/~**trasz/cfiscsi-20130904.diff< > http://people.freebsd.org/~trasz/cfiscsi-20130904.diff>you'll > > >>>> find a patch which adds the new iSCSI initiator and target, > > >>>> against 10-CURRENT. To use the new initiator, start with "man > > >>>> iscsictl". For the target - "man > > >>>> ctld". > > >>>> > > >>> > > >>> Just a naming question: "ctld" could mean anything, I'd parse it > > >>> as a "control deamon" or something like that. Could you name it > > >>> something which reminds the user of iscsi? Like iscsictld? > > >>> > > >> > > >> As the man page says, ctld is "CAM Target Layer / iSCSI target > > >> daemon". Sure, right now it's pretty iSCSI-specific, but it > > >> doesn't need to be - it can > > >> be extended to just manage CTL configuration (e.g. for Fibre > > >> Channel), or to support other CTL-backed storage protocols, such > > >> as FCoE. > > >> > > >> It's just a helper daemon for ctl(4) - thus, ctld(8). And in case > > >> someone does "man -k iscsi", there is the "iSCSI target" in the > > >> manual page title. > > >> > > > > > > I understand your explanation, but still thinking rc.conf variables > > > are really confusing and unintuitive: > > > > > > iscsid_enable > > > iscsictl_enable > > > ctld_enable > > > > > > I cannot tell what they control just by their names and the same > > > apply for services names. > > > > > > "If I want to restart iscsi target, should I use 'service iscsid > > > restart' or 'service iscsictl restart'? ... oh wait, it should be > > > 'service ctld restart'" > > > > > > I think it should be more user friendly. Something as Apache 2.2.x > > > has httpd and httpd.conf, but users are using 'service apache22 > > > restart' and 'apache22_enable=3D"YES"', because there can be more > > > "http" daemons. > > > > > > My $0.02 > > > > > > > > Just an FYI 10_CURRENT svn info > > Path: . > > Working Copy Root Path: /usr/src > > URL: http://svn.freebsd.org/base/head > > Relative URL: ^/head > > Repository Root: http://svn.freebsd.org/base > > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > Revision: 255253 > > Node Kind: directory > > Schedule: normal > > Last Changed Author: sjg > > Last Changed Rev: 255253 > > Last Changed Date: 2013-09-05 11:57:26 -0400 (Thu, 05 Sep 2013) > > > > > > cc -O2 -pipe -I/usr/src/usr.sbin/ctld > > -I/usr/src/usr.sbin/ctld/../../sys > > -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl > > -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 > > -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall > > -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > > -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual > > -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align > > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > > -Wold-style-definition -Wno-pointer-sign -Wno-empty-body > > -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/ctld.c cc -O2 -pipe > > -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys > > -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl > > -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 > > -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall > > -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > > -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual > > -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align > > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > > -Wold-style-definition -Wno-pointer-sign -Wno-empty-body > > -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/discovery.c cc -O2 > > -pipe -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys > > -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl > > -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 > > -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall > > -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > > -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual > > -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align > > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > > -Wold-style-definition -Wno-pointer-sign -Wno-empty-body > > -Wno-string-plus-int > > -c /usr/src/usr.sbin/ctld/kernel.c > /usr/src/usr.sbin/ctld/kernel.c:762:35: > > error: incompatible integer to pointer conversion passing 'unsigned > > long long' to parameter of type 'const cap_rights_t *' (aka 'const > > struct cap_rights *') [-Werror,-Wint-conversion] error =3D > > cap_rights_limit(ctl_fd, CAP_IOCTL); > > ^~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:197:20: > > note: expanded from macro 'CAP_IOCTL' #define CAP_IOCTL > > CAPRIGHT(1, 0x0000000000000080ULL) > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:53:28: > > note: expanded from macro 'CAPRIGHT' #define CAPRIGHT(idx, bit) > > ((1ULL << (57 + (idx))) | (bit)) > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:327:50: > > note: passing argument to parameter 'rights' here int > > cap_rights_limit(int fd, const cap_rights_t *rights); ^ 1 error > > generated. *** Error code 1 > > > > Stop. > > make[4]: stopped in /usr/src/usr.sbin/ctld > > > > > > > > > Miroslav Lachman > > > > > > ______________________________**_________________ > > > freebsd-current@freebsd.org mailing list > > > http://lists.freebsd.org/**mailman/listinfo/freebsd-**current< > http://lists.freebsd.org/mailman/listinfo/freebsd-current> > > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@** > > > freebsd.org " > > > > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to > > "freebsd-current-unsubscribe@freebsd.org" > > > > I get the very same mysterious error when compiling port > x11/nvidia-driver: > > --- nvidia_linux.o --- > nvidia_linux.c:42:37: error: incompatible integer to pointer conversion > passing 'unsigned long long' to parameter of type 'cap_rights_t *' (aka > 'struct cap_rights *') [-Werror,-Wint-conversion] if ((error =3D fget(td, > args->fd, CAP_IOCTL, &fp)) !=3D 0) ^~~~~~~~~ @/sys/capability.h:197:20: > note: expanded from macro 'CAP_IOCTL' #define CAP_IOCTL > CAPRIGHT(1, 0x0000000000000080ULL) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > @/sys/capability.h:53:28: note: expanded from macro 'CAPRIGHT' > #define CAPRIGHT(idx, bit) ((1ULL << (57 + (idx))) | (bit)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > @/sys/file.h:220:51: note: passing argument to parameter 'rightsp' here > int fget(struct thread *td, int fd, cap_rights_t *rightsp, struct file > **fpp); > > > This from CURRENT > r255211, I'm with > FreeBSD 10.0-CURRENT #1 r255249: Thu Sep 5 16:42:56 CEST 2013 amd64 > and on another box it is > FreeBSD 10.0-CURRENT #3 r255259: Thu Sep 5 20:31:20 CEST 2013 amd64 > > Got another one for you, at the kernel build =3D=3D=3D> isci (all) =3D=3D=3D> iscsi (all) cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I/usr/src/sys/modules/iscsi/../../ofed/include -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/GENERIC/opt_global.h -I. -I@ -I@/contrib/altq -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I/usr/obj/usr/src/sys/GENERIC -mno-aes -mno-avx -mcmodel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=3Diso9899:1999 -Qunused-arguments -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -c /usr/src/sys/modules/iscsi/../../dev/iscsi//icl.c /usr/src/sys/modules/iscsi/../../dev/iscsi//icl.c:1096:30: error: use of undeclared identifier 'CAP_SOCK_ALL' error =3D fget(curthread, fd, CAP_SOCK_ALL, &fp); ^ 1 error generated. *** Error code 1 Stop. make[4]: stopped in /usr/src/sys/modules/iscsi *** Error code 1 Stop. make[3]: stopped in /usr/src/sys/modules From owner-freebsd-scsi@FreeBSD.ORG Fri Sep 6 05:51:03 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9024F721; Fri, 6 Sep 2013 05:51:03 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ea0-x22e.google.com (mail-ea0-x22e.google.com [IPv6:2a00:1450:4013:c01::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id ABA7927BA; Fri, 6 Sep 2013 05:51:02 +0000 (UTC) Received: by mail-ea0-f174.google.com with SMTP id z15so1342101ead.5 for ; Thu, 05 Sep 2013 22:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=uZbbv92wfAzx+nugBiySI7/3QqdfHLSUpDywer1dZvU=; b=KUCoCEmNHcyxkKSoqnzocDEP1xicB7HzwgWiidYGSgegcYgE2NKmVjQuwBifhOBMSN vWOi004lQ1zeFfpircv0uvCHDVoMk+QslVChJggOtO1OBvvb8FChVWRyOTndYM0VA3EM 3HazI5USLxBB/qTJlZi4LKivAi/y4YunBME4WLAYNjWSojjwf2KzCsBmWgDE530+XQ/q +hpv9puTPPnsktGxyZ1fQojqn+CXMXgYC3tn/VPHsxW9gQ1J1ceq8YkahyfqGdRttH48 tSs35iPcZeOCyJa/IP5/SuR3yLrIgpQYQ8OPT7wtq9uZhyswyMNhcInk2TPxhARwXpiC O1Ag== X-Received: by 10.14.216.132 with SMTP id g4mr753869eep.62.1378446661184; Thu, 05 Sep 2013 22:51:01 -0700 (PDT) Received: from [192.168.1.102] (ajg161.neoplus.adsl.tpnet.pl. [83.25.240.161]) by mx.google.com with ESMTPSA id p5sm1238839eeg.5.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Sep 2013 22:51:00 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Content-Type: text/plain; charset=iso-8859-2 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: New iSCSI stack. From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= In-Reply-To: Date: Fri, 6 Sep 2013 07:50:59 +0200 Content-Transfer-Encoding: 7bit Message-Id: <37808388-FB41-4C92-BF7C-5BAAB22BCB70@freebsd.org> References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> <5228D1A6.4020405@quip.cz> <20130905230907.179efafd@munin.geoinf.fu-berlin.de> To: Outback Dingo X-Mailer: Apple Mail (2.1508) Cc: Miroslav Lachman <000.fbsd@quip.cz>, freebsd-current@freebsd.org, Ivan Voras , freebsd-arch@freebsd.org, freebsd-scsi@freebsd.org, "O. Hartmann" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 05:51:03 -0000 New patch, updated for Capsicum changes, is here: http://people.freebsd.org/~trasz/cfiscsi-20130906.diff From owner-freebsd-scsi@FreeBSD.ORG Fri Sep 6 07:46:57 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 15DAB4D7; Fri, 6 Sep 2013 07:46:57 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-ob0-x22f.google.com (mail-ob0-x22f.google.com [IPv6:2607:f8b0:4003:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9C5C621E6; Fri, 6 Sep 2013 07:46:56 +0000 (UTC) Received: by mail-ob0-f175.google.com with SMTP id xn12so3081903obc.20 for ; Fri, 06 Sep 2013 00:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3JbhVBQXxMxT5dfAfvG12yCitkSWtvmz4bEtb5jG7yU=; b=dLWsrdAnMPC5grWPAA5LLrfNSI872fVzAE8InUyiIZl7qoHa96Kb3L4/lNYy341fjI +jq/r2accf0gvLmQ8x/FkeuR+IVplzX+CL0t4w9S6nLl7sab8a68Awd2oNdoWinrWwO3 vLcbgPQ9qHszav0spHiQvgOrHmC8xCygpDe3BLNcbIlSDKCiNjUo/eahd490dtJ+FI1U CLMc9Sq5iOc7wwd7QE6FggpcJMXxHLsWJMt17GDQcAmQLjDr2vlf4nOrmEHbBFeT5Swy AwDkA2FMYrtA6Vuom9Y9PNqsmf7VH1C3xbAiXoTSyqNcGJ8DRe4acgj2HCWRXDxgZG4W d0pw== MIME-Version: 1.0 X-Received: by 10.60.96.169 with SMTP id dt9mr843463oeb.27.1378453615968; Fri, 06 Sep 2013 00:46:55 -0700 (PDT) Received: by 10.76.114.227 with HTTP; Fri, 6 Sep 2013 00:46:55 -0700 (PDT) In-Reply-To: <37808388-FB41-4C92-BF7C-5BAAB22BCB70@freebsd.org> References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> <5228D1A6.4020405@quip.cz> <20130905230907.179efafd@munin.geoinf.fu-berlin.de> <37808388-FB41-4C92-BF7C-5BAAB22BCB70@freebsd.org> Date: Fri, 6 Sep 2013 03:46:55 -0400 Message-ID: Subject: Re: New iSCSI stack. From: Outback Dingo To: =?ISO-8859-2?Q?Edward_Tomasz_Napiera=B3a?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Miroslav Lachman <000.fbsd@quip.cz>, freebsd-current@freebsd.org, Ivan Voras , freebsd-arch@freebsd.org, freebsd-scsi@freebsd.org, "O. Hartmann" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 07:46:57 -0000 On Fri, Sep 6, 2013 at 1:50 AM, Edward Tomasz Napiera=C5=82a wrote: > New patch, updated for Capsicum changes, is here: > > http://people.freebsd.org/~trasz/cfiscsi-20130906.diff > > Bravo.... patched, compiled successfully and tested a lun using ctld cfiscsi_ioctl_handoff: new connection from iqn.1993-08.org.debian:01:7a3a657cdd11 (192.168.122.1) to iqn.2012-06.com.example:target2 (0:2:0:0): MAINTENANCE (IN). CDB: a3 0c 01 12 00 00 00 00 02 00 00 00 (0:2:0:0): Tag: 0x0011, Type: 1 (0:2:0:0): CTL Status: SCSI Error (0:2:0:0): SCSI Status: Check Condition (0:2:0:0): SCSI sense: ILLEGAL REQUEST asc:24,0 (Invalid field in CDB) (0:2:0:0): Command byte 1 bit 4 is invalid it was mounted. partitioned, formatted ext4 and data copied to/from a linux host From owner-freebsd-scsi@FreeBSD.ORG Fri Sep 6 08:40:18 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2ADC1A5A; Fri, 6 Sep 2013 08:40:18 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ee0-x234.google.com (mail-ee0-x234.google.com [IPv6:2a00:1450:4013:c00::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 463492993; Fri, 6 Sep 2013 08:40:17 +0000 (UTC) Received: by mail-ee0-f52.google.com with SMTP id c41so1419865eek.39 for ; Fri, 06 Sep 2013 01:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Y3WlgjdZoH3tOlcwUXuE+VCvzbQ2xkCjlHp/C+bUSfU=; b=O90S/VojZLCvvJ8XHDjEVBpxQ5eI1eMDsXvZHtP4yxRyEMRf9DU2zjhdnaQ8j+xOLF Ic1/tioUtEBj0Od2b86823bRbsQ7V9amCGmNC9VHKU4AZQNgitN7G1GJIaRCJBIViara q/Pe88sW6zbRPl52OCslfHQ9ncKHfMbcAOF3LoQo2P5aLw8MSuLUn7+EDhlLxNzZKmJn U0KujkU9xkMEyZjTH/fGl7yxd4UhIa1UaWUgrHkeAjWDY8ROkX4VORTJkIIpTyBMCpgs TZAkfaGA8scqqUAbH2MdnvvzZY9VqDol4OtJGXM2BdpV8b7GWoMB4vBEGkdhNkgbx+aa Zy1A== X-Received: by 10.14.219.198 with SMTP id m46mr2289055eep.41.1378456815477; Fri, 06 Sep 2013 01:40:15 -0700 (PDT) Received: from [192.168.1.102] (ajg161.neoplus.adsl.tpnet.pl. [83.25.240.161]) by mx.google.com with ESMTPSA id j7sm2261920eeo.15.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 06 Sep 2013 01:40:15 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Content-Type: text/plain; charset=iso-8859-2 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: New iSCSI stack. From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= In-Reply-To: Date: Fri, 6 Sep 2013 10:40:13 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <70B4560F-2335-4F16-A9F4-C9E22DE908F3@freebsd.org> References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> <5228D1A6.4020405@quip.cz> <20130905230907.179efafd@munin.geoinf.fu-berlin.de> <37808388-FB41-4C92-BF7C-5BAAB22BCB70@freebsd.org> To: Outback Dingo X-Mailer: Apple Mail (2.1508) Cc: Miroslav Lachman <000.fbsd@quip.cz>, freebsd-current@freebsd.org, Ivan Voras , freebsd-arch@freebsd.org, freebsd-scsi@freebsd.org, "O. Hartmann" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 08:40:18 -0000 Wiadomo=B6=E6 napisana przez Outback Dingo w = dniu 6 wrz 2013, o godz. 09:46: > On Fri, Sep 6, 2013 at 1:50 AM, Edward Tomasz Napiera=B3a = wrote: > New patch, updated for Capsicum changes, is here: >=20 > http://people.freebsd.org/~trasz/cfiscsi-20130906.diff >=20 >=20 > Bravo.... patched, compiled successfully and tested a lun using ctld >=20 > cfiscsi_ioctl_handoff: new connection from = iqn.1993-08.org.debian:01:7a3a657cdd11 (192.168.122.1) to = iqn.2012-06.com.example:target2 > (0:2:0:0): MAINTENANCE (IN). CDB: a3 0c 01 12 00 00 00 00 02 00 00 00=20= > (0:2:0:0): Tag: 0x0011, Type: 1 > (0:2:0:0): CTL Status: SCSI Error > (0:2:0:0): SCSI Status: Check Condition > (0:2:0:0): SCSI sense: ILLEGAL REQUEST asc:24,0 (Invalid field in CDB) > (0:2:0:0): Command byte 1 bit 4 is invalid >=20 > it was mounted. partitioned, formatted ext4 and data copied to/from a = linux host Thanks! It's worth mentioning that the CTL messages like one above are = normal - it's just that Linux is trying to use some optional part of SCSI protocol the = CTL doesn't (yet) support. (You can actually tell what initiator it is, just by looking = at those - Linux tries to use MAINTENANCE IN, Windows - VERIFY, and Solaris does something = weird with mode pages.) From owner-freebsd-scsi@FreeBSD.ORG Fri Sep 6 16:36:41 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4F3A8AF0; Fri, 6 Sep 2013 16:36:41 +0000 (UTC) (envelope-from bryanv@daemoninthecloset.org) Received: from torment.daemoninthecloset.org (torment.daemoninthecloset.org [94.242.209.234]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 106FA2D9D; Fri, 6 Sep 2013 16:36:40 +0000 (UTC) Received: from sage.daemoninthecloset.org (unknown [70.114.209.60]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "sage.daemoninthecloset.org", Issuer "daemoninthecloset.org" (verified OK)) by torment.daemoninthecloset.org (Postfix) with ESMTPS id 27C6E42C25E5; Fri, 6 Sep 2013 18:42:16 +0200 (CEST) X-Virus-Scanned: amavisd-new at daemoninthecloset.org X-Virus-Scanned: amavisd-new at daemoninthecloset.org Date: Fri, 6 Sep 2013 11:36:18 -0500 (CDT) From: Bryan Venteicher To: "Kenneth D. Merry" Message-ID: <2080918238.3460.1378485378778.JavaMail.root@daemoninthecloset.org> In-Reply-To: <20130905155438.GA33654@nargothrond.kdm.org> References: <1895443574.3014.1378393339664.JavaMail.root@daemoninthecloset.org> <1292769639.3059.1378394057334.JavaMail.root@daemoninthecloset.org> <20130905155438.GA33654@nargothrond.kdm.org> Subject: Re: camcontrol SCSI sanitize MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.51.1.6] X-Mailer: Zimbra 8.0.2_GA_5569 (ZimbraWebClient - GC29 (Mac)/8.0.2_GA_5569) Thread-Topic: camcontrol SCSI sanitize Thread-Index: VVmi6XpAq6oPOc4lHmHaVHgEV7mj2g== Cc: freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 16:36:41 -0000 ----- Original Message ----- > Looks good, and pretty much how I would do it. > > Check it in! > Done in r255307. Also fixed a couple of usage nits from the original patch and some man page word-smithing. Thanks. > Ken > -- > Kenneth Merry > ken@FreeBSD.ORG > From owner-freebsd-scsi@FreeBSD.ORG Fri Sep 6 18:18:34 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 91964810; Fri, 6 Sep 2013 18:18:34 +0000 (UTC) (envelope-from bright@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 7DEAF24A3; Fri, 6 Sep 2013 18:18:34 +0000 (UTC) Received: from Alfreds-MacBook-Pro-9.local (c-67-180-208-218.hsd1.ca.comcast.net [67.180.208.218]) by elvis.mu.org (Postfix) with ESMTPSA id 117161A3D04; Fri, 6 Sep 2013 11:18:28 -0700 (PDT) Message-ID: <522A1C73.9030402@mu.org> Date: Fri, 06 Sep 2013 11:18:27 -0700 From: Alfred Perlstein User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: =?UTF-8?B?RWR3YXJkIFRvbWFzeiBOYXBpZXJhxYJh?= Subject: Re: New iSCSI stack. References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-scsi@freebsd.org, "freebsd-current@FreeBSD.org" , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 18:18:34 -0000 On 9/5/13 3:27 AM, Edward Tomasz NapieraÅ‚a wrote: > Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diff you'll find > a patch which adds the new iSCSI initiator and target, against 10-CURRENT. > To use the new initiator, start with "man iscsictl". For the target - "man > ctld". > > All feedback is welcome. If nothing unexpected comes up, I'll commit it > in a few days from now. Note that it's still not optimized; at this point > I'm focusing more on reliability and interoperability. > > This work is being sponsored by FreeBSD Foundation. > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > Edward, this is really exciting! Is there an easy way to use the userland iscsi configuration files? We would love to quickly backport and ship this with FreeNAS as an option for our users, having the config files be the same OR having a very good converter would really make that much easier for us. -- Alfred Perlstein From owner-freebsd-scsi@FreeBSD.ORG Fri Sep 6 18:37:29 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 821) id 03D8B225; Fri, 6 Sep 2013 18:37:29 +0000 (UTC) Date: Fri, 6 Sep 2013 18:37:29 +0000 From: John To: FreeBSD SCSI Subject: Re: Hung boot - mps related? Message-ID: <20130906183728.GA68463@FreeBSD.org> References: <20130905022028.GA28801@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130905022028.GA28801@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 18:37:29 -0000 ----- John's Original Message ----- > Hi Folks, > > I updated one of my servers today to the latest 9-stable. The system > starts to boot up and then hangs with the following: > > mps1: _mapping_add_new_device: failed to add the device with handle 0xe1 to persistent table because there is no free space available > > run_interupt_driven_hooks: still waiting after 60 seconds for xpt_config > run_interupt_driven_hooks: still waiting after 120 seconds for xpt_config > run_interupt_driven_hooks: still waiting after 180 seconds for xpt_config > run_interupt_driven_hooks: still waiting after 240 seconds for xpt_config > run_interupt_driven_hooks: still waiting after 300 seconds for xpt_config Well, there's nothing like following up on your own posting. My apologies for not seeing this one sooner. One of my 9207-8e cards didn't have an up-to-date bios/firmware on it. After downloading the latest from the LSI website, the system once again boots up correctly, and a bit more quickly. For the record: # sas2flash -biosall mptsas2.rom ... # sas2flash -fwall 9207-8e.bin ... # sas2flash -listall LSI Corporation SAS2 Flash Utility Version 17.00.00.00 (2013.07.19) Copyright (c) 2008-2013 LSI Corporation. All rights reserved Adapter Selected is a LSI SAS: SAS2308_2(D1) Num Ctlr FW Ver NVDATA x86-BIOS PCI Addr ---------------------------------------------------------------------------- 0 SAS2308_2(D1) 17.00.01.00 11.00.00.05 07.33.00.00 00:0a:00:00 1 SAS2308_2(D1) 17.00.01.00 11.00.00.05 07.33.00.00 00:27:00:00 Finished Processing Commands Successfully. Exiting SAS2Flash. From owner-freebsd-scsi@FreeBSD.ORG Fri Sep 6 20:04:00 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A6525CBB; Fri, 6 Sep 2013 20:04:00 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6EF4F2FE5; Fri, 6 Sep 2013 20:04:00 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id kp13so3728681pab.21 for ; Fri, 06 Sep 2013 13:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HyfdKpJFA3yMtWuosY6VpKkA3vbmdh2fRcTZHMQ4v/A=; b=pQEACMPv8u89vc1e3uipD8YR+7KFqf+TAXDndNbJl0+kINBaneIS0nNRZqvoqKH+1J /GUZ31HSUIl3waoRoFnkei2UYnbFSvH+1JM2j8ER7cJiLvJ0hN2xg70rBqn61Ksace3o sD6H8Kp+MXSY397Tv4tRGBFw7xwqPGWjIDhRg4M6vuSFQ750gJe7g3UJVdzLPzf/opsa mvQ58bGIOSuy2LPiAKWzVStu0uSLKujl7PgURBbg+LPLBna1pmJRflCMOSB7qYHlwlwX qB+hIt1AwNrcLBWPODwDPgBA9JBX4uhV22cFgx5TwdbKYXJUGeiaJDW+WhmQgBJyzFPU SOug== MIME-Version: 1.0 X-Received: by 10.68.125.226 with SMTP id mt2mr4824020pbb.115.1378497839868; Fri, 06 Sep 2013 13:03:59 -0700 (PDT) Received: by 10.66.126.141 with HTTP; Fri, 6 Sep 2013 13:03:59 -0700 (PDT) In-Reply-To: <522A1C73.9030402@mu.org> References: <522A1C73.9030402@mu.org> Date: Fri, 6 Sep 2013 16:03:59 -0400 Message-ID: Subject: Re: New iSCSI stack. From: Outback Dingo To: Alfred Perlstein Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-scsi@freebsd.org, "freebsd-current@FreeBSD.org" , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 20:04:00 -0000 On Fri, Sep 6, 2013 at 2:18 PM, Alfred Perlstein wrote: > On 9/5/13 3:27 AM, Edward Tomasz Napiera=C5=82a wrote: > >> Hello. At http://people.freebsd.org/~**trasz/cfiscsi-20130904.diffyou'll find >> a patch which adds the new iSCSI initiator and target, against 10-CURREN= T. >> To use the new initiator, start with "man iscsictl". For the target - >> "man >> ctld". >> >> All feedback is welcome. If nothing unexpected comes up, I'll commit it >> in a few days from now. Note that it's still not optimized; at this poi= nt >> I'm focusing more on reliability and interoperability. >> >> This work is being sponsored by FreeBSD Foundation. >> >> ______________________________**_________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/**mailman/listinfo/freebsd-**current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@** >> freebsd.org " >> >> Edward, this is really exciting! > > Is there an easy way to use the userland iscsi configuration files? > > We would love to quickly backport and ship this with FreeNAS as an option > for our users, having the config files be the same OR having a very good > converter would really make that much easier for us. > > > your going to have to backport more then just this as capsicum and the IC= L stuff is iSCSI Common Layer, we went to try but kept getting caught up in the ICL breakage also, but removal of all references in the patch to capsicum, it was 4-6 files i belive, will get at least ctld and iscsi to build, now you need the new cam which needs better eyes then mine to fix in a back port due to icl version differences in 9 and 10. > > -- > Alfred Perlstein > > > ______________________________**_________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/**mailman/listinfo/freebsd-**current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@** > freebsd.org " > From owner-freebsd-scsi@FreeBSD.ORG Fri Sep 6 20:06:15 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B84BD91; Fri, 6 Sep 2013 20:06:15 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-pb0-x233.google.com (mail-pb0-x233.google.com [IPv6:2607:f8b0:400e:c01::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7F98E2077; Fri, 6 Sep 2013 20:06:15 +0000 (UTC) Received: by mail-pb0-f51.google.com with SMTP id jt11so3621740pbb.38 for ; Fri, 06 Sep 2013 13:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=PiMU+6Iosf4CIyrL/9VcXH8DbpU3e36DE7eq832neMY=; b=r0NlwZSwDvy7XYR33a37NQLBccTumJbwTvyhW4kwL80j7y04WmThGvVJovq48uOBAO VggWVmlHGwalwEOnsGi2tZQSljdc+DWSmXDCqoIzkBZ5UEBpVHyZI9EbuQlSzm/ug+k2 ixv7XgcMjdwN0OjtP3Z7qT6tTG4z5guC7I7Pk/o+RyR8s12F5P2U7iDySlDX/E4wvrW7 P+SCtkTJ0BPvUEugANrdA76SyOxslpiDNWfjfHBeVUZJ2YQUVkPi9teB2k89tK162zd5 pTecRKrbku4BmOjyDM1xC5x6AW1i/UefXEqq3mX8cLrqYMr27bwBqdspnb8p4niQcWTe b+Mw== MIME-Version: 1.0 X-Received: by 10.67.21.130 with SMTP id hk2mr6016873pad.76.1378497975139; Fri, 06 Sep 2013 13:06:15 -0700 (PDT) Received: by 10.66.126.141 with HTTP; Fri, 6 Sep 2013 13:06:15 -0700 (PDT) In-Reply-To: References: <522A1C73.9030402@mu.org> Date: Fri, 6 Sep 2013 16:06:15 -0400 Message-ID: Subject: Re: New iSCSI stack. From: Outback Dingo To: Alfred Perlstein Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-scsi@freebsd.org, "freebsd-current@FreeBSD.org" , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 20:06:15 -0000 On Fri, Sep 6, 2013 at 4:03 PM, Outback Dingo wrote= : > > > > On Fri, Sep 6, 2013 at 2:18 PM, Alfred Perlstein wrote: > >> On 9/5/13 3:27 AM, Edward Tomasz Napiera=C5=82a wrote: >> >>> Hello. At http://people.freebsd.org/~**trasz/cfiscsi-20130904.diffyou'll find >>> a patch which adds the new iSCSI initiator and target, against >>> 10-CURRENT. >>> To use the new initiator, start with "man iscsictl". For the target - >>> "man >>> ctld". >>> >>> All feedback is welcome. If nothing unexpected comes up, I'll commit i= t >>> in a few days from now. Note that it's still not optimized; at this >>> point >>> I'm focusing more on reliability and interoperability. >>> >>> This work is being sponsored by FreeBSD Foundation. >>> >>> ______________________________**_________________ >>> freebsd-current@freebsd.org mailing list >>> http://lists.freebsd.org/**mailman/listinfo/freebsd-**current >>> To unsubscribe, send any mail to "freebsd-current-unsubscribe@** >>> freebsd.org " >>> >>> Edward, this is really exciting! >> >> Is there an easy way to use the userland iscsi configuration files? >> >> We would love to quickly backport and ship this with FreeNAS as an optio= n >> for our users, having the config files be the same OR having a very good >> converter would really make that much easier for us. >> >> >> your going to have to backport more then just this as capsicum and the > ICL stuff is iSCSI Common Layer, we went to try but kept getting caught u= p > in the ICL breakage also, but removal of all references in the patch to > capsicum, it was 4-6 files i belive, will get at least ctld and iscsi to > build, now you need the new cam which needs better eyes then mine to fix = in > a back port due to icl version differences in 9 and 10. > > > And i used this config as a simple test.... ctld.conf cat /etc/ctl.conf pidfile /var/run/ctld.pid # auth-group example2 { # chap-mutual "user" "secret" "mutualuser22" "mutualsecret" # chap-mutual "user2" "secret2" "mutualuser22" "mutualsecret" # } portal-group example2 { discovery-auth-group no-authentication listen 127.0.0.1 listen 0.0.0.0:3261 listen [::]:3261 } target iqn.2012-06.com.example:target0 { auth-group no-authentication portal-group example2 lun 0 { path /home/dingo/example_0 blocksize 4096 size 4G } } target iqn.2012-06.com.example:target3 { auth-group no-authentication portal-group example2 lun 0 { path /home/dingo/example_3 blocksize 4096 size 4G } } target iqn.2012-06.com.example:target2 { auth-group no-authentication portal-group example2 lun 0 { path /home/dingo/example2_0 blocksize 4096 size 4G } lun 1 { path /home/dingo/example2_1 blocksize 4096 size 4G } } so your 9.x config mileage might vary > >> -- >> Alfred Perlstein >> >> >> ______________________________**_________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/**mailman/listinfo/freebsd-**current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@** >> freebsd.org " >> > >