From owner-freebsd-bugs@FreeBSD.ORG Thu Oct 20 15:30:21 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D20E316A41F for ; Thu, 20 Oct 2005 15:30:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35C7F43D5A for ; Thu, 20 Oct 2005 15:30:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9KFULlA029784 for ; Thu, 20 Oct 2005 15:30:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9KFUKT7029783; Thu, 20 Oct 2005 15:30:21 GMT (envelope-from gnats) Date: Thu, 20 Oct 2005 15:30:21 GMT Message-Id: <200510201530.j9KFUKT7029783@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Bradley T Hughes Cc: Subject: Re: bin/87729: most calls to malloc(3) generate warnings in valgrind X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bradley T Hughes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2005 15:30:22 -0000 The following reply was made to PR bin/87729; it has been noted by GNATS. From: Bradley T Hughes To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org Cc: Subject: Re: bin/87729: most calls to malloc(3) generate warnings in valgrind Date: Thu, 20 Oct 2005 17:24:15 +0200 This is a multi-part message in MIME format. --------------070208000107050800030908 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit FreeBSD-gnats-submit@FreeBSD.org wrote: > Thank you very much for your problem report. > It has the internal identification `bin/87729'. > The individual assigned to look at your > report is: freebsd-bugs. > > You can access the state of your problem report at any time > via this link: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=87729 > > >>Category: bin >>Responsible: freebsd-bugs >>Synopsis: most calls to malloc(3) generate warnings in valgrind >>Arrival-Date: Thu Oct 20 15:20:18 GMT 2005 Here is the patch that I couldn't attach when using the web form. -- Bradley T. Hughes - bhughes at trolltech.com Trolltech AS - Waldemar Thranes gt. 98 N-0175 Oslo, Norway --------------070208000107050800030908 Content-Type: text/plain; name="malloc.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="malloc.c.diff" --- malloc.c Wed Oct 19 13:30:01 2005 +++ malloc.c~ Wed Oct 19 13:29:01 2005 @@ -635,8 +635,11 @@ for(;k-i >= MALLOC_BITS; i += MALLOC_BITS) bp->bits[i / MALLOC_BITS] = ~0; - for(; i < k; i++) - bp->bits[i/MALLOC_BITS] |= 1<<(i%MALLOC_BITS); + if (i < k) { + bp->bits[i/MALLOC_BITS] = 0; + for(; i < k; i++) + bp->bits[i/MALLOC_BITS] |= 1<<(i%MALLOC_BITS); + } if (bp == bp->page) { /* Mark the ones we stole for ourselves */ --------------070208000107050800030908--