Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 14 Apr 2004 13:48:49 -0700 (PDT)
From:      Stephan Uphoff <ups@tree.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   kern/65548: misplaced bracket in m_getcl (subr_mbuf.c)
Message-ID:  <200404142048.i3EKmmJg026456@www.freebsd.org>
Resent-Message-ID: <200404142050.i3EKoFH4025051@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help 

>Number:         65548
>Category:       kern
>Synopsis:       misplaced bracket in m_getcl (subr_mbuf.c)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 14 13:50:15 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Stephan Uphoff
>Release:        current
>Organization:
>Environment:
N/A
>Description:
misplaced bracket in m_getcl

	if (mb->m_ext.ext_buf == NULL) {
		(void)m_free(mb);
		mb = NULL;
	} else {
		_mcl_setup(mb);
		_mext_init_ref(mb, &cl_refcntmap[cl2ref(mb->m_ext.ext_buf)]);
	}
#ifdef MAC
	if (flags & M_PKTHDR) {
		if (mac_init_mbuf(mb, MBTOM(how)) != 0) {
			m_free(mb);
			return (NULL);
		}
	}
#endif


should be


	if (mb->m_ext.ext_buf == NULL) {
		(void)m_free(mb);
		mb = NULL;
	} else {
		_mcl_setup(mb);
		_mext_init_ref(mb, &cl_refcntmap[cl2ref(mb->m_ext.ext_buf)]);
	
#ifdef MAC
		if (flags & M_PKTHDR) {
			if (mac_init_mbuf(mb, MBTOM(how)) != 0) {
				m_free(mb);
				return (NULL);
			}
		}
#endif
       }
>How-To-Repeat:
      
>Fix:
      
>Release-Note:
>Audit-Trail:
>Unformatted:

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404142048.i3EKmmJg026456>