Date: Sun, 31 Jul 2011 01:48:03 -0700 From: Doug Barton <dougb@FreeBSD.org> To: C++ RTMP Server Support <support@rtmpd.com> Cc: Jin-Sih Lin <linpct@gmail.com>, cvs-ports@FreeBSD.org, Li-Wen Hsu <lwhsu@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/crtmpserver Makefile distinfo pkg-plist ports/net/crtmpserver/files crtmpserver.in Message-ID: <4E3516C3.9070605@FreeBSD.org> In-Reply-To: <7C192122-697C-49BB-AADB-446C24962000@rtmpd.com> References: <201107301549.p6UFn7rK070976@repoman.freebsd.org> <4E3495B0.3070405@FreeBSD.org> <D2E25D19-0A8E-4081-BB71-81EE07A2BC77@rtmpd.com> <4E35108D.1040907@FreeBSD.org> <4E3510F7.2000405@FreeBSD.org> <7C192122-697C-49BB-AADB-446C24962000@rtmpd.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/31/2011 01:34, C++ RTMP Server Support wrote:
> Oh, I see the difference now. You basically use another construct to
> gather the (default) values. IMHO, my solution is much much clear
> because all variables which are read from rc.conf are in one single
> place and for beginners like me the script is easier to read.
>
> Besides, you remove one variable (crtmpserver_config) and you put
> it's default value inside the required_files variable, but you add
> another one called pidfile.
>
> Again, IMHO, my version is easier to read.
You still don't understand.
pidfile= is a requirement. As I said in my first message, it's special
to rc.subr. This needs to be fixed.
As for how pidfile= and required_files= are set, that's a style issue
that I'm less concerned about. What you are saying is that this is
easier to read:
: ${name_config:=foo}
: ${name_pidfile:=bar}
required_files=$name_config
pidfile=$name_pidfile
What I'm saying is that doing it that way means that you're working
harder than you have to. The way I had it in the patch means that each
variable only has to be handled once. It may be slightly more difficult
to read for novices, but it's not _that_ complex; and reduces the
chances that a mistake will be made. However, if you choose not to use
the style that I suggested, I'm not too concerned about that.
However, the pidfile issue has to be fixed.
Doug
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E3516C3.9070605>