Date: Mon, 21 Jul 2014 01:33:42 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: John Marino <freebsd.contact@marino.st> Cc: svn-ports-head@freebsd.org, kwm@FreeBSD.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r362304 - head/x11-toolkits/pango Message-ID: <20140721013342.6c17ecdc@kalimero.tijl.coosemans.org> In-Reply-To: <53CBF2D7.4070005@marino.st> References: <201407200815.s6K8FG8b003096@svn.freebsd.org> <20140720132259.156d687e@kalimero.tijl.coosemans.org> <53CBA770.2010409@marino.st> <20140720113124.GD26778@ivaldir.etoilebsd.net> <20140720165256.1f4d5d07@kalimero.tijl.coosemans.org> <53CBF2D7.4070005@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 20 Jul 2014 18:48:23 +0200 John Marino wrote: > On 7/20/2014 16:52, Tijl Coosemans wrote: >> On Sun, 20 Jul 2014 13:31:24 +0200 Baptiste Daroussin wrote: >>> On Sun, Jul 20, 2014 at 01:26:40PM +0200, John Marino wrote: >>>> On 7/20/2014 13:22, Tijl Coosemans wrote: >>>>> On Sun, 20 Jul 2014 08:15:16 +0000 (UTC) John Marino wrote: >>>>>> Author: marino >>>>>> Date: Sun Jul 20 08:15:16 2014 >>>>>> New Revision: 362304 >>>>>> URL: http://svnweb.freebsd.org/changeset/ports/362304 >>>>>> QAT: https://qat.redports.org/buildarchive/r362304/ >>>>>> >>>>>> Log: >>>>>> x11-toolkits/pango: require explicit linking >>>>>> >>>>>> This new configure argument will list all required libraries in the >>>>>> generated pkgconf files. Before any library indirectly pulled in, such >>>>>> as libm, was not listed. >>>>>> >>>>>> This fixes numerous regression in dports and it's more correct anyway. >>>>> >>>>> No, this is wrong. Each port should link to the libraries it needs on >>>>> its own. No port should rely on other ports to pull in libraries for >>>>> them. >>>> >>>> Then I guess we really don't need pkgconfig .pc files at all then? >>>> (This is the point of .pc files, it tells how to link. libm is directly >>>> used by pango) >>>> >>>> so no, it is not wrong. The generated pc file was wrong, now it's not. >>>> This is why the configuration argument exists. >> >> A .pc file normally has 1 library in the Libs field (the library the .pc >> file is created for) and 0 items in the Requires field. Dependencies go >> in the Libs.private or Requires.private fields. The only reason to add >> dependencies to Libs or Requires is if the headers of the library expose >> the API of those dependencies (e.g. the library headers define macros or >> inline functions that expand to calls to functions in a dependency (such >> as Gtk macros that expand to Glib function calls)). >> >> The pango headers don't even include math.h or complex.h so they cannot >> expose its API. The generated .pc file was correct, now it is wrong. >> >> The reason the configure argument exists is probably because this is an >> old .pc file from before the .private fields existed. > > Again, linking libpango without -libm is an error when explicit linking > is required (as has been the default on binutils for the last 3 > versions). The previous pc did not consider -lm, so it's wrong. No and no. > The proof is in the pudding. When enabling the explicit linking > configure option, it fixed all the explict linking errors seen by ports > depending on pango. Show me such a port. > The is not the only port that sets the explicit-depends configure option > either. Yes I know. It must all be removed. The worst case is the gtk20 port which forces everything that uses gtk20 to link with many Xorg libraries for no reason. > What is the concern here? The concern is overlinking. You are forcing everything that uses pango to link with libm just to fix a few ports that require libm but forget to link with it explicitly. You are also forcing everything that uses pangocairo to link with libfreetype and libfontconfig now.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140721013342.6c17ecdc>