From owner-cvs-all Mon Jun 24 14:34:53 2002 Delivered-To: cvs-all@freebsd.org Received: from overcee.wemm.org (12-232-114-102.client.attbi.com [12.232.114.102]) by hub.freebsd.org (Postfix) with ESMTP id 92BC637B409; Mon, 24 Jun 2002 14:34:37 -0700 (PDT) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 33750380E; Mon, 24 Jun 2002 14:34:41 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Martin Faxer Cc: David Greenman-Lawrence , Alfred Perlstein , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c In-Reply-To: <20020624195633.GC2134@lockdown.spectrum.fearmuffs.net> Date: Mon, 24 Jun 2002 14:34:41 -0700 From: Peter Wemm Message-Id: <20020624213441.33750380E@overcee.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Martin Faxer wrote: > On 2002.06.24 12:27:16 +0000, Peter Wemm wrote: > > Martin Faxer wrote: > > > i think you add a new syscall entity in syscalls.master for the new > > > syscall (like nsendfile()) and then update libc to call that instead > > > of the old syscall. > > > > > > then all old cold will still call osendfile() but code linked with a > > > newer libc will call the new one. > > > > libc syscall stubs are auto-generated from the kernel syscall list. > > Doing this would cause libc to have 'nsendfile' instead of 'sendfile'. > > Of course, if you are prepared to add #define sendfile nsendfile in an > > include file, then that works. > > ok, thanks for clearing that up. I wasn't exactly sure how that part > worked. > > what actually prompted me to write the nsendfile() thing was > that I quickly checked syscalls.master and saw entries for n[lf]stat(). > upon checking more closely that might be something else though, and not > related at all to "new" stat() functions, I'm not sure... Those are NetBSD [lf]stat() syscalls using a [stale] NetBSD style struct stat. They use other syscalls these days so they are a bit silly now. > so in this case, what is the correct procedure to follow ? > do you add a new sendfile() entity to syscalls.master and mark the old > one as "COMPAT" (will that "change" its name to osendfile() ?) or do you > simply rename it (the old one) to osendfile() ? Yes. Normally it would also have a libc version bump, but we've already done that for 5.x and it would be rather bad at this stage for 4.x :-(. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message