Date: Thu, 29 Sep 2005 16:50:12 GMT From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/86710: Update bin/ls to have option to cancel -A with super user Message-ID: <200509291650.j8TGoCQa067608@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/86710; it has been noted by GNATS. From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Marcus Alves Grando <mnag@freebsd.org> Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: bin/86710: Update bin/ls to have option to cancel -A with super user Date: Thu, 29 Sep 2005 19:48:33 +0300 On 2005-09-29 11:50, Marcus Alves Grando <mnag@freebsd.org> wrote: > + /* Root is -A automatically. */ > + if (!getuid() && !f_nolistdot) > + f_listdot = 1; > + If you are going to touch this check, then please change it to avoid the use of the !condition idiom :) if (getuid() == 0 && f_nolistdot == 0) f_listdot = 1;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200509291650.j8TGoCQa067608>